From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40031) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9ezP-0006EB-N2 for qemu-devel@nongnu.org; Thu, 17 Dec 2015 15:17:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a9ezM-0004FG-FE for qemu-devel@nongnu.org; Thu, 17 Dec 2015 15:17:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56538) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9ezM-0004FC-9r for qemu-devel@nongnu.org; Thu, 17 Dec 2015 15:17:24 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id DD18EC0B9317 for ; Thu, 17 Dec 2015 20:17:23 +0000 (UTC) References: <1450371004-26866-1-git-send-email-armbru@redhat.com> <1450371004-26866-8-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <56731853.5010002@redhat.com> Date: Thu, 17 Dec 2015 13:17:23 -0700 MIME-Version: 1.0 In-Reply-To: <1450371004-26866-8-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Dovk6ovpcBGVd3jMvwJFgQJrHegwWNEpc" Subject: Re: [Qemu-devel] [PATCH v2 07/23] qemu-nbd: Clean up "Failed to load snapshot" error message List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Dovk6ovpcBGVd3jMvwJFgQJrHegwWNEpc Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/17/2015 09:49 AM, Markus Armbruster wrote: > bdrv_snapshot_load_tmp() sets an error and returns -errno on failure. > We report both even though the error message is self-contained. Drop > the redundant strerror(). >=20 > While there: setting errno right before exit() is pointless, so drop > that, too. >=20 > Signed-off-by: Markus Armbruster > --- > qemu-nbd.c | 14 +++++--------- > 1 file changed, 5 insertions(+), 9 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Dovk6ovpcBGVd3jMvwJFgQJrHegwWNEpc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWcxhTAAoJEKeha0olJ0NqVZsH/1qZBW/1Fv/dmKoV/4hG0tt/ TF3UkCmsjnbiokxFvhPTbl59gXpaqykaUgbAP/ajm3AsMKtykOmzQ7BcUV/P0r+z FcjeTWuOly3ZFhtTYuLY1BdEvatknQFgkdp0F26L+za3iP8o0JakVCqpXKZgh9Qb 7WXLGoyR4hAZxBAVQbj6qsaKGFdDba272h2yKBOeKJYkGgmeQBP0GuP7lV+6WRd5 sr+h1+szifjRWgXdx3s/2KgfaaED/XNizf90srdlgTJ7HjXEcRyvkMGJ20Lzl8ns IfLAMA+3vZqgjGzXqIS1vjuzoXlW5wwsWNyrFBpxY3n2SaE3d9utmV315wkjgdY= =Zf/M -----END PGP SIGNATURE----- --Dovk6ovpcBGVd3jMvwJFgQJrHegwWNEpc--