From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40358) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9f1i-0007Pk-8o for qemu-devel@nongnu.org; Thu, 17 Dec 2015 15:19:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a9f1f-0004Rc-3j for qemu-devel@nongnu.org; Thu, 17 Dec 2015 15:19:50 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47702) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a9f1e-0004RW-UF for qemu-devel@nongnu.org; Thu, 17 Dec 2015 15:19:47 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 7BF2B32D3BC for ; Thu, 17 Dec 2015 20:19:46 +0000 (UTC) References: <1450371004-26866-1-git-send-email-armbru@redhat.com> <1450371004-26866-9-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <567318E1.7000606@redhat.com> Date: Thu, 17 Dec 2015 13:19:45 -0700 MIME-Version: 1.0 In-Reply-To: <1450371004-26866-9-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="meMM964Kgcw3h5i3prbRRF54tPWLBDmrh" Subject: Re: [Qemu-devel] [PATCH v2 08/23] test-throttle: Simplify qemu_init_main_loop() error handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --meMM964Kgcw3h5i3prbRRF54tPWLBDmrh Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/17/2015 09:49 AM, Markus Armbruster wrote: > The code looks like it tries to check for both qemu_init_main_loop() > and qemu_get_aio_context() failure in one conditional. In fact, > qemu_get_aio_context() can fail only after qemu_init_main_loop() > failed. >=20 > Simplify accordingly: check for qemu_init_main_loop() error directly, > without bothering to improve its error message. Call > qemu_get_aio_context() only when qemu_get_aio_context() succeeded. It > can't fail then, so no need to check. >=20 > Signed-off-by: Markus Armbruster > --- > tests/test-throttle.c | 15 +-------------- > 1 file changed, 1 insertion(+), 14 deletions(-) Much simpler :) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --meMM964Kgcw3h5i3prbRRF54tPWLBDmrh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWcxjhAAoJEKeha0olJ0NqdVEIAJqVe6c6G0f9FYlJWTb0XdiZ hLcpT84087T9jT1hv8ubM3lV0yQZ89NF6L3lZGFua9AIy4lwfOBLiW2zY0ewwujZ Fc4rIpgMK7hAPKN2InAstCZ7tDQmmuV0LB9oIB3S6hGwRXtickiX1AaRTLCVz2Jq pFgrO+itaAyrP3PGFjO7mDGVouTs0fWvXzFYlcF1R/TJq3vhaVJz8M3IrhlehgAA Qy9/41gC+IDQuBzOS/qP8pcecnc6ueXAix7S0BhJWTXn6ziSMUr7vPZs5PqrjQy5 jt1tFSunrMtCkh26Rm5/Qs/JxMCUgqHj0WEWveb2szNt0Zz43vtW4hzY1+XMgjM= =u8Nu -----END PGP SIGNATURE----- --meMM964Kgcw3h5i3prbRRF54tPWLBDmrh--