Re: [Qemu-devel] [PATCH v2 16/23] error: Strip trailing '\n' from error string arguments (again)

From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: Fam Zheng <famz@redhat.com>,
	zhanghailiang <zhang.zhanghailiang@huawei.com>,
	Stefan Berger <stefanb@linux.vnet.ibm.com>,
	Markus Armbruster <armbru@pond.sub.org>,
	Pavel Fedin <p.fedin@samsung.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Dominik Dingel <dingel@linux.vnet.ibm.com>,
	David Hildenbrand <dahi@linux.vnet.ibm.com>,
	Peter Crosthwaite <crosthwaitepeter@gmail.com>,
	"Jason J. Herne" <jjherne@linux.vnet.ibm.com>,
	Bharata B Rao <bharata@linux.vnet.ibm.com>,
	Changchun Ouyang <changchun.ouyang@intel.com>
Subject: Re: [Qemu-devel] [PATCH v2 16/23] error: Strip trailing '\n' from error string arguments (again)
Date: Thu, 17 Dec 2015 13:57:05 -0700	[thread overview]
Message-ID: <567321A1.3070808@redhat.com> (raw)
In-Reply-To: <1450371004-26866-17-git-send-email-armbru@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1398 bytes --]

On 12/17/2015 09:49 AM, Markus Armbruster wrote:
> Commit 6daf194d, be62a2eb and 312fd5f got rid of a bunch, but they
> keep coming back.  Tracked down with the Coccinelle semantic patch
> from commit 312fd5f.

Don't forget to rerun this to pick up stragglers exposed by 1/23 :)

> Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> Acked-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
> Acked-by: Fam Zheng <famz@redhat.com>

If you want to add to the list:
Reviewed-by: Eric Blake <eblake@redhat.com>

> +++ b/hw/s390x/s390-skeys.c
> @@ -191,8 +191,8 @@ static int qemu_s390_skeys_set(S390SKeysState *ss, uint64_t start_gfn,
>      /* Check for uint64 overflow and access beyond end of key data */
>      if (start_gfn + count > skeydev->key_count || start_gfn + count < count) {
>          error_report("Error: Setting storage keys for page beyond the end "
> -                "of memory: gfn=%" PRIx64 " count=%" PRId64 "\n", start_gfn,
> -                count);
> +                     "of memory: gfn=%" PRIx64 " count=%" PRId64,
> +                     start_gfn, count);

Do we want a separate patch cleaning up 'Error: ' prefixes?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]