From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966166AbbLRDJh (ORCPT ); Thu, 17 Dec 2015 22:09:37 -0500 Received: from szxga03-in.huawei.com ([119.145.14.66]:6000 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964901AbbLRDJf (ORCPT ); Thu, 17 Dec 2015 22:09:35 -0500 Message-ID: <567377D0.6080302@huawei.com> Date: Fri, 18 Dec 2015 11:04:48 +0800 From: "Wangnan (F)" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Daniel Wagner , , , , , , , , , , , CC: , Subject: Re: [PATCH 00/10] bpf samples: Uses libbpf in tools/lib to do BPF operations References: <1450329794-161948-1-git-send-email-wangnan0@huawei.com> <56725868.6080902@bmw-carit.de> <56725B67.2010309@huawei.com> <56725E59.6090507@bmw-carit.de> <56727259.80002@bmw-carit.de> <567289D6.9050209@huawei.com> <5672BC99.4070605@bmw-carit.de> In-Reply-To: <5672BC99.4070605@bmw-carit.de> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.66.109] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020204.567377E4.0129,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 58296bd2132d0824238b0c68449bc137 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/12/17 21:46, Daniel Wagner wrote: > On 12/17/2015 11:09 AM, Wangnan (F) wrote: >> On 2015/12/17 16:29, Daniel Wagner wrote: >>> On 12/17/2015 08:03 AM, Daniel Wagner wrote: >>> Patch number 2 didn't apply cleanly. >> Because I have another patch in my local tree which also modifis bpf >> Makefile: >> >> http://lkml.kernel.org/g/1450316632-152513-1-git-send-email-wangnan0@huawei.com >> >> sorry. > Ah, that explains it this problem. > >>> After fixing this manually >>> I was able to continue to the build step: >>> >>> $ make samples/bpf/ >>> CHK include/config/kernel.release >>> CHK include/generated/uapi/linux/version.h >>> CHK include/generated/utsrelease.h >>> CHK include/generated/bounds.h >>> CHK include/generated/timeconst.h >>> CHK include/generated/asm-offsets.h >>> CALL scripts/checksyscalls.sh >>> make -C /home/wagi/src/linux/tools/lib/bpf >>> O=/home/wagi/src/linux/samples/bpf/libbpf CFLAGS= LDFLAGS= V=1 >>> /home/wagi/src/linux/samples/bpf/libbpf/libbpf.a >>> No libelf found >>> Makefile:203: recipe for target 'elfdep' failed >>> make[2]: *** [elfdep] Error 255 >>> samples/bpf/Makefile:10: recipe for target >>> 'samples/bpf/libbpf/libbpf.a' failed >>> make[1]: *** [samples/bpf/libbpf/libbpf.a] Error 2 >>> Makefile:1550: recipe for target 'samples/bpf/' failed >>> make: *** [samples/bpf/] Error 2 >> When you see this, could you please have a look at: >> >> /home/wagi/src/linux/samples/bpf/libbpf/feature/test-*.make.output >> >> ? > test-libpython.c:1:20: fatal error: Python.h: No such file or directory So it is the content in test-all.make.output ? Then it is not a problem. It is only a fastpath which tries to check all features by one test. On most platform it would fail. BPF related feature check is not in test-all. It is a potential bug, but I don't think it causes your problem. Another problem is you didn't see this in the first failure: Auto-detecting system features: ... libelf: [ on ] ... bpf: [ on ] This only happen when you already have a FEATURE-DUMP.libbpf in that directory and it is same as the feature check result. Could you please remove samples/bpf in your building tree and try again? After you see the failure, what's the content of /home/wagi/src/linux/samples/bpf/libbpf/FEATURE-* ? Thank you.