From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935078AbbLRJO4 (ORCPT ); Fri, 18 Dec 2015 04:14:56 -0500 Received: from mailgw01.hosei.ac.jp ([133.25.1.21]:50865 "EHLO mailgw01.hosei.ac.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753877AbbLRJMp (ORCPT ); Fri, 18 Dec 2015 04:12:45 -0500 Authentication-Results: mailgw01.hosei.ac.jp; sender-id=none header.from=akihiko.odaki.4i@stu.hosei.ac.jp; spf=none smtp.mfrom=akihiko.odaki.4i@stu.hosei.ac.jp Subject: Re: [PATCH 1/2] HID: Use multitouch driver for Type Covers To: Donavan Lance , Bastien Nocera References: <1450097429-4959-1-git-send-email-akihiko.odaki.4i@stu.hosei.ac.jp> <1450099368.3358.5.camel@hadess.net> <5673A785.6000306@stu.hosei.ac.jp> Cc: jikos@kernel.org, Benjamin Tissoires , linux-input , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org From: Akihiko Odaki Message-ID: <5673CE04.90705@stu.hosei.ac.jp> Date: Fri, 18 Dec 2015 18:12:36 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <5673A785.6000306@stu.hosei.ac.jp> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The "Charm" keys seem to issue short-cut key combinations. I also found Microsoft's document by searching for the combinations. https://msdn.microsoft.com/en-us/library/windows/hardware/dn614461(v=vs.85).aspx So the behavior of hid-multitouch is completely fine. On 12/18/2015 03:28 PM, Akihiko Odaki wrote: >> The search, share, connect(?), and settings keys > I tested the patch again with xev and found that those "charm" > keys don't respond both on hid-microsoft and hid-multitouch, while > other keys respond. I'll have a further look. > > Anyway, keys working with hid-microsoft also work with > hid-multitouch, so It's ready for merging, I think. > > On 12/15/2015 01:39 AM, Donavan Lance wrote: >> On Mon, Dec 14, 2015 at 8:22 AM, Bastien Nocera >> > wrote: >>> On Mon, 2015-12-14 at 21:50 +0900, Akihiko Odaki wrote: >>>> Use multitouch driver instead of microsoft one for Microsoft >>>> Surface Type Covers. >>>> >>>> By using MT_CLS_EXPORT_ALL_INPUTS, the keyboards function as >>>> well as the multitouch pads do. >>> >>> I've discussed this a couple of weeks back with Benjamin >>> Tissoires, and this patch would break the special keys (mute, >>> brightness up/down, keyboard backlight up/down and >>> play/pause). >>> >>> The recommended way to fix this was to move multi-touch >>> processing into the Microsoft driver, so that it would handle >>> the trackpad's multi- touch events. >>> >>> You should be able to do this by carefully picking up the >>> handling code from hid-multitouch, or do something similar to >>> what's done in hid- wacom, which has the same problem as the >>> Type Cover handling. >>> >>> Can you confirm that this does indeed break those special >>> keys? If it does, it's a NAK from my side. >> >> For what it's worth the special keys on my keyboard work fine >> when using this patch. I'm using a Surface Pro 3, Type Cover 3, >> running GNOME and Fedora 23. The search, share, connect(?), and >> settings keys are the only ones not mapped to anything out of the >> box, but they are recognized by xev. >>