From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752342AbbLRLdB (ORCPT ); Fri, 18 Dec 2015 06:33:01 -0500 Received: from mail-lb0-f169.google.com ([209.85.217.169]:36810 "EHLO mail-lb0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751788AbbLRLc6 (ORCPT ); Fri, 18 Dec 2015 06:32:58 -0500 Subject: Re: [PATCH v3 1/4] ARM: dts: dra7: Add dt node for the sycon pcie To: Kishon Vijay Abraham I , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, tony@atomide.com References: <1450172346-11890-1-git-send-email-kishon@ti.com> <1450172346-11890-2-git-send-email-kishon@ti.com> <5670140C.7010906@cogentembedded.com> <5673DE42.9080407@ti.com> Cc: bcousson@baylibre.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, rogerq@ti.com, nsekhar@ti.com, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-usb@vger.kernel.org, t-kristo@ti.com From: Sergei Shtylyov Message-ID: <5673EEE6.7080706@cogentembedded.com> Date: Fri, 18 Dec 2015 14:32:54 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <5673DE42.9080407@ti.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 12/18/2015 1:21 PM, Kishon Vijay Abraham I wrote: >>> Add new device tree node for the control module register space where >>> PCIe registers are present. >>> >>> Signed-off-by: Kishon Vijay Abraham I >>> --- >>> arch/arm/boot/dts/dra7.dtsi | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi >>> index fe99231..e38f63f 100644 >>> --- a/arch/arm/boot/dts/dra7.dtsi >>> +++ b/arch/arm/boot/dts/dra7.dtsi >>> @@ -155,6 +155,11 @@ >>> compatible = "syscon"; >>> reg = <0x1c04 0x0020>; >>> }; >>> + >>> + scm_conf_pcie: tisyscon@1c24 { >> >> Please use the generic node names as the ePAPR standard says. > > something like scm_conf_pcie: syscon@1c24?? Yes, though "system-controller" would be probably more in line with what ePAPR has standardized. > Thanks > Kishon MBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH v3 1/4] ARM: dts: dra7: Add dt node for the sycon pcie Date: Fri, 18 Dec 2015 14:32:54 +0300 Message-ID: <5673EEE6.7080706@cogentembedded.com> References: <1450172346-11890-1-git-send-email-kishon@ti.com> <1450172346-11890-2-git-send-email-kishon@ti.com> <5670140C.7010906@cogentembedded.com> <5673DE42.9080407@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5673DE42.9080407-l0cyMroinI0@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Kishon Vijay Abraham I , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org Cc: bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, rogerq-l0cyMroinI0@public.gmane.org, nsekhar-l0cyMroinI0@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, t-kristo-l0cyMroinI0@public.gmane.org List-Id: devicetree@vger.kernel.org Hello. On 12/18/2015 1:21 PM, Kishon Vijay Abraham I wrote: >>> Add new device tree node for the control module register space where >>> PCIe registers are present. >>> >>> Signed-off-by: Kishon Vijay Abraham I >>> --- >>> arch/arm/boot/dts/dra7.dtsi | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi >>> index fe99231..e38f63f 100644 >>> --- a/arch/arm/boot/dts/dra7.dtsi >>> +++ b/arch/arm/boot/dts/dra7.dtsi >>> @@ -155,6 +155,11 @@ >>> compatible = "syscon"; >>> reg = <0x1c04 0x0020>; >>> }; >>> + >>> + scm_conf_pcie: tisyscon@1c24 { >> >> Please use the generic node names as the ePAPR standard says. > > something like scm_conf_pcie: syscon@1c24?? Yes, though "system-controller" would be probably more in line with what ePAPR has standardized. > Thanks > Kishon MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov) Date: Fri, 18 Dec 2015 14:32:54 +0300 Subject: [PATCH v3 1/4] ARM: dts: dra7: Add dt node for the sycon pcie In-Reply-To: <5673DE42.9080407@ti.com> References: <1450172346-11890-1-git-send-email-kishon@ti.com> <1450172346-11890-2-git-send-email-kishon@ti.com> <5670140C.7010906@cogentembedded.com> <5673DE42.9080407@ti.com> Message-ID: <5673EEE6.7080706@cogentembedded.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello. On 12/18/2015 1:21 PM, Kishon Vijay Abraham I wrote: >>> Add new device tree node for the control module register space where >>> PCIe registers are present. >>> >>> Signed-off-by: Kishon Vijay Abraham I >>> --- >>> arch/arm/boot/dts/dra7.dtsi | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi >>> index fe99231..e38f63f 100644 >>> --- a/arch/arm/boot/dts/dra7.dtsi >>> +++ b/arch/arm/boot/dts/dra7.dtsi >>> @@ -155,6 +155,11 @@ >>> compatible = "syscon"; >>> reg = <0x1c04 0x0020>; >>> }; >>> + >>> + scm_conf_pcie: tisyscon at 1c24 { >> >> Please use the generic node names as the ePAPR standard says. > > something like scm_conf_pcie: syscon at 1c24?? Yes, though "system-controller" would be probably more in line with what ePAPR has standardized. > Thanks > Kishon MBR, Sergei