All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Vijendar Mukunda <Vijendar.Mukunda@amd.com>,
	broonie@kernel.org, alsa-devel@alsa-project.org
Cc: Alexander.Deucher@amd.com, Sunil-kumar.Dommati@amd.com,
	krisman@collabora.com
Subject: Re: [PATCH RESEND V2 00/12] Add Vangogh ACP ASoC driver
Date: Fri, 16 Jul 2021 14:52:19 -0500	[thread overview]
Message-ID: <5673f620-fec1-d2a3-0b78-a1cfdda04acd@linux.intel.com> (raw)
In-Reply-To: <20210717040059.310410-1-Vijendar.Mukunda@amd.com>



On 7/16/21 11:00 PM, Vijendar Mukunda wrote:
> This adds an ASoC driver for the ACP (Audio CoProcessor)
> block on AMD Vangogh APU.
> 
> Vijendar Mukunda (12):
>   ASoC: amd: add Vangogh ACP5x IP register header
>   ASoC: amd: add Vangogh ACP PCI driver
>   ASoc: amd: add acp5x init/de-init functions
>   ASoC: amd: create acp5x platform devices
>   ASoC: amd: add ACP5x PCM platform driver
>   ASoC: amd: irq handler changes for ACP5x PCM dma driver
>   ASoC: amd: add ACP5x pcm dma driver ops
>   ASoC: amd: add vangogh i2s controller driver
>   ASoC: amd: add vangogh i2s dai driver ops
>   ASoC: amd: add vangogh pci driver pm ops
>   ASoC: amd: add vangogh i2s dma driver pm ops
>   ASoC: amd: enable vangogh acp5x driver build
> ---
> v1 -> v2: fixed review comments

usually the version number is at the patchset level, here you included v1, v2 and v3 patches and all but the last one use the RESEND prefix?

is this intentional?

> ---
>  sound/soc/amd/Kconfig                       |   9 +
>  sound/soc/amd/Makefile                      |   1 +
>  sound/soc/amd/vangogh/Makefile              |   9 +
>  sound/soc/amd/vangogh/acp5x-i2s.c           | 429 ++++++++++++++++
>  sound/soc/amd/vangogh/acp5x-pcm-dma.c       | 525 ++++++++++++++++++++
>  sound/soc/amd/vangogh/acp5x.h               | 192 +++++++
>  sound/soc/amd/vangogh/pci-acp5x.c           | 327 ++++++++++++
>  sound/soc/amd/vangogh/vg_chip_offset_byte.h | 337 +++++++++++++
>  8 files changed, 1829 insertions(+)
>  create mode 100644 sound/soc/amd/vangogh/Makefile
>  create mode 100644 sound/soc/amd/vangogh/acp5x-i2s.c
>  create mode 100644 sound/soc/amd/vangogh/acp5x-pcm-dma.c
>  create mode 100644 sound/soc/amd/vangogh/acp5x.h
>  create mode 100644 sound/soc/amd/vangogh/pci-acp5x.c
>  create mode 100644 sound/soc/amd/vangogh/vg_chip_offset_byte.h
> 

  reply	other threads:[~2021-07-16 19:53 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-17  4:00 [PATCH RESEND V2 00/12] Add Vangogh ACP ASoC driver Vijendar Mukunda
2021-07-16 19:52 ` Pierre-Louis Bossart [this message]
2021-07-17  4:34   ` Mukunda,Vijendar
2021-07-19 11:56     ` Mark Brown
2021-07-19 15:10       ` Mukunda,Vijendar
2021-07-17  4:00 ` [PATCH RESEND 01/12] ASoC: amd: add Vangogh ACP5x IP register header Vijendar Mukunda
2021-07-17  4:00   ` Vijendar Mukunda
2021-07-17  4:00 ` [PATCH RESEND V2 02/12] ASoC: amd: add Vangogh ACP PCI driver Vijendar Mukunda
2021-07-17  4:00   ` Vijendar Mukunda
2021-07-17  4:00 ` [PATCH RESEND V2 03/12] ASoc: amd: add acp5x init/de-init functions Vijendar Mukunda
2021-07-17  4:00   ` Vijendar Mukunda
2021-07-17  4:00 ` [PATCH RESEND 04/12] ASoC: amd: create acp5x platform devices Vijendar Mukunda
2021-07-17  4:00   ` Vijendar Mukunda
2021-07-17  4:00 ` [PATCH RESEND V2 05/12] ASoC: amd: add ACP5x PCM platform driver Vijendar Mukunda
2021-07-17  4:00   ` Vijendar Mukunda
2021-07-17  4:00 ` [PATCH RESEND 06/12] ASoC: amd: irq handler changes for ACP5x PCM dma driver Vijendar Mukunda
2021-07-17  4:00   ` Vijendar Mukunda
2021-07-17  4:00 ` [PATCH RESEND V2 07/12] ASoC: amd: add ACP5x pcm dma driver ops Vijendar Mukunda
2021-07-17  4:00   ` Vijendar Mukunda
2021-07-17  4:00 ` [PATCH RESEND V2 08/12] ASoC: amd: add vangogh i2s controller driver Vijendar Mukunda
2021-07-17  4:00   ` Vijendar Mukunda
2021-07-17  4:00 ` [PATCH RESEND V2 09/12] ASoC: amd: add vangogh i2s dai driver ops Vijendar Mukunda
2021-07-17  4:00   ` Vijendar Mukunda
2021-07-17  4:00 ` [PATCH RESEND V2 10/12] ASoC: amd: add vangogh pci driver pm ops Vijendar Mukunda
2021-07-17  4:00   ` Vijendar Mukunda
2021-07-17  4:00 ` [PATCH RESEND V2 11/12] ASoC: amd: add vangogh i2s dma " Vijendar Mukunda
2021-07-17  4:00   ` Vijendar Mukunda
2021-07-17  4:00 ` [PATCH V3 12/12] ASoC: amd: enable vangogh acp5x driver build Vijendar Mukunda
2021-07-17  4:00   ` Vijendar Mukunda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5673f620-fec1-d2a3-0b78-a1cfdda04acd@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=Alexander.Deucher@amd.com \
    --cc=Sunil-kumar.Dommati@amd.com \
    --cc=Vijendar.Mukunda@amd.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=krisman@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.