From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Hurley Subject: Re: [PATCH v2 10/11] tty: serial: 8250: Replace printk by pr_* Date: Fri, 18 Dec 2015 07:10:52 -0800 Message-ID: <567421FC.7080005@hurleysoftware.com> References: <1450437723-2978-1-git-send-email-anton.wuerfel@fau.de> <1450437723-2978-11-git-send-email-anton.wuerfel@fau.de> <1450441926.30729.208.camel@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: Andy Shevchenko , linux-serial@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , "James E.J. Bottomley" , Helge Deller , Heikki Krogerus , Qipeng Zha , Desmond Liu , Wang Long , Matt Redfearn , Paul Burton , Ralf Baechle , Krzysztof Kozlowski , Peter Hung , Soeren Grunewald , Adam Lee , "Maciej S. Szmigiero" , Mans Rullgard , linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org, linux-kernel@i4.cs.fau.de, Phillip Raffeck Return-path: In-Reply-To: <1450441926.30729.208.camel@linux.intel.com> List-ID: List-Id: linux-parisc.vger.kernel.org Hi Anton, On 12/18/2015 04:32 AM, Andy Shevchenko wrote: > On Fri, 2015-12-18 at 12:22 +0100, Anton Wuerfel wrote: >=20 >=20 >> This comes with a slight change in behaviour as >> pr_debug is configurable via CONFIG_DYNAMIC_DEBUG, whereas >> printk(KERN_DEBUG ...) is not. Please make this one change and the changes Andy is suggesting it a separate patch. That way the commit can describe how the get the equivalent behavior (ie., with CONFIG_DYNAMIC_DEBUG) rather than with -DSERIAL_DEBUG_PNP. Regards, Peter Hurley > --- a/drivers/tty/serial/8250/8250_pnp.c >> +++ b/drivers/tty/serial/8250/8250_pnp.c >> @@ -465,9 +465,9 @@ serial_pnp_probe(struct pnp_dev *dev, const >> struct pnp_device_id *dev_id) >> return -ENODEV; >> =20 >> #ifdef SERIAL_DEBUG_PNP >> - printk(KERN_DEBUG >=20 > I think it's not okay. >=20 > The rationale to have printk(KERN_DEBUG =E2=80=A6) here is to allow a > compilation with support of those messages independently on > DYNAMIC_DEBUG. >=20 > If you want to switch to DYNAMIC_DEBUG you have to carefully check wh= at > is done under SERIAL_DEBUG_PNP. >=20 > git grep on current linux-next shows that SERIAL_DEBUG_PNP is an > orphan. >=20 > So, I would suggest to remove #ifdef. >=20 >> - "Setup PNP port: port %x, mem 0x%lx, irq %d, type >> %d\n", >> - uart.port.iobase, uart.port.mapbase, >> uart.port.irq, uart.port.iotype); >> + pr_debug("Setup PNP port: port %x, mem 0x%lx, irq %d, type >> %d\n", >> + uart.port.iobase, uart.port.mapbase, >> + uart.port.irq, uart.port.iotype); >> #endif >> >=20 >=20 -- To unsubscribe from this list: send the line "unsubscribe linux-parisc"= in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753094AbbLRPK7 (ORCPT ); Fri, 18 Dec 2015 10:10:59 -0500 Received: from mail-pa0-f46.google.com ([209.85.220.46]:33379 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752797AbbLRPK5 (ORCPT ); Fri, 18 Dec 2015 10:10:57 -0500 Subject: Re: [PATCH v2 10/11] tty: serial: 8250: Replace printk by pr_* To: Anton Wuerfel References: <1450437723-2978-1-git-send-email-anton.wuerfel@fau.de> <1450437723-2978-11-git-send-email-anton.wuerfel@fau.de> <1450441926.30729.208.camel@linux.intel.com> Cc: Andy Shevchenko , linux-serial@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , "James E.J. Bottomley" , Helge Deller , Heikki Krogerus , Qipeng Zha , Desmond Liu , Wang Long , Matt Redfearn , Paul Burton , Ralf Baechle , Krzysztof Kozlowski , Peter Hung , Soeren Grunewald , Adam Lee , "Maciej S. Szmigiero" , Mans Rullgard , linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org, linux-kernel@i4.cs.fau.de, Phillip Raffeck From: Peter Hurley Message-ID: <567421FC.7080005@hurleysoftware.com> Date: Fri, 18 Dec 2015 07:10:52 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1450441926.30729.208.camel@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Anton, On 12/18/2015 04:32 AM, Andy Shevchenko wrote: > On Fri, 2015-12-18 at 12:22 +0100, Anton Wuerfel wrote: > > >> This comes with a slight change in behaviour as >> pr_debug is configurable via CONFIG_DYNAMIC_DEBUG, whereas >> printk(KERN_DEBUG ...) is not. Please make this one change and the changes Andy is suggesting it a separate patch. That way the commit can describe how the get the equivalent behavior (ie., with CONFIG_DYNAMIC_DEBUG) rather than with -DSERIAL_DEBUG_PNP. Regards, Peter Hurley > --- a/drivers/tty/serial/8250/8250_pnp.c >> +++ b/drivers/tty/serial/8250/8250_pnp.c >> @@ -465,9 +465,9 @@ serial_pnp_probe(struct pnp_dev *dev, const >> struct pnp_device_id *dev_id) >> return -ENODEV; >> >> #ifdef SERIAL_DEBUG_PNP >> - printk(KERN_DEBUG > > I think it's not okay. > > The rationale to have printk(KERN_DEBUG …) here is to allow a > compilation with support of those messages independently on > DYNAMIC_DEBUG. > > If you want to switch to DYNAMIC_DEBUG you have to carefully check what > is done under SERIAL_DEBUG_PNP. > > git grep on current linux-next shows that SERIAL_DEBUG_PNP is an > orphan. > > So, I would suggest to remove #ifdef. > >> - "Setup PNP port: port %x, mem 0x%lx, irq %d, type >> %d\n", >> - uart.port.iobase, uart.port.mapbase, >> uart.port.irq, uart.port.iotype); >> + pr_debug("Setup PNP port: port %x, mem 0x%lx, irq %d, type >> %d\n", >> + uart.port.iobase, uart.port.mapbase, >> + uart.port.irq, uart.port.iotype); >> #endif >> > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Hurley Subject: Re: [PATCH v2 10/11] tty: serial: 8250: Replace printk by pr_* Date: Fri, 18 Dec 2015 07:10:52 -0800 Message-ID: <567421FC.7080005@hurleysoftware.com> References: <1450437723-2978-1-git-send-email-anton.wuerfel@fau.de> <1450437723-2978-11-git-send-email-anton.wuerfel@fau.de> <1450441926.30729.208.camel@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1450441926.30729.208.camel@linux.intel.com> Sender: linux-parisc-owner@vger.kernel.org To: Anton Wuerfel Cc: Andy Shevchenko , linux-serial@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , "James E.J. Bottomley" , Helge Deller , Heikki Krogerus , Qipeng Zha , Desmond Liu , Wang Long , Matt Redfearn , Paul Burton , Ralf Baechle , Krzysztof Kozlowski , Peter Hung , Soeren Grunewald , Adam Lee , "Maciej S. Szmigiero" , Mans Rullgard , linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org, linux-kernel@i4.cs.fau.de, Phillip Raffeck List-Id: linux-serial@vger.kernel.org Hi Anton, On 12/18/2015 04:32 AM, Andy Shevchenko wrote: > On Fri, 2015-12-18 at 12:22 +0100, Anton Wuerfel wrote: >=20 >=20 >> This comes with a slight change in behaviour as >> pr_debug is configurable via CONFIG_DYNAMIC_DEBUG, whereas >> printk(KERN_DEBUG ...) is not. Please make this one change and the changes Andy is suggesting it a separate patch. That way the commit can describe how the get the equivalent behavior (ie., with CONFIG_DYNAMIC_DEBUG) rather than with -DSERIAL_DEBUG_PNP. Regards, Peter Hurley > --- a/drivers/tty/serial/8250/8250_pnp.c >> +++ b/drivers/tty/serial/8250/8250_pnp.c >> @@ -465,9 +465,9 @@ serial_pnp_probe(struct pnp_dev *dev, const >> struct pnp_device_id *dev_id) >> return -ENODEV; >> =20 >> #ifdef SERIAL_DEBUG_PNP >> - printk(KERN_DEBUG >=20 > I think it's not okay. >=20 > The rationale to have printk(KERN_DEBUG =E2=80=A6) here is to allow a > compilation with support of those messages independently on > DYNAMIC_DEBUG. >=20 > If you want to switch to DYNAMIC_DEBUG you have to carefully check wh= at > is done under SERIAL_DEBUG_PNP. >=20 > git grep on current linux-next shows that SERIAL_DEBUG_PNP is an > orphan. >=20 > So, I would suggest to remove #ifdef. >=20 >> - "Setup PNP port: port %x, mem 0x%lx, irq %d, type >> %d\n", >> - uart.port.iobase, uart.port.mapbase, >> uart.port.irq, uart.port.iotype); >> + pr_debug("Setup PNP port: port %x, mem 0x%lx, irq %d, type >> %d\n", >> + uart.port.iobase, uart.port.mapbase, >> + uart.port.irq, uart.port.iotype); >> #endif >> >=20 >=20 -- To unsubscribe from this list: send the line "unsubscribe linux-parisc"= in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html