From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S964820AbbLRSm7 (ORCPT <rfc822;w@1wt.eu>);
	Fri, 18 Dec 2015 13:42:59 -0500
Received: from mga09.intel.com ([134.134.136.24]:48094 "EHLO mga09.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932584AbbLRSm6 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 18 Dec 2015 13:42:58 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,447,1444719600"; 
   d="scan'208";a="710567430"
Subject: Re: Rethinking sigcontext's xfeatures slightly for PKRU's benefit?
To: Andy Lutomirski <luto@amacapital.net>, "H. Peter Anvin" <hpa@zytor.com>
References: <CALCETrVw2V+Ny7=D=_E2m0Qa_v7Bp8GUjhyDXx_bWC35R2ohjg@mail.gmail.com>
 <56736BD1.5080700@linux.intel.com>
 <CALCETrWBjvTiVBPc098cGSH2vdezvdg-i6N4kZjgdcPT7uXoiQ@mail.gmail.com>
 <5673750B.606@linux.intel.com>
 <CALCETrWMofAX8TbZNyPaCWUHqcE85wpehDR05irEPtTYiVMXRA@mail.gmail.com>
 <FEA53E3B-6AE2-4305-82B1-C57451B6E33E@zytor.com>
 <CALCETrU28FoOwR+n8U0Qtt20=ZW6rgc3=M8X4G0QMt1_ZVHY7Q@mail.gmail.com>
Cc: Oleg Nesterov <oleg@redhat.com>, Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@kernel.org>, Borislav Petkov <bp@alien8.de>,
        Brian Gerst <brgerst@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Christoph Hellwig <hch@lst.de>
From: Dave Hansen <dave.hansen@linux.intel.com>
Message-ID: <567453AF.5060808@linux.intel.com>
Date: Fri, 18 Dec 2015 10:42:55 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <CALCETrU28FoOwR+n8U0Qtt20=ZW6rgc3=M8X4G0QMt1_ZVHY7Q@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/18/2015 08:04 AM, Andy Lutomirski wrote:
> 1b. If the app malfunctions such that RSP points to pmem, the kernel
> MUST NOT clobber the pmem space.  I think that this basically mandates
> that PKRU needs to have some safe state (i.e. definitely not the init
> state) on signal delivery: the kernel is going to write a signal frame
> at the address identified by RSP, and that address is in pmem, so
> those writes need to fail.

The kernel is writing the signal frame using normal old copy_to_user().
 Those are writing through mappings with _PAGE_USER set and should be
subject to the PKRU state of the thread before the signal started to be
delivered.

We don't do the fpu__clear() until after this copy, so I think pkeys
enforcement is being done properly for this today.