From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933313AbbLSQVW (ORCPT ); Sat, 19 Dec 2015 11:21:22 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:53450 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932969AbbLSQVU (ORCPT ); Sat, 19 Dec 2015 11:21:20 -0500 Subject: Re: [PATCH V5 1/2] watchdog: Use static struct class watchdog_class in stead of pointer To: Pratyush Anand References: <5672CD1B.40105@roeck-us.net> <20151219042208.GH29413@dhcppc13.redhat.com> Cc: wim@iguana.be, dyoung@redhat.com, dzickus@redhat.com, linux-watchdog@vger.kernel.org, open list From: Guenter Roeck Message-ID: <567583FD.5070303@roeck-us.net> Date: Sat, 19 Dec 2015 08:21:17 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20151219042208.GH29413@dhcppc13.redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/18/2015 08:22 PM, Pratyush Anand wrote: > On 17/12/2015:06:56:27 AM, Guenter Roeck wrote: >> On 12/17/2015 04:23 AM, Pratyush Anand wrote: >>> We need few sysfs attributes to know different status of a watchdog device. >>> To do that, we need to associate .dev_groups with watchdog_class. So >>> convert it from pointer to static. >>> Putting this static struct in watchdog_dev.c, so that static device >>> attributes defined in that file can be attached to it. >>> >>> Signed-off-by: Pratyush Anand >>> Suggested-by: Guenter Roeck >>> Reviewed-by: Guenter Roeck >> >> As things evolve, I'd by now prefer to move the call to device_create() >> into watchdog_dev.c, but that can wait for a follow-up patch if Wim >> is ok with this series. > > Thanks for your quick review. > > OK. I will wait for Wim's comment and then may be I will send another > version with your comment for patch 1/1 incorporated. > I reworked my patch to call device_create() from watchdog_dev.c on top of your patches and on top of Wim's watchdog-next branch. Hopefully we can get that into v4.5. Guenter