From: Paul Moore <paul@paul-moore.com>
To: "Christian Göttsche" <cgoettsche@seltendoof.de>, selinux@vger.kernel.org
Cc: "Christian Göttsche" <cgzones@googlemail.com>,
"Stephen Rothwell" <sfr@canb.auug.org.au>
Subject: Re: [PATCH] selinux: update numeric format specifiers for ebitmaps
Date: Wed, 27 Mar 2024 16:44:34 -0400 [thread overview]
Message-ID: <5675d29575dca282e538ddd67ab344cf@paul-moore.com> (raw)
In-Reply-To: <20240327192557.505937-1-cgoettsche@seltendoof.de>
On Mar 27, 2024 =?UTF-8?q?Christian=20G=C3=B6ttsche?= <cgoettsche@seltendoof.de> wrote:
>
> Use the correct, according to Documentation/core-api/printk-formats.rst,
> format specifiers for numeric arguments in string formatting.
> The general bit type is u32 thus use %u, EBITMAP_SIZE is a constant
> computed via sizeof() thus use %zu.
>
> Fixes: 0142c56682fb ("selinux: reject invalid ebitmaps")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Closes: https://lore.kernel.org/linux-next/20240327131044.2c629921@canb.auug.org.au/
> Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
> ---
> security/selinux/ss/ebitmap.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
Looks good, thanks. Merged into selinux/dev.
--
paul-moore.com
prev parent reply other threads:[~2024-03-27 20:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 19:25 [PATCH] selinux: update numeric format specifiers for ebitmaps Christian Göttsche
2024-03-27 20:44 ` Paul Moore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5675d29575dca282e538ddd67ab344cf@paul-moore.com \
--to=paul@paul-moore.com \
--cc=cgoettsche@seltendoof.de \
--cc=cgzones@googlemail.com \
--cc=selinux@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.