All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cao jin <caoj.fnst@cn.fujitsu.com>
To: Peter Maydell <peter.maydell@linaro.org>,
	Markus Armbruster <armbru@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	QEMU Trivial <qemu-trivial@nongnu.org>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v2] Use macro instead of plain text
Date: Sun, 20 Dec 2015 18:16:47 +0800	[thread overview]
Message-ID: <5676800F.4020706@cn.fujitsu.com> (raw)
In-Reply-To: <CAFEAcA8VxYbYYWHcevhOVndWnTegAWvKMnmd-HR+-p04ws8bGw@mail.gmail.com>

Hi Peter,

Thanks for the explanation, it make me aware that why there are lots of 
"plain_text_for_device":)

forget it please.

On 12/18/2015 09:01 PM, Peter Maydell wrote:
> On 18 December 2015 at 12:52, Markus Armbruster <armbru@redhat.com> wrote:
>> Cao jin <caoj.fnst@cn.fujitsu.com> writes:
>>
>>> There is TYPE_ICH9_AHCI definition in ahci.h when QOMify it, seems it
>>> is missed.
>
>> I suspect there are more instances of the same problem.
>
>> Not sure how interested we are in consistent use of these macros...
>
> In a lot of cases we'd need to find somewhere appropriate to put the
> TYPE_* macro which might well mean creating a new header file just
> for the purpose. That seems like overkill...
>
> thanks
> -- PMM
>
>
>

-- 
Yours Sincerely,

Cao Jin

  reply	other threads:[~2015-12-20 10:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-18  8:52 [Qemu-devel] [PATCH v2] Use macro instead of plain text Cao jin
2015-12-18 12:52 ` Markus Armbruster
2015-12-18 13:01   ` Peter Maydell
2015-12-20 10:16     ` Cao jin [this message]
2015-12-20 10:09   ` Cao jin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5676800F.4020706@cn.fujitsu.com \
    --to=caoj.fnst@cn.fujitsu.com \
    --cc=armbru@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.