From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52070)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <caoj.fnst@cn.fujitsu.com>) id 1aAb0q-00076n-9F
	for qemu-devel@nongnu.org; Sun, 20 Dec 2015 05:14:49 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <caoj.fnst@cn.fujitsu.com>) id 1aAb0m-0007f3-8r
	for qemu-devel@nongnu.org; Sun, 20 Dec 2015 05:14:48 -0500
References: <1450428770-18215-1-git-send-email-caoj.fnst@cn.fujitsu.com>
	<87wpsbex5u.fsf@blackfin.pond.sub.org>
	<CAFEAcA8VxYbYYWHcevhOVndWnTegAWvKMnmd-HR+-p04ws8bGw@mail.gmail.com>
From: Cao jin <caoj.fnst@cn.fujitsu.com>
Message-ID: <5676800F.4020706@cn.fujitsu.com>
Date: Sun, 20 Dec 2015 18:16:47 +0800
MIME-Version: 1.0
In-Reply-To: <CAFEAcA8VxYbYYWHcevhOVndWnTegAWvKMnmd-HR+-p04ws8bGw@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] Use macro instead of plain text
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, Markus Armbruster <armbru@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, QEMU Trivial <qemu-trivial@nongnu.org>, QEMU Developers <qemu-devel@nongnu.org>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <rth@twiddle.net>

Hi Peter,

Thanks for the explanation, it make me aware that why there are lots of 
"plain_text_for_device":)

forget it please.

On 12/18/2015 09:01 PM, Peter Maydell wrote:
> On 18 December 2015 at 12:52, Markus Armbruster <armbru@redhat.com> wrote:
>> Cao jin <caoj.fnst@cn.fujitsu.com> writes:
>>
>>> There is TYPE_ICH9_AHCI definition in ahci.h when QOMify it, seems it
>>> is missed.
>
>> I suspect there are more instances of the same problem.
>
>> Not sure how interested we are in consistent use of these macros...
>
> In a lot of cases we'd need to find somewhere appropriate to put the
> TYPE_* macro which might well mean creating a new header file just
> for the purpose. That seems like overkill...
>
> thanks
> -- PMM
>
>
>

-- 
Yours Sincerely,

Cao Jin