From mboxrd@z Thu Jan 1 00:00:00 1970 From: Or Gerlitz Subject: Re: [PATCH 10/10] IB: remove the unused usecnt field from struct ib_mr Date: Sun, 20 Dec 2015 13:28:02 +0200 Message-ID: <567690C2.4010303@mellanox.com> References: <1450446906-10336-1-git-send-email-hch@lst.de> <1450446906-10336-11-git-send-email-hch@lst.de> <567657D1.5010700@mellanox.com> <5676756B.6090208@dev.mellanox.co.il> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5676756B.6090208-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sagi Grimberg , Christoph Hellwig , Doug Ledford , Haggai Eran Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Shani Michaeli List-Id: linux-rdma@vger.kernel.org On 12/20/2015 11:31 AM, Sagi Grimberg wrote: > However, I think that the patch from Shani 6b52a12bc3fc ("IB/uverbs: > Implement memory windows support in uverbs") is wrong. A memory > window allocation should really reference the MR and not the PD (which > is referenced by the MR). Otherwise the MR deregistration is allowed > with windows bound to it. If this is the case then this field is not > useless and we should fix ib_uverbs_alloc_mw()? I tend to agree, lets not remove the field till this is clarified with Haggai and Co > > Haggai, can you shed some light here? It's Shani's and your code. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html