From mboxrd@z Thu Jan  1 00:00:00 1970
From: Don Slutz <don.slutz@gmail.com>
Subject: Re: [PATCH v13 2/8] xen: Add support for VMware cpuid
	leaves
Date: Sun, 20 Dec 2015 12:48:06 -0500
Message-ID: <5676E9D6.6070700@Gmail.com>
References: <1448747105-19966-1-git-send-email-Don.Slutz@Gmail.com>
	<1448747105-19966-3-git-send-email-Don.Slutz@Gmail.com>
	<56714AD102000078000C011A@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <56714AD102000078000C011A@prv-mh.provo.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Jun Nakajima <jun.nakajima@intel.com>, Tim Deegan <tim@xen.org>, Kevin Tian <kevin.tian@intel.com>, Wei Liu <wei.liu2@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, George Dunlap <george.dunlap@eu.citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Don Slutz <dslutz@verizon.com>, xen-devel@lists.xen.org, Eddie Dong <eddie.dong@intel.com>, Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>, Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>, Keir Fraser <keir@xen.org>, Boris Ostrovsky <boris.ostrovsky@oracle.com>
List-Id: xen-devel@lists.xenproject.org

On 12/16/15 05:28, Jan Beulich wrote:
>>>> On 28.11.15 at 22:44, <don.slutz@gmail.com> wrote:
>> --- a/xen/include/public/arch-x86/xen.h
>> +++ b/xen/include/public/arch-x86/xen.h
>> @@ -290,6 +290,7 @@ struct xen_arch_domainconfig {
>>                                       XEN_X86_EMU_VGA | XEN_X86_EMU_IOMMU |   \
>>                                       XEN_X86_EMU_PIT)
>>      uint32_t emulation_flags;
>> +    uint64_t vmware_hwver;
> 
> It's been a while since the last iteration, so could you please remind
> me again why this needs to be a 64-bit quantity?

Looking at it, it only needs to be a 32-bit quantity.  My memory says
that it was 64-bits because that was the size of a HVM_PARAM_... which
was were it was passed before this code existed.

I see no reason not to change to 32-bit, and so will do so.

   -Don Slutz

> 
> Jan
>