From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751348AbbLUHbt (ORCPT ); Mon, 21 Dec 2015 02:31:49 -0500 Received: from regular1.263xmail.com ([211.150.99.134]:57335 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751142AbbLUHbZ (ORCPT ); Mon, 21 Dec 2015 02:31:25 -0500 X-Greylist: delayed 303 seconds by postgrey-1.27 at vger.kernel.org; Mon, 21 Dec 2015 02:31:24 EST X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <5677AAC4.1010405@rock-chips.com> Date: Mon, 21 Dec 2015 15:31:16 +0800 From: Mark yao User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Yakir Yang , Heiko Stuebner CC: David Airlie , Thierry Reding , Rob Herring , Ken Mixte , Ben Chan , Zheng Yang , Kumar Gala , Ian Campbell , Pawel Moll , Mark Rutland , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [RFC PATCH v1 1/2] drm: rockchip/hdmi: add Innosilicon HDMI support References: <1447227952-4787-1-git-send-email-ykk@rock-chips.com> <1447227999-4842-1-git-send-email-ykk@rock-chips.com> In-Reply-To: <1447227999-4842-1-git-send-email-ykk@rock-chips.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015年11月11日 15:46, Yakir Yang wrote: > + hdmi->connector.polled = DRM_CONNECTOR_POLL_HPD; > + > + drm_connector_helper_add(&hdmi->connector, > + &inno_hdmi_connector_helper_funcs); > + drm_connector_init(drm, &hdmi->connector, &inno_hdmi_connector_funcs, > + DRM_MODE_CONNECTOR_HDMIA); > + > + hdmi->connector.encoder = encoder; Pls remove "hdmi->connector.encoder = encoder;" It would cause a error dump on atomic drm runtime: WARNING: CPU: 3 PID: 74 at drivers/gpu/drm/drm_atomic_helper.c:682 drm_atomic_helper_update_legacy_modeset_state+0x6c/0x200() This issue can be explained from following thread: https://lkml.org/lkml/2015/11/16/498 Thanks. -- Ｍark Yao From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark yao Subject: Re: [RFC PATCH v1 1/2] drm: rockchip/hdmi: add Innosilicon HDMI support Date: Mon, 21 Dec 2015 15:31:16 +0800 Message-ID: <5677AAC4.1010405@rock-chips.com> References: <1447227952-4787-1-git-send-email-ykk@rock-chips.com> <1447227999-4842-1-git-send-email-ykk@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1447227999-4842-1-git-send-email-ykk@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Yakir Yang , Heiko Stuebner Cc: Mark Rutland , devicetree@vger.kernel.org, Pawel Moll , Ian Campbell , Ben Chan , Ken Mixte , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Rob Herring , Kumar Gala , Thierry Reding , linux-arm-kernel@lists.infradead.org, Zheng Yang List-Id: devicetree@vger.kernel.org T24gMjAxNeW5tDEx5pyIMTHml6UgMTU6NDYsIFlha2lyIFlhbmcgd3JvdGU6Cj4gKwloZG1pLT5j b25uZWN0b3IucG9sbGVkID0gRFJNX0NPTk5FQ1RPUl9QT0xMX0hQRDsKPiArCj4gKwlkcm1fY29u bmVjdG9yX2hlbHBlcl9hZGQoJmhkbWktPmNvbm5lY3RvciwKPiArCQkJCSAmaW5ub19oZG1pX2Nv bm5lY3Rvcl9oZWxwZXJfZnVuY3MpOwo+ICsJZHJtX2Nvbm5lY3Rvcl9pbml0KGRybSwgJmhkbWkt PmNvbm5lY3RvciwgJmlubm9faGRtaV9jb25uZWN0b3JfZnVuY3MsCj4gKwkJCSAgIERSTV9NT0RF X0NPTk5FQ1RPUl9IRE1JQSk7Cj4gKwo+ICsJaGRtaS0+Y29ubmVjdG9yLmVuY29kZXIgPSBlbmNv ZGVyOwoKUGxzIHJlbW92ZSAiaGRtaS0+Y29ubmVjdG9yLmVuY29kZXIgPSBlbmNvZGVyOyIKCkl0 IHdvdWxkIGNhdXNlIGEgZXJyb3IgZHVtcCBvbiBhdG9taWMgZHJtIHJ1bnRpbWU6CgpXQVJOSU5H OiBDUFU6IDMgUElEOiA3NCBhdCBkcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYzo2 ODIgCmRybV9hdG9taWNfaGVscGVyX3VwZGF0ZV9sZWdhY3lfbW9kZXNldF9zdGF0ZSsweDZjLzB4 MjAwKCkKClRoaXMgaXNzdWUgY2FuIGJlIGV4cGxhaW5lZCBmcm9tIGZvbGxvd2luZyB0aHJlYWQ6 Cmh0dHBzOi8vbGttbC5vcmcvbGttbC8yMDE1LzExLzE2LzQ5OAoKVGhhbmtzLgoKLS0gCu+8rWFy ayBZYW8KCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpk cmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.yao@rock-chips.com (Mark yao) Date: Mon, 21 Dec 2015 15:31:16 +0800 Subject: [RFC PATCH v1 1/2] drm: rockchip/hdmi: add Innosilicon HDMI support In-Reply-To: <1447227999-4842-1-git-send-email-ykk@rock-chips.com> References: <1447227952-4787-1-git-send-email-ykk@rock-chips.com> <1447227999-4842-1-git-send-email-ykk@rock-chips.com> Message-ID: <5677AAC4.1010405@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2015?11?11? 15:46, Yakir Yang wrote: > + hdmi->connector.polled = DRM_CONNECTOR_POLL_HPD; > + > + drm_connector_helper_add(&hdmi->connector, > + &inno_hdmi_connector_helper_funcs); > + drm_connector_init(drm, &hdmi->connector, &inno_hdmi_connector_funcs, > + DRM_MODE_CONNECTOR_HDMIA); > + > + hdmi->connector.encoder = encoder; Pls remove "hdmi->connector.encoder = encoder;" It would cause a error dump on atomic drm runtime: WARNING: CPU: 3 PID: 74 at drivers/gpu/drm/drm_atomic_helper.c:682 drm_atomic_helper_update_legacy_modeset_state+0x6c/0x200() This issue can be explained from following thread: https://lkml.org/lkml/2015/11/16/498 Thanks. -- ?ark Yao