From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Nowicki Subject: Re: [PATCH V2 21/23] pci, acpi: Support for ACPI based PCI hostbridge init Date: Mon, 21 Dec 2015 11:21:02 +0100 Message-ID: <5677D28E.6010803@semihalf.com> References: <1450278993-12664-1-git-send-email-tn@semihalf.com> <1450278993-12664-22-git-send-email-tn@semihalf.com> <2277339.U6fWlSIDzy@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wm0-f49.google.com ([74.125.82.49]:33909 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751376AbbLUKW5 (ORCPT ); Mon, 21 Dec 2015 05:22:57 -0500 Received: by mail-wm0-f49.google.com with SMTP id l126so62125190wml.1 for ; Mon, 21 Dec 2015 02:22:56 -0800 (PST) In-Reply-To: <2277339.U6fWlSIDzy@wuerfel> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Arnd Bergmann , linux-arm-kernel@lists.infradead.org Cc: bhelgaas@google.com, will.deacon@arm.com, catalin.marinas@arm.com, rjw@rjwysocki.net, hanjun.guo@linaro.org, Lorenzo.Pieralisi@arm.com, okaya@codeaurora.org, jiang.liu@linux.intel.com, Stefano.Stabellini@eu.citrix.com, jchandra@broadcom.com, jcm@redhat.com, linaro-acpi@lists.linaro.org, linux-pci@vger.kernel.org, Liviu.Dudau@arm.com, ddaney@caviumnetworks.com, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, robert.richter@caviumnetworks.com, Suravee.Suthikulpanit@amd.com, msalter@redhat.com, wangyijing@huawei.com, tglx@linutronix.de, mw@semihalf.com On 18.12.2015 13:40, Arnd Bergmann wrote: > On Wednesday 16 December 2015 16:16:31 Tomasz Nowicki wrote: >> Because of two patch series: >> 1. Jiang Liu's common interface to support PCI host bridge init >> 2. MMCONFIG refactoring (part of this patch set) >> now we can think about generic ACPI based PCI host bridge driver >> out of arch/ directory. >> >> This driver use information from MCFG table (PCI config space regions) >> and _CRS method (IO/irq resources) to initialize PCI hostbridge. >> >> TBD: We are still not sure whether we should reassign resources >> after PCI bus enumeration or trust firmware to do all that work for >> us properly. >> >> Signed-off-by: Tomasz Nowicki >> Signed-off-by: Hanjun Guo >> Signed-off-by: Suravee Suthikulpanit >> CC: Arnd Bergmann >> CC: Catalin Marinas >> CC: Liviu Dudau >> CC: Lorenzo Pieralisi >> CC: Will Deacon >> Tested-by: Suravee Suthikulpanit >> > > I think this code could better live in drivers/acpi/pci_root.c > along with all the related functions. It's not really a driver > by itself and cannot be a loadable module or built on other > architectures. > > You can put all the code inside an #ifdef ARCH_PCI_HOST_GENERIC_ACPI > there. > Makes sense to me, thanks. Tomasz From mboxrd@z Thu Jan 1 00:00:00 1970 From: tn@semihalf.com (Tomasz Nowicki) Date: Mon, 21 Dec 2015 11:21:02 +0100 Subject: [PATCH V2 21/23] pci, acpi: Support for ACPI based PCI hostbridge init In-Reply-To: <2277339.U6fWlSIDzy@wuerfel> References: <1450278993-12664-1-git-send-email-tn@semihalf.com> <1450278993-12664-22-git-send-email-tn@semihalf.com> <2277339.U6fWlSIDzy@wuerfel> Message-ID: <5677D28E.6010803@semihalf.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 18.12.2015 13:40, Arnd Bergmann wrote: > On Wednesday 16 December 2015 16:16:31 Tomasz Nowicki wrote: >> Because of two patch series: >> 1. Jiang Liu's common interface to support PCI host bridge init >> 2. MMCONFIG refactoring (part of this patch set) >> now we can think about generic ACPI based PCI host bridge driver >> out of arch/ directory. >> >> This driver use information from MCFG table (PCI config space regions) >> and _CRS method (IO/irq resources) to initialize PCI hostbridge. >> >> TBD: We are still not sure whether we should reassign resources >> after PCI bus enumeration or trust firmware to do all that work for >> us properly. >> >> Signed-off-by: Tomasz Nowicki >> Signed-off-by: Hanjun Guo >> Signed-off-by: Suravee Suthikulpanit >> CC: Arnd Bergmann >> CC: Catalin Marinas >> CC: Liviu Dudau >> CC: Lorenzo Pieralisi >> CC: Will Deacon >> Tested-by: Suravee Suthikulpanit >> > > I think this code could better live in drivers/acpi/pci_root.c > along with all the related functions. It's not really a driver > by itself and cannot be a loadable module or built on other > architectures. > > You can put all the code inside an #ifdef ARCH_PCI_HOST_GENERIC_ACPI > there. > Makes sense to me, thanks. Tomasz