From: Cao jin <caoj.fnst@cn.fujitsu.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: rth@twiddle.net, leon.alrae@imgtec.com, ehabkost@redhat.com,
aurelien@aurel32.net, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH 3/5] PXB: convert to realize()
Date: Mon, 21 Dec 2015 18:39:22 +0800 [thread overview]
Message-ID: <5677D6DA.40103@cn.fujitsu.com> (raw)
In-Reply-To: <56769336.9050104@cn.fujitsu.com>
Hi Paolo
On 12/20/2015 07:38 PM, Cao jin wrote:
> Hi
>
> On 12/19/2015 02:01 AM, Paolo Bonzini wrote:
>>
>>
>> On 18/12/2015 12:03, Cao jin wrote:
> [...]
>>> +
>>> +err_register_bus:
>>> + object_unref(OBJECT(ds));
>>> + object_unref(OBJECT(bds));
>>> + object_unref(OBJECT(bus));
>>
>> I think these should be object_unparent, not unref.
>>
>
> But, it seems these 3 objects isn`t added as a child-property via
> object_property_add_child() during creation, so OBJECT(ds)->parent(so
> does the other 2) will be NULL, and so object_unparent will do nothing?
>
> Or am I missing something?
>
I finally find what I missed...Yes you are right...In qom, seems all
devices are attached to container:"peripheral", or "peripheral-anon", or
"unattached" or anything I don`t see until now...Thanks a lot:)
>> Paolo
>>
>>> }
>>>
>>> static void pxb_dev_exitfn(PCIDevice *pci_dev)
>>> @@ -259,7 +263,7 @@ static void pxb_dev_class_init(ObjectClass
>>> *klass, void *data)
>>> DeviceClass *dc = DEVICE_CLASS(klass);
>>> PCIDeviceClass *k = PCI_DEVICE_CLASS(klass);
>>>
>>> - k->init = pxb_dev_initfn;
>>> + k->realize = pxb_dev_realize;
>>> k->exit = pxb_dev_exitfn;
>>> k->vendor_id = PCI_VENDOR_ID_REDHAT;
>>> k->device_id = PCI_DEVICE_ID_REDHAT_PXB;
>>>
>>
>>
>> .
>>
>
--
Yours Sincerely,
Cao Jin
next prev parent reply other threads:[~2015-12-21 10:37 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-18 11:03 [Qemu-devel] [PATCH 0/5] Convert to realize() Cao jin
2015-12-18 11:03 ` [Qemu-devel] [PATCH 1/5] SH PCI Host: convert " Cao jin
2015-12-18 17:59 ` Paolo Bonzini
2016-01-10 18:13 ` Michael Tokarev
2015-12-18 11:03 ` [Qemu-devel] [PATCH 2/5] igd-passthrough-i440FX: " Cao jin
2015-12-18 18:37 ` Eduardo Habkost
2015-12-18 21:18 ` Markus Armbruster
2015-12-20 11:59 ` Cao jin
2016-01-11 14:32 ` Markus Armbruster
2016-01-12 2:24 ` Cao jin
2015-12-20 11:56 ` Cao jin
2015-12-18 11:03 ` [Qemu-devel] [PATCH 3/5] PXB: " Cao jin
2015-12-18 18:01 ` Paolo Bonzini
2015-12-20 11:38 ` Cao jin
2015-12-21 10:39 ` Cao jin [this message]
2015-12-21 15:49 ` Paolo Bonzini
2015-12-22 3:58 ` Cao jin
2015-12-22 7:34 ` Marcel Apfelbaum
2015-12-22 9:16 ` Cao jin
2015-12-22 9:35 ` Marcel Apfelbaum
2015-12-22 9:52 ` Cao jin
2015-12-22 11:40 ` Cao jin
2015-12-20 10:22 ` Marcel Apfelbaum
2015-12-20 10:48 ` Cao jin
2015-12-20 11:21 ` Marcel Apfelbaum
2015-12-21 2:59 ` Cao jin
2015-12-21 10:08 ` Marcel Apfelbaum
2015-12-21 10:19 ` Cao jin
2015-12-18 11:03 ` [Qemu-devel] [PATCH 4/5] gt64120: " Cao jin
2015-12-18 17:59 ` Paolo Bonzini
2016-01-10 18:12 ` Michael Tokarev
2015-12-18 11:03 ` [Qemu-devel] [PATCH 5/5] xen-pvdevice: " Cao jin
2015-12-18 18:00 ` Paolo Bonzini
2015-12-21 5:52 ` Cao jin
2015-12-21 15:00 ` Stefano Stabellini
2015-12-21 15:15 ` Stefano Stabellini
2015-12-22 1:24 ` Cao jin
2015-12-22 2:40 ` Cao jin
2015-12-18 11:08 ` [Qemu-devel] [PATCH 0/5] Convert " Cao jin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5677D6DA.40103@cn.fujitsu.com \
--to=caoj.fnst@cn.fujitsu.com \
--cc=aurelien@aurel32.net \
--cc=ehabkost@redhat.com \
--cc=leon.alrae@imgtec.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.