All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: Huaitong Han <huaitong.han@intel.com>
Cc: kevin.tian@intel.com, wei.liu2@citrix.com,
	ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com,
	george.dunlap@eu.citrix.com, andrew.cooper3@citrix.com,
	ian.jackson@eu.citrix.com, xen-devel@lists.xen.org,
	jun.nakajima@intel.com, keir@xen.org
Subject: Re: [PATCH V4 1/6] x86/hvm: pkeys, add the flag to enable Memory Protection Keys
Date: Mon, 21 Dec 2015 05:58:40 -0700	[thread overview]
Message-ID: <5678059002000078000C1E03@prv-mh.provo.novell.com> (raw)
In-Reply-To: <1450682504-32286-2-git-send-email-huaitong.han@intel.com>

>>> On 21.12.15 at 08:21, <huaitong.han@intel.com> wrote:

First of all - please trim your Cc lists. I don't see, for example, why all
the tools maintainers needed to be Cc-ed on this patch.

> --- a/xen/arch/x86/cpu/common.c
> +++ b/xen/arch/x86/cpu/common.c
> @@ -22,6 +22,10 @@ boolean_param("xsave", use_xsave);
>  bool_t opt_arat = 1;
>  boolean_param("arat", opt_arat);
>  
> +/* pku: Flag to enable Memory Protection Keys (default on). */
> +bool_t opt_pku = 1;

I would have thought that I had commented on this wanting to be
static already, but looks like I'm misremembering.

Jan

  reply	other threads:[~2015-12-21 12:58 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-21  7:21 [PATCH V4 0/6] x86/hvm: pkeys, add memory protection-key support Huaitong Han
2015-12-21  7:21 ` [PATCH V4 1/6] x86/hvm: pkeys, add the flag to enable Memory Protection Keys Huaitong Han
2015-12-21 12:58   ` Jan Beulich [this message]
2015-12-21  7:21 ` [PATCH V4 2/6] x86/hvm: pkeys, add pkeys support when setting CR4 Huaitong Han
2015-12-21 15:00   ` Jan Beulich
2015-12-21  7:21 ` [PATCH V4 3/6] x86/hvm: pkeys, disable pkeys for guests in non-paging mode Huaitong Han
2015-12-21  7:21 ` [PATCH V4 4/6] x86/hvm: pkeys, add pkeys support for guest_walk_tables Huaitong Han
2015-12-21 15:32   ` Jan Beulich
2015-12-22  8:12     ` Han, Huaitong
2015-12-22  8:43       ` Jan Beulich
2015-12-21  7:21 ` [PATCH V4 5/6] x86/hvm: pkeys, add xstate support for pkeys Huaitong Han
2015-12-21 15:09   ` Jan Beulich
2015-12-21  7:21 ` [PATCH V4 6/6] x86/hvm: pkeys, add pkeys support for cpuid handling Huaitong Han
2015-12-21 15:07   ` Jan Beulich
2015-12-22  2:54     ` Han, Huaitong
2015-12-22  8:30       ` Jan Beulich
2015-12-22  9:25         ` Han, Huaitong
2015-12-22  9:51           ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5678059002000078000C1E03@prv-mh.provo.novell.com \
    --to=jbeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=george.dunlap@eu.citrix.com \
    --cc=huaitong.han@intel.com \
    --cc=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jun.nakajima@intel.com \
    --cc=keir@xen.org \
    --cc=kevin.tian@intel.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.