Hi Geliang, > static int batadv_socket_release(struct inode *inode, struct file *file) > { > - struct batadv_socket_client *socket_client = file->private_data; > - struct batadv_socket_packet *socket_packet; > - struct list_head *list_pos, *list_pos_tmp; > + struct batadv_socket_client *client = file->private_data; > + struct batadv_socket_packet *packet, *tmp; > [...] > + list_for_each_entry_safe(packet, tmp, &client->queue_list, list) { I guess you renamed those variables to make sure that the statement above would fit in 80 chars.. in that case the patch looks good. Acked-by: Antonio Quartulli -- Antonio Quartulli