From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41807) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aB3OD-0002FM-MU for qemu-devel@nongnu.org; Mon, 21 Dec 2015 11:32:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aB3O9-00066f-1m for qemu-devel@nongnu.org; Mon, 21 Dec 2015 11:32:49 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34127) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aB3O8-00066W-TD for qemu-devel@nongnu.org; Mon, 21 Dec 2015 11:32:44 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id B225FC0B7E1B for ; Mon, 21 Dec 2015 16:32:43 +0000 (UTC) References: <1450714014-16849-1-git-send-email-berrange@redhat.com> <1450714014-16849-6-git-send-email-berrange@redhat.com> From: Eric Blake Message-ID: <567829AA.1000508@redhat.com> Date: Mon, 21 Dec 2015 09:32:42 -0700 MIME-Version: 1.0 In-Reply-To: <1450714014-16849-6-git-send-email-berrange@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UWtpPPQ4gJXq61vbIVaCMjC9dHEGdaC8e" Subject: Re: [Qemu-devel] [PATCH 5/6] crypto: ensure qapi/crypto.json is listed in qapi-modules List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: Markus Armbruster This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --UWtpPPQ4gJXq61vbIVaCMjC9dHEGdaC8e Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/21/2015 09:06 AM, Daniel P. Berrange wrote: > The rebuild of qapi-types.c/h is not correctly triggered > when qapi/crypto.json is changed because it was missing > from the list of files in the qapi-modules variable. >=20 > Signed-off-by: Daniel P. Berrange > --- > Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Eric Blake >=20 > diff --git a/Makefile b/Makefile > index af3e5f1..82b2fc8 100644 > --- a/Makefile > +++ b/Makefile > @@ -271,7 +271,8 @@ $(SRC_PATH)/qga/qapi-schema.json $(SRC_PATH)/script= s/qapi-commands.py $(qapi-py) > =20 > qapi-modules =3D $(SRC_PATH)/qapi-schema.json $(SRC_PATH)/qapi/common.= json \ > $(SRC_PATH)/qapi/block.json $(SRC_PATH)/qapi/block-core= =2Ejson \ > - $(SRC_PATH)/qapi/event.json $(SRC_PATH)/qapi/introspect= =2Ejson > + $(SRC_PATH)/qapi/event.json $(SRC_PATH)/qapi/introspect= =2Ejson \ > + $(SRC_PATH)/qapi/crypto.json Wonder if a wildcard for qapi/*.json would be any smarter. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --UWtpPPQ4gJXq61vbIVaCMjC9dHEGdaC8e Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWeCmqAAoJEKeha0olJ0Nq90UIAJawSpMljNImZiNkuumZRUW8 5BKmULNVMYgZxzIrniTPacA7amn0TZtT5pipyvkv5r39fgt5BkGfE9uFSZof5rbp uayMNHUkTu1DVcQOTmKwvYqUfKhAF35OwK7IElgoDzTQWpX5Ff0dvxX5n7FVTWvO ravJjQ9iX0eMoSR84omYSrv2AQZNR2aQDjvLCi8ktogISr86e0j0LCoFlUkZO9NE qtkvdT0VXFC6cby1x5JluhdCEQ8SpsYbm9FzRaA8eGfhIONUkAX0jHH211XiaPPw h0wi2C+lv8vpG0TYBmtRrSDuqwnD1hnV1gJ8LwuNDQIXIRiXPC4cU+yTTlc1RR4= =LSsY -----END PGP SIGNATURE----- --UWtpPPQ4gJXq61vbIVaCMjC9dHEGdaC8e--