From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41844) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aB3OZ-0002Y3-BV for qemu-devel@nongnu.org; Mon, 21 Dec 2015 11:33:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aB3OT-00068h-Gs for qemu-devel@nongnu.org; Mon, 21 Dec 2015 11:33:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56230) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aB3OT-00068b-CL for qemu-devel@nongnu.org; Mon, 21 Dec 2015 11:33:05 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id F29F340C3B for ; Mon, 21 Dec 2015 16:33:04 +0000 (UTC) References: <1450714014-16849-1-git-send-email-berrange@redhat.com> <1450714014-16849-7-git-send-email-berrange@redhat.com> From: Eric Blake Message-ID: <567829C0.5030502@redhat.com> Date: Mon, 21 Dec 2015 09:33:04 -0700 MIME-Version: 1.0 In-Reply-To: <1450714014-16849-7-git-send-email-berrange@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="EWwofEHcKgnLTbXXsbltoPsb9Qi9nReeJ" Subject: Re: [Qemu-devel] [PATCH 6/6] crypto: fix transposed arguments in cipher error message List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: Markus Armbruster This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --EWwofEHcKgnLTbXXsbltoPsb9Qi9nReeJ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/21/2015 09:06 AM, Daniel P. Berrange wrote: > When reporting an incorrect key length for a cipher, we > mixed up the actual vs expected arguments. >=20 > Signed-off-by: Daniel P. Berrange > --- > crypto/cipher.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake >=20 > diff --git a/crypto/cipher.c b/crypto/cipher.c > index e92d49a..a69ff5e 100644 > --- a/crypto/cipher.c > +++ b/crypto/cipher.c > @@ -89,7 +89,7 @@ qcrypto_cipher_validate_key_length(QCryptoCipherAlgor= ithm alg, > =20 > if (alg_key_len[alg] !=3D nkey) { > error_setg(errp, "Cipher key length %zu should be %zu", > - alg_key_len[alg], nkey); > + nkey, alg_key_len[alg]); > return false; > } > return true; >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --EWwofEHcKgnLTbXXsbltoPsb9Qi9nReeJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWeCnAAAoJEKeha0olJ0NqfHsIAI0Pi1osRVha/+qt6Hkg8cBv bluXfl9aO3lolE6Bh65rwp5UrBGG3IO8G3Ia2ZSk0gU7AiC/SL+db/f1BnuQ0Ml/ tOYjrCy6nV4YA2Q4txET46Zm8kd+qu2/Q3OUGSprUFUvErV1b/VJLITG9mQ/A64U qOnX+B5IhyLVX6GXMzkFryPD32KBYklnbUdIRt2LcU7Pbjy+E9Rni3/vk8EZCKeI N/llEfb2IVjHtqqmjWoIanNLj/VzmvpHKTzIKakgqcax5wP85qjywdJ2kO629r9v v89VecDrW5w5Ez6D+O54Iik0JvzXyGts6A6MQZIn89P4DNXZENIhvcK+Lhti8RA= =KyUq -----END PGP SIGNATURE----- --EWwofEHcKgnLTbXXsbltoPsb9Qi9nReeJ--