* [PATCH] matchbox-terminal: Update commitID
@ 2018-06-09 11:59 Devarsh Thakkar
2018-06-10 8:29 ` Richard Purdie
0 siblings, 1 reply; 8+ messages in thread
From: Devarsh Thakkar @ 2018-06-09 11:59 UTC (permalink / raw)
To: openembedded-core; +Cc: JAEWON, varunkum, maulikd, Devarsh Thakkar
Pull in change which adds support for command line
options (-e and --command) which can be used for
launching programs or running commands in matchbox-terminal
via command line.
Signed-off-by: Devarsh Thakkar <devarsht@xilinx.com>
---
meta/recipes-sato/matchbox-terminal/matchbox-terminal_0.1.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-sato/matchbox-terminal/matchbox-terminal_0.1.bb b/meta/recipes-sato/matchbox-terminal/matchbox-terminal_0.1.bb
index 4488191..b7fbee7 100644
--- a/meta/recipes-sato/matchbox-terminal/matchbox-terminal_0.1.bb
+++ b/meta/recipes-sato/matchbox-terminal/matchbox-terminal_0.1.bb
@@ -10,7 +10,7 @@ DEPENDS = "gtk+3 vte"
SECTION = "x11/utils"
#SRCREV tagged 0.1
-SRCREV = "3ad357db2302760b8a8817b5f4478dd87479442f"
+SRCREV = "ccbc3c70946b04313c6166ab0dfef21e5e83c289"
SRC_URI = "git://git.yoctoproject.org/${BPN}"
UPSTREAM_CHECK_GITTAGREGEX = "(?P<pver>(\d+(\.\d+)+))"
--
2.1.1
This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] matchbox-terminal: Update commitID
2018-06-09 11:59 [PATCH] matchbox-terminal: Update commitID Devarsh Thakkar
@ 2018-06-10 8:29 ` Richard Purdie
0 siblings, 0 replies; 8+ messages in thread
From: Richard Purdie @ 2018-06-10 8:29 UTC (permalink / raw)
To: Devarsh Thakkar, openembedded-core
Cc: maulikd, varunkum, JAEWON, Devarsh Thakkar
On Sat, 2018-06-09 at 04:59 -0700, Devarsh Thakkar wrote:
> Pull in change which adds support for command line
> options (-e and --command) which can be used for
> launching programs or running commands in matchbox-terminal
> via command line.
>
> Signed-off-by: Devarsh Thakkar <devarsht@xilinx.com>
> ---
> meta/recipes-sato/matchbox-terminal/matchbox-terminal_0.1.bb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-sato/matchbox-terminal/matchbox-
> terminal_0.1.bb b/meta/recipes-sato/matchbox-terminal/matchbox-
> terminal_0.1.bb
> index 4488191..b7fbee7 100644
> --- a/meta/recipes-sato/matchbox-terminal/matchbox-terminal_0.1.bb
> +++ b/meta/recipes-sato/matchbox-terminal/matchbox-terminal_0.1.bb
> @@ -10,7 +10,7 @@ DEPENDS = "gtk+3 vte"
> SECTION = "x11/utils"
>
> #SRCREV tagged 0.1
I'm guessing the above comment is no longer valid, nor is the value of
PV?
> -SRCREV = "3ad357db2302760b8a8817b5f4478dd87479442f"
> +SRCREV = "ccbc3c70946b04313c6166ab0dfef21e5e83c289"
> SRC_URI = "git://git.yoctoproject.org/${BPN}"
> UPSTREAM_CHECK_GITTAGREGEX = "(?P<pver>(\d+(\.\d+)+))"
>
Cheers,
Richard
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] matchbox-terminal: Update commitID
2018-06-14 7:40 Devarsh Thakkar
2018-06-18 5:12 ` Devarsh Thakkar
@ 2018-06-19 15:44 ` Richard Purdie
1 sibling, 0 replies; 8+ messages in thread
From: Richard Purdie @ 2018-06-19 15:44 UTC (permalink / raw)
To: Devarsh Thakkar, openembedded-core, Burton, Ross
On Thu, 2018-06-14 at 07:40 +0000, Devarsh Thakkar wrote:
> Hi Richard, Ross
>
> > Message: 2
> > Date: Mon, 11 Jun 2018 14:39:53 +0100
> > From: Richard Purdie <richard.purdie@linuxfoundation.org>
> > To: Devarsh Thakkar <DEVARSHT@xilinx.com>,
> > "openembedded-core@lists.openembedded.org"
> > <openembedded-core@lists.openembedded.org>
> > Cc: Maulik Desai <maulikd@xilinx.com>, Varunkumar Allagadapa
> > <VARUNKUM@xilinx.com>
> > Subject: Re: [OE-core] [PATCH] matchbox-terminal: Update commitID
> > Message-ID:
> > <642b938d82295e3b7ce922dad711c63904d62ca5.camel@linuxfounda
> > tion.org>
> > Content-Type: text/plain; charset="UTF-8"
> >
> > On Mon, 2018-06-11 at 12:39 +0000, Devarsh Thakkar wrote:
> > > Hi Richard,
> > >
> > > Thanks for the quick review.
> > > Replies inline.
> > >
> > > > Message: 5
> > > > Date: Sun, 10 Jun 2018 09:29:14 +0100
> > > > From: Richard Purdie <richard.purdie@linuxfoundation.org>
> > > > To: Devarsh Thakkar <devarsh.thakkar@xilinx.com>,
> > > > openembedded-core@lists.openembedded.org
> > > > Cc: maulikd@xilinx.com, varunkum@xilinx.com, JAEWON@xilinx.com,
> > > > Devarsh Thakkar <devarsht@xilinx.com>
> > > > Subject: Re: [OE-core] [PATCH] matchbox-terminal: Update
> > > > commitID
> > > > Message-ID:
> > > > <56788cd154d9af0b6c9ea2ef78de23b1909fd7ee.camel@linuxfo
> > > > undati
> > > > on.org>
> > > > Content-Type: text/plain; charset="UTF-8"
> > > >
> > > > On Sat, 2018-06-09 at 04:59 -0700, Devarsh Thakkar wrote:
> > > > > Pull in change which adds support for command line
> > > > > options (-e and --command) which can be used for
> > > > > launching programs or running commands in matchbox-terminal
> > > > > via command line.
> > > > >
> > > > > Signed-off-by: Devarsh Thakkar <devarsht@xilinx.com>
> > > > > ---
> > > > > meta/recipes-sato/matchbox-terminal/matchbox-terminal_0.1.bb
> > > > > | 2
> > > > > +-
> > > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/meta/recipes-sato/matchbox-terminal/matchbox-
> > > > > terminal_0.1.bb b/meta/recipes-sato/matchbox-
> > > > > terminal/matchbox-
> > > > > terminal_0.1.bb
> > > > > index 4488191..b7fbee7 100644
> > > > > --- a/meta/recipes-sato/matchbox-terminal/matchbox-
> > > > > terminal_0.1.bb
> > > > > +++ b/meta/recipes-sato/matchbox-terminal/matchbox-
> > > > > terminal_0.1.bb
> > > > > @@ -10,7 +10,7 @@ DEPENDS = "gtk+3 vte"
> > > > > SECTION = "x11/utils"
> > > > >
> > > > > #SRCREV tagged 0.1
> > > >
> > > > I'm guessing the above comment is no longer valid, nor is the
> > > > value
> > > > of
> > > > PV?
> > >
> > > Yes the comment is no longer valid I will remove that in V2.
> > > But the PV is still valid as matchbox-terminal package version is
> > > still 0.1 ( as set in AC_INIT at http://git.yoctoproject.org/cgit
> > > .cgi
> > > /matchbox-terminal/tree/configure.ac) even after this commit.
> >
> > No, after your change its not the 0.1 release, its
> > 0.1+git<revision>,
> > its a different version sometime after 0.1.
>
> Thanks for sharing, I got your point. I guess there are below
> possible solutions here :
> 1) set PV="${BPV}+gitr${SRCPV}" were BPV=0.1
> 2) move the tag 0.1 to ccbc3c70946b04313c6166ab0dfef21e5e83c289 for
> matchbox-terminal
> 3) Update a new tag at 0.2 at to
> ccbc3c70946b04313c6166ab0dfef21e5e83c289
>
> Kindly let me know which of the above is preferred way.
I've pushed a 0.2 tag to matchbox-terminal so we should be able to
upgrade the recipe to use that.
Cheers,
Richard
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] matchbox-terminal: Update commitID
2018-06-14 7:40 Devarsh Thakkar
@ 2018-06-18 5:12 ` Devarsh Thakkar
2018-06-19 15:44 ` Richard Purdie
1 sibling, 0 replies; 8+ messages in thread
From: Devarsh Thakkar @ 2018-06-18 5:12 UTC (permalink / raw)
To: openembedded-core, richard.purdie, Burton, Ross
Cc: Maulik Desai, Varunkumar Allagadapa
Gentle reminder.
> -----Original Message-----
> From: Devarsh Thakkar
> Sent: Thursday, June 14, 2018 1:10 PM
> To: 'openembedded-core@lists.openembedded.org' <openembedded-
> core@lists.openembedded.org>; 'richard.purdie@linuxfoundation.org'
> <richard.purdie@linuxfoundation.org>; 'Burton, Ross' <ross.burton@intel.com>
> Subject: Re: [PATCH] matchbox-terminal: Update commitID
>
> Hi Richard, Ross
>
> > Message: 2
> > Date: Mon, 11 Jun 2018 14:39:53 +0100
> > From: Richard Purdie <richard.purdie@linuxfoundation.org>
> > To: Devarsh Thakkar <DEVARSHT@xilinx.com>,
> > "openembedded-core@lists.openembedded.org"
> > <openembedded-core@lists.openembedded.org>
> > Cc: Maulik Desai <maulikd@xilinx.com>, Varunkumar Allagadapa
> > <VARUNKUM@xilinx.com>
> > Subject: Re: [OE-core] [PATCH] matchbox-terminal: Update commitID
> > Message-ID:
> > <642b938d82295e3b7ce922dad711c63904d62ca5.camel@linuxfounda
> > tion.org>
> > Content-Type: text/plain; charset="UTF-8"
> >
> > On Mon, 2018-06-11 at 12:39 +0000, Devarsh Thakkar wrote:
> > > Hi Richard,
> > >
> > > Thanks for the quick review.
> > > Replies inline.
> > >
> > > > Message: 5
> > > > Date: Sun, 10 Jun 2018 09:29:14 +0100
> > > > From: Richard Purdie <richard.purdie@linuxfoundation.org>
> > > > To: Devarsh Thakkar <devarsh.thakkar@xilinx.com>,
> > > > openembedded-core@lists.openembedded.org
> > > > Cc: maulikd@xilinx.com, varunkum@xilinx.com, JAEWON@xilinx.com,
> > > > Devarsh Thakkar <devarsht@xilinx.com>
> > > > Subject: Re: [OE-core] [PATCH] matchbox-terminal: Update commitID
> > > > Message-ID:
> > > > <56788cd154d9af0b6c9ea2ef78de23b1909fd7ee.camel@linuxfoundati
> > > > on.org>
> > > > Content-Type: text/plain; charset="UTF-8"
> > > >
> > > > On Sat, 2018-06-09 at 04:59 -0700, Devarsh Thakkar wrote:
> > > > > Pull in change which adds support for command line options (-e
> > > > > and --command) which can be used for launching programs or
> > > > > running commands in matchbox-terminal via command line.
> > > > >
> > > > > Signed-off-by: Devarsh Thakkar <devarsht@xilinx.com>
> > > > > ---
> > > > > meta/recipes-sato/matchbox-terminal/matchbox-terminal_0.1.bb |
> > > > > 2
> > > > > +-
> > > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/meta/recipes-sato/matchbox-terminal/matchbox-
> > > > > terminal_0.1.bb b/meta/recipes-sato/matchbox-terminal/matchbox-
> > > > > terminal_0.1.bb
> > > > > index 4488191..b7fbee7 100644
> > > > > --- a/meta/recipes-sato/matchbox-terminal/matchbox-
> > > > > terminal_0.1.bb
> > > > > +++ b/meta/recipes-sato/matchbox-terminal/matchbox-
> > > > > terminal_0.1.bb
> > > > > @@ -10,7 +10,7 @@ DEPENDS = "gtk+3 vte"
> > > > > SECTION = "x11/utils"
> > > > >
> > > > > #SRCREV tagged 0.1
> > > >
> > > > I'm guessing the above comment is no longer valid, nor is the
> > > > value of PV?
> > >
> > > Yes the comment is no longer valid I will remove that in V2.
> > > But the PV is still valid as matchbox-terminal package version is
> > > still 0.1 ( as set in AC_INIT at
> > > http://git.yoctoproject.org/cgit.cgi
> > > /matchbox-terminal/tree/configure.ac) even after this commit.
> >
> > No, after your change its not the 0.1 release, its 0.1+git<revision>,
> > its a different version sometime after 0.1.
> Thanks for sharing, I got your point. I guess there are below possible solutions
> here :
> 1) set PV="${BPV}+gitr${SRCPV}" were BPV=0.1
> 2) move the tag 0.1 to ccbc3c70946b04313c6166ab0dfef21e5e83c289 for
> matchbox-terminal
> 3) Update a new tag at 0.2 at to
> ccbc3c70946b04313c6166ab0dfef21e5e83c289
>
> Kindly let me know which of the above is preferred way.
>
> Thanks,
> Devarsh
> >
> > Cheers,
> >
> > Richard
> >
> >
> > ------------------------------
> >
> > Message: 3
> > Date: Mon, 11 Jun 2018 12:39:20 +0000
> > From: Devarsh Thakkar <DEVARSHT@xilinx.com>
> > To: "openembedded-core@lists.openembedded.org"
> > <openembedded-core@lists.openembedded.org>,
> > "richard.purdie@linuxfoundation.org"
> > <richard.purdie@linuxfoundation.org>
> > Cc: Maulik Desai <maulikd@xilinx.com>, Varunkumar Allagadapa
> > <VARUNKUM@xilinx.com>
> > Subject: Re: [OE-core] [PATCH] matchbox-terminal: Update commitID
> > Message-ID:
> > <CO1PR02MB0944771307967F828960631BC780@CO1PR02MB094.n
> > amprd02.prod.outlook.com>
> >
> > Content-Type: text/plain; charset="us-ascii"
> >
> > Hi Richard,
> >
> > Thanks for the quick review.
> > Replies inline.
> >
> > > Message: 5
> > > Date: Sun, 10 Jun 2018 09:29:14 +0100
> > > From: Richard Purdie <richard.purdie@linuxfoundation.org>
> > > To: Devarsh Thakkar <devarsh.thakkar@xilinx.com>,
> > > openembedded-core@lists.openembedded.org
> > > Cc: maulikd@xilinx.com, varunkum@xilinx.com, JAEWON@xilinx.com,
> > > Devarsh Thakkar <devarsht@xilinx.com>
> > > Subject: Re: [OE-core] [PATCH] matchbox-terminal: Update commitID
> > > Message-ID:
> > > <56788cd154d9af0b6c9ea2ef78de23b1909fd7ee.camel@linuxfoundati
> > > on.org>
> > > Content-Type: text/plain; charset="UTF-8"
> > >
> > > On Sat, 2018-06-09 at 04:59 -0700, Devarsh Thakkar wrote:
> > > > Pull in change which adds support for command line options (-e and
> > > > --command) which can be used for launching programs or running
> > > > commands in matchbox-terminal via command line.
> > > >
> > > > Signed-off-by: Devarsh Thakkar <devarsht@xilinx.com>
> > > > ---
> > > > meta/recipes-sato/matchbox-terminal/matchbox-terminal_0.1.bb | 2
> > > > +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/meta/recipes-sato/matchbox-terminal/matchbox-
> > > > terminal_0.1.bb b/meta/recipes-sato/matchbox-terminal/matchbox-
> > > > terminal_0.1.bb
> > > > index 4488191..b7fbee7 100644
> > > > --- a/meta/recipes-sato/matchbox-terminal/matchbox-terminal_0.1.bb
> > > > +++ b/meta/recipes-sato/matchbox-terminal/matchbox-terminal_0.1.bb
> > > > @@ -10,7 +10,7 @@ DEPENDS = "gtk+3 vte"
> > > > SECTION = "x11/utils"
> > > >
> > > > #SRCREV tagged 0.1
> > >
> > > I'm guessing the above comment is no longer valid, nor is the value
> > > of PV?
> > Yes the comment is no longer valid I will remove that in V2.
> > But the PV is still valid as matchbox-terminal package version is
> > still 0.1 ( as set in AC_INIT at
> > http://git.yoctoproject.org/cgit.cgi/matchbox-
> > terminal/tree/configure.ac) even after this commit.
> >
> > >
> > > > -SRCREV = "3ad357db2302760b8a8817b5f4478dd87479442f"
> > > > +SRCREV = "ccbc3c70946b04313c6166ab0dfef21e5e83c289"
> > > > SRC_URI = "git://git.yoctoproject.org/${BPN}"
> > > > UPSTREAM_CHECK_GITTAGREGEX = "(?P<pver>(\d+(\.\d+)+))"
> > > >
> > >
> > > Cheers,
> > >
> > > Richard
> > >
> > Thanks,
> > Devarsh
> >
> >
> > ------------------------------
> >
> > Message: 4
> > Date: Mon, 11 Jun 2018 07:42:31 -0700
> > From: akuster808 <akuster808@gmail.com>
> > To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>,
> > "openembedded-core@lists.openembedded.org"
> > <openembedded-core@lists.openembedded.org>
> > Subject: Re: [OE-core] [v5][PATCH] busybox: update to 1.28.4
> > Message-ID: <bb38520f-85d7-9e63-83a6-76477073285a@gmail.com>
> > Content-Type: text/plain; charset=utf-8
> >
> >
> >
> > On 06/11/2018 01:45 AM, Peter Kjellerstedt wrote:
> > >> -----Original Message-----
> > >> From: openembedded-core-bounces@lists.openembedded.org
> > >> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf
> > Of
> > >> Armin Kuster
> > >> Sent: den 11 juni 2018 06:18
> > >> To: akuster808@gmail.com; openembedded-
> core@lists.openembedded.org
> > >> Subject: [OE-core] [v5][PATCH] busybox: update to 1.28.4
> > >>
> > >> refactored busybox-udhcpc-no_deconfig.patch for this update updated
> > >> 1.28.3
> > >>
> > >> [v1]
> > >> removed patches included in update:
> > >> busybox/CVE-2011-5325.patch
> > >> busybox/CVE-2017-15873.patch
> > >> busybox/busybox-CVE-2017-16544.patch
> > >>
> > >> [v2]
> > >> Add back busybox-udhcpc-no_deconfig.patch ti SRC_URI, missed
> > >> earlier
> > >>
> > >> [v3]
> > >> Update defconfig based on feedback
> > >>
> > >> [v4]
> > >> Decided to update again.
> > >> 1.28.4
> > >>
> > >> [v5]
> > >> rebased change do to changes in master squashed .cfg into defconfig
> > >> and remove files Delete busybox-fix-lzma-segfaults.patch which is
> > >> included in updated.
> > >>
> > >> Signed-off-by: Armin Kuster <akuster808@gmail.com>
> > > The commit message should be rewritten to document the final commit,
> > > without any patch series references. They belong after --- below.
> >
> > Done that before and folks complained so I started included with files
> > got removed. May I suggest updating the process so we can be consistent.
> >
> > - armin
> > >
> > >> ---
> > >> .../busybox/busybox/CVE-2011-5325.patch | 481 ---------------------
> > >> .../busybox/busybox/CVE-2017-15873.patch | 95 ----
> > >> .../busybox/busybox/busybox-CVE-2017-16544.patch | 43 --
> > >> .../busybox/busybox-fix-lzma-segfaults.patch | 106 -----
> > >> .../busybox/busybox-udhcpc-no_deconfig.patch | 36 +-
> > >> meta/recipes-core/busybox/busybox/defconfig | 278 ++++++------
> > >> meta/recipes-core/busybox/busybox/getopts.cfg | 3 -
> > >> .../busybox/busybox/login-utilities.cfg | 13 -
> > >> meta/recipes-core/busybox/busybox/mdev.cfg | 2 -
> > >> .../busybox/busybox/mount-via-label.cfg | 9 -
> > >> meta/recipes-core/busybox/busybox/resize.cfg | 2 -
> > >> meta/recipes-core/busybox/busybox/sha1sum.cfg | 1 -
> > >> meta/recipes-core/busybox/busybox/sha256sum.cfg | 1 -
> > >> meta/recipes-core/busybox/busybox/syslog.cfg | 11 -
> > >> .../{busybox_1.27.2.bb => busybox_1.28.4.bb} | 15 +-
> > >> 15 files changed, 162 insertions(+), 934 deletions(-) delete mode
> > >> 100755 meta/recipes-core/busybox/busybox/CVE-2011-
> > 5325.patch
> > >> delete mode 100644 meta/recipes-core/busybox/busybox/CVE-2017-
> > 15873.patch
> > >> delete mode 100644 meta/recipes-core/busybox/busybox/busybox-CVE-
> > 2017-16544.patch
> > >> delete mode 100644 meta/recipes-core/busybox/busybox/busybox-fix-
> > lzma-segfaults.patch
> > >> delete mode 100644 meta/recipes-core/busybox/busybox/getopts.cfg
> > >> delete mode 100644
> > >> meta/recipes-core/busybox/busybox/login-utilities.cfg
> > >> delete mode 100644 meta/recipes-core/busybox/busybox/mount-via-
> > label.cfg
> > >> delete mode 100644 meta/recipes-core/busybox/busybox/resize.cfg
> > >> delete mode 100644 meta/recipes-core/busybox/busybox/sha1sum.cfg
> > >> delete mode 100644 meta/recipes-core/busybox/busybox/sha256sum.cfg
> > >> delete mode 100644 meta/recipes-core/busybox/busybox/syslog.cfg
> > >> rename meta/recipes-core/busybox/{busybox_1.27.2.bb =>
> > busybox_1.28.4.bb} (72%)
> > > //Peter
> > >
> >
> >
> >
> > ------------------------------
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> >
> >
> > End of Openembedded-core Digest, Vol 89, Issue 107
> > **************************************************
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] matchbox-terminal: Update commitID
@ 2018-06-14 7:40 Devarsh Thakkar
2018-06-18 5:12 ` Devarsh Thakkar
2018-06-19 15:44 ` Richard Purdie
0 siblings, 2 replies; 8+ messages in thread
From: Devarsh Thakkar @ 2018-06-14 7:40 UTC (permalink / raw)
To: openembedded-core, richard.purdie, Burton, Ross
Hi Richard, Ross
> Message: 2
> Date: Mon, 11 Jun 2018 14:39:53 +0100
> From: Richard Purdie <richard.purdie@linuxfoundation.org>
> To: Devarsh Thakkar <DEVARSHT@xilinx.com>,
> "openembedded-core@lists.openembedded.org"
> <openembedded-core@lists.openembedded.org>
> Cc: Maulik Desai <maulikd@xilinx.com>, Varunkumar Allagadapa
> <VARUNKUM@xilinx.com>
> Subject: Re: [OE-core] [PATCH] matchbox-terminal: Update commitID
> Message-ID:
> <642b938d82295e3b7ce922dad711c63904d62ca5.camel@linuxfounda
> tion.org>
> Content-Type: text/plain; charset="UTF-8"
>
> On Mon, 2018-06-11 at 12:39 +0000, Devarsh Thakkar wrote:
> > Hi Richard,
> >
> > Thanks for the quick review.
> > Replies inline.
> >
> > > Message: 5
> > > Date: Sun, 10 Jun 2018 09:29:14 +0100
> > > From: Richard Purdie <richard.purdie@linuxfoundation.org>
> > > To: Devarsh Thakkar <devarsh.thakkar@xilinx.com>,
> > > openembedded-core@lists.openembedded.org
> > > Cc: maulikd@xilinx.com, varunkum@xilinx.com, JAEWON@xilinx.com,
> > > Devarsh Thakkar <devarsht@xilinx.com>
> > > Subject: Re: [OE-core] [PATCH] matchbox-terminal: Update commitID
> > > Message-ID:
> > > <56788cd154d9af0b6c9ea2ef78de23b1909fd7ee.camel@linuxfoundati
> > > on.org>
> > > Content-Type: text/plain; charset="UTF-8"
> > >
> > > On Sat, 2018-06-09 at 04:59 -0700, Devarsh Thakkar wrote:
> > > > Pull in change which adds support for command line
> > > > options (-e and --command) which can be used for
> > > > launching programs or running commands in matchbox-terminal
> > > > via command line.
> > > >
> > > > Signed-off-by: Devarsh Thakkar <devarsht@xilinx.com>
> > > > ---
> > > > meta/recipes-sato/matchbox-terminal/matchbox-terminal_0.1.bb | 2
> > > > +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/meta/recipes-sato/matchbox-terminal/matchbox-
> > > > terminal_0.1.bb b/meta/recipes-sato/matchbox-terminal/matchbox-
> > > > terminal_0.1.bb
> > > > index 4488191..b7fbee7 100644
> > > > --- a/meta/recipes-sato/matchbox-terminal/matchbox-
> > > > terminal_0.1.bb
> > > > +++ b/meta/recipes-sato/matchbox-terminal/matchbox-
> > > > terminal_0.1.bb
> > > > @@ -10,7 +10,7 @@ DEPENDS = "gtk+3 vte"
> > > > SECTION = "x11/utils"
> > > >
> > > > #SRCREV tagged 0.1
> > >
> > > I'm guessing the above comment is no longer valid, nor is the value
> > > of
> > > PV?
> >
> > Yes the comment is no longer valid I will remove that in V2.
> > But the PV is still valid as matchbox-terminal package version is
> > still 0.1 ( as set in AC_INIT at http://git.yoctoproject.org/cgit.cgi
> > /matchbox-terminal/tree/configure.ac) even after this commit.
>
> No, after your change its not the 0.1 release, its 0.1+git<revision>,
> its a different version sometime after 0.1.
Thanks for sharing, I got your point. I guess there are below possible solutions here :
1) set PV="${BPV}+gitr${SRCPV}" were BPV=0.1
2) move the tag 0.1 to ccbc3c70946b04313c6166ab0dfef21e5e83c289 for matchbox-terminal
3) Update a new tag at 0.2 at to ccbc3c70946b04313c6166ab0dfef21e5e83c289
Kindly let me know which of the above is preferred way.
Thanks,
Devarsh
>
> Cheers,
>
> Richard
>
>
> ------------------------------
>
> Message: 3
> Date: Mon, 11 Jun 2018 12:39:20 +0000
> From: Devarsh Thakkar <DEVARSHT@xilinx.com>
> To: "openembedded-core@lists.openembedded.org"
> <openembedded-core@lists.openembedded.org>,
> "richard.purdie@linuxfoundation.org"
> <richard.purdie@linuxfoundation.org>
> Cc: Maulik Desai <maulikd@xilinx.com>, Varunkumar Allagadapa
> <VARUNKUM@xilinx.com>
> Subject: Re: [OE-core] [PATCH] matchbox-terminal: Update commitID
> Message-ID:
> <CO1PR02MB0944771307967F828960631BC780@CO1PR02MB094.n
> amprd02.prod.outlook.com>
>
> Content-Type: text/plain; charset="us-ascii"
>
> Hi Richard,
>
> Thanks for the quick review.
> Replies inline.
>
> > Message: 5
> > Date: Sun, 10 Jun 2018 09:29:14 +0100
> > From: Richard Purdie <richard.purdie@linuxfoundation.org>
> > To: Devarsh Thakkar <devarsh.thakkar@xilinx.com>,
> > openembedded-core@lists.openembedded.org
> > Cc: maulikd@xilinx.com, varunkum@xilinx.com, JAEWON@xilinx.com,
> > Devarsh Thakkar <devarsht@xilinx.com>
> > Subject: Re: [OE-core] [PATCH] matchbox-terminal: Update commitID
> > Message-ID:
> > <56788cd154d9af0b6c9ea2ef78de23b1909fd7ee.camel@linuxfoundati
> > on.org>
> > Content-Type: text/plain; charset="UTF-8"
> >
> > On Sat, 2018-06-09 at 04:59 -0700, Devarsh Thakkar wrote:
> > > Pull in change which adds support for command line
> > > options (-e and --command) which can be used for
> > > launching programs or running commands in matchbox-terminal
> > > via command line.
> > >
> > > Signed-off-by: Devarsh Thakkar <devarsht@xilinx.com>
> > > ---
> > > meta/recipes-sato/matchbox-terminal/matchbox-terminal_0.1.bb | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/meta/recipes-sato/matchbox-terminal/matchbox-
> > > terminal_0.1.bb b/meta/recipes-sato/matchbox-terminal/matchbox-
> > > terminal_0.1.bb
> > > index 4488191..b7fbee7 100644
> > > --- a/meta/recipes-sato/matchbox-terminal/matchbox-terminal_0.1.bb
> > > +++ b/meta/recipes-sato/matchbox-terminal/matchbox-terminal_0.1.bb
> > > @@ -10,7 +10,7 @@ DEPENDS = "gtk+3 vte"
> > > SECTION = "x11/utils"
> > >
> > > #SRCREV tagged 0.1
> >
> > I'm guessing the above comment is no longer valid, nor is the value of
> > PV?
> Yes the comment is no longer valid I will remove that in V2.
> But the PV is still valid as matchbox-terminal package version is still 0.1 ( as set
> in AC_INIT at http://git.yoctoproject.org/cgit.cgi/matchbox-
> terminal/tree/configure.ac) even after this commit.
>
> >
> > > -SRCREV = "3ad357db2302760b8a8817b5f4478dd87479442f"
> > > +SRCREV = "ccbc3c70946b04313c6166ab0dfef21e5e83c289"
> > > SRC_URI = "git://git.yoctoproject.org/${BPN}"
> > > UPSTREAM_CHECK_GITTAGREGEX = "(?P<pver>(\d+(\.\d+)+))"
> > >
> >
> > Cheers,
> >
> > Richard
> >
> Thanks,
> Devarsh
>
>
> ------------------------------
>
> Message: 4
> Date: Mon, 11 Jun 2018 07:42:31 -0700
> From: akuster808 <akuster808@gmail.com>
> To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>,
> "openembedded-core@lists.openembedded.org"
> <openembedded-core@lists.openembedded.org>
> Subject: Re: [OE-core] [v5][PATCH] busybox: update to 1.28.4
> Message-ID: <bb38520f-85d7-9e63-83a6-76477073285a@gmail.com>
> Content-Type: text/plain; charset=utf-8
>
>
>
> On 06/11/2018 01:45 AM, Peter Kjellerstedt wrote:
> >> -----Original Message-----
> >> From: openembedded-core-bounces@lists.openembedded.org
> >> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf
> Of
> >> Armin Kuster
> >> Sent: den 11 juni 2018 06:18
> >> To: akuster808@gmail.com; openembedded-core@lists.openembedded.org
> >> Subject: [OE-core] [v5][PATCH] busybox: update to 1.28.4
> >>
> >> refactored busybox-udhcpc-no_deconfig.patch for this update
> >> updated 1.28.3
> >>
> >> [v1]
> >> removed patches included in update:
> >> busybox/CVE-2011-5325.patch
> >> busybox/CVE-2017-15873.patch
> >> busybox/busybox-CVE-2017-16544.patch
> >>
> >> [v2]
> >> Add back busybox-udhcpc-no_deconfig.patch ti SRC_URI, missed earlier
> >>
> >> [v3]
> >> Update defconfig based on feedback
> >>
> >> [v4]
> >> Decided to update again.
> >> 1.28.4
> >>
> >> [v5]
> >> rebased change do to changes in master
> >> squashed .cfg into defconfig and remove files
> >> Delete busybox-fix-lzma-segfaults.patch which is included in updated.
> >>
> >> Signed-off-by: Armin Kuster <akuster808@gmail.com>
> > The commit message should be rewritten to document the final commit,
> > without any patch series references. They belong after --- below.
>
> Done that before and folks complained so I started included with files
> got removed. May I suggest updating the process so we can be consistent.
>
> - armin
> >
> >> ---
> >> .../busybox/busybox/CVE-2011-5325.patch | 481 ---------------------
> >> .../busybox/busybox/CVE-2017-15873.patch | 95 ----
> >> .../busybox/busybox/busybox-CVE-2017-16544.patch | 43 --
> >> .../busybox/busybox-fix-lzma-segfaults.patch | 106 -----
> >> .../busybox/busybox-udhcpc-no_deconfig.patch | 36 +-
> >> meta/recipes-core/busybox/busybox/defconfig | 278 ++++++------
> >> meta/recipes-core/busybox/busybox/getopts.cfg | 3 -
> >> .../busybox/busybox/login-utilities.cfg | 13 -
> >> meta/recipes-core/busybox/busybox/mdev.cfg | 2 -
> >> .../busybox/busybox/mount-via-label.cfg | 9 -
> >> meta/recipes-core/busybox/busybox/resize.cfg | 2 -
> >> meta/recipes-core/busybox/busybox/sha1sum.cfg | 1 -
> >> meta/recipes-core/busybox/busybox/sha256sum.cfg | 1 -
> >> meta/recipes-core/busybox/busybox/syslog.cfg | 11 -
> >> .../{busybox_1.27.2.bb => busybox_1.28.4.bb} | 15 +-
> >> 15 files changed, 162 insertions(+), 934 deletions(-)
> >> delete mode 100755 meta/recipes-core/busybox/busybox/CVE-2011-
> 5325.patch
> >> delete mode 100644 meta/recipes-core/busybox/busybox/CVE-2017-
> 15873.patch
> >> delete mode 100644 meta/recipes-core/busybox/busybox/busybox-CVE-
> 2017-16544.patch
> >> delete mode 100644 meta/recipes-core/busybox/busybox/busybox-fix-
> lzma-segfaults.patch
> >> delete mode 100644 meta/recipes-core/busybox/busybox/getopts.cfg
> >> delete mode 100644 meta/recipes-core/busybox/busybox/login-utilities.cfg
> >> delete mode 100644 meta/recipes-core/busybox/busybox/mount-via-
> label.cfg
> >> delete mode 100644 meta/recipes-core/busybox/busybox/resize.cfg
> >> delete mode 100644 meta/recipes-core/busybox/busybox/sha1sum.cfg
> >> delete mode 100644 meta/recipes-core/busybox/busybox/sha256sum.cfg
> >> delete mode 100644 meta/recipes-core/busybox/busybox/syslog.cfg
> >> rename meta/recipes-core/busybox/{busybox_1.27.2.bb =>
> busybox_1.28.4.bb} (72%)
> > //Peter
> >
>
>
>
> ------------------------------
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>
> End of Openembedded-core Digest, Vol 89, Issue 107
> **************************************************
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] matchbox-terminal: Update commitID
2018-06-11 12:39 Devarsh Thakkar
@ 2018-06-11 13:39 ` Richard Purdie
0 siblings, 0 replies; 8+ messages in thread
From: Richard Purdie @ 2018-06-11 13:39 UTC (permalink / raw)
To: Devarsh Thakkar, openembedded-core; +Cc: Maulik Desai, Varunkumar Allagadapa
On Mon, 2018-06-11 at 12:39 +0000, Devarsh Thakkar wrote:
> Hi Richard,
>
> Thanks for the quick review.
> Replies inline.
>
> > Message: 5
> > Date: Sun, 10 Jun 2018 09:29:14 +0100
> > From: Richard Purdie <richard.purdie@linuxfoundation.org>
> > To: Devarsh Thakkar <devarsh.thakkar@xilinx.com>,
> > openembedded-core@lists.openembedded.org
> > Cc: maulikd@xilinx.com, varunkum@xilinx.com, JAEWON@xilinx.com,
> > Devarsh Thakkar <devarsht@xilinx.com>
> > Subject: Re: [OE-core] [PATCH] matchbox-terminal: Update commitID
> > Message-ID:
> > <56788cd154d9af0b6c9ea2ef78de23b1909fd7ee.camel@linuxfoundati
> > on.org>
> > Content-Type: text/plain; charset="UTF-8"
> >
> > On Sat, 2018-06-09 at 04:59 -0700, Devarsh Thakkar wrote:
> > > Pull in change which adds support for command line
> > > options (-e and --command) which can be used for
> > > launching programs or running commands in matchbox-terminal
> > > via command line.
> > >
> > > Signed-off-by: Devarsh Thakkar <devarsht@xilinx.com>
> > > ---
> > > meta/recipes-sato/matchbox-terminal/matchbox-terminal_0.1.bb | 2
> > > +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/meta/recipes-sato/matchbox-terminal/matchbox-
> > > terminal_0.1.bb b/meta/recipes-sato/matchbox-terminal/matchbox-
> > > terminal_0.1.bb
> > > index 4488191..b7fbee7 100644
> > > --- a/meta/recipes-sato/matchbox-terminal/matchbox-
> > > terminal_0.1.bb
> > > +++ b/meta/recipes-sato/matchbox-terminal/matchbox-
> > > terminal_0.1.bb
> > > @@ -10,7 +10,7 @@ DEPENDS = "gtk+3 vte"
> > > SECTION = "x11/utils"
> > >
> > > #SRCREV tagged 0.1
> >
> > I'm guessing the above comment is no longer valid, nor is the value
> > of
> > PV?
>
> Yes the comment is no longer valid I will remove that in V2.
> But the PV is still valid as matchbox-terminal package version is
> still 0.1 ( as set in AC_INIT at http://git.yoctoproject.org/cgit.cgi
> /matchbox-terminal/tree/configure.ac) even after this commit.
No, after your change its not the 0.1 release, its 0.1+git<revision>,
its a different version sometime after 0.1.
Cheers,
Richard
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] matchbox-terminal: Update commitID
@ 2018-06-11 12:39 Devarsh Thakkar
2018-06-11 13:39 ` Richard Purdie
0 siblings, 1 reply; 8+ messages in thread
From: Devarsh Thakkar @ 2018-06-11 12:39 UTC (permalink / raw)
To: openembedded-core, richard.purdie; +Cc: Maulik Desai, Varunkumar Allagadapa
Hi Richard,
Thanks for the quick review.
Replies inline.
> Message: 5
> Date: Sun, 10 Jun 2018 09:29:14 +0100
> From: Richard Purdie <richard.purdie@linuxfoundation.org>
> To: Devarsh Thakkar <devarsh.thakkar@xilinx.com>,
> openembedded-core@lists.openembedded.org
> Cc: maulikd@xilinx.com, varunkum@xilinx.com, JAEWON@xilinx.com,
> Devarsh Thakkar <devarsht@xilinx.com>
> Subject: Re: [OE-core] [PATCH] matchbox-terminal: Update commitID
> Message-ID:
> <56788cd154d9af0b6c9ea2ef78de23b1909fd7ee.camel@linuxfoundati
> on.org>
> Content-Type: text/plain; charset="UTF-8"
>
> On Sat, 2018-06-09 at 04:59 -0700, Devarsh Thakkar wrote:
> > Pull in change which adds support for command line
> > options (-e and --command) which can be used for
> > launching programs or running commands in matchbox-terminal
> > via command line.
> >
> > Signed-off-by: Devarsh Thakkar <devarsht@xilinx.com>
> > ---
> > meta/recipes-sato/matchbox-terminal/matchbox-terminal_0.1.bb | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/recipes-sato/matchbox-terminal/matchbox-
> > terminal_0.1.bb b/meta/recipes-sato/matchbox-terminal/matchbox-
> > terminal_0.1.bb
> > index 4488191..b7fbee7 100644
> > --- a/meta/recipes-sato/matchbox-terminal/matchbox-terminal_0.1.bb
> > +++ b/meta/recipes-sato/matchbox-terminal/matchbox-terminal_0.1.bb
> > @@ -10,7 +10,7 @@ DEPENDS = "gtk+3 vte"
> > SECTION = "x11/utils"
> >
> > #SRCREV tagged 0.1
>
> I'm guessing the above comment is no longer valid, nor is the value of
> PV?
Yes the comment is no longer valid I will remove that in V2.
But the PV is still valid as matchbox-terminal package version is still 0.1 ( as set in AC_INIT at http://git.yoctoproject.org/cgit.cgi/matchbox-terminal/tree/configure.ac) even after this commit.
>
> > -SRCREV = "3ad357db2302760b8a8817b5f4478dd87479442f"
> > +SRCREV = "ccbc3c70946b04313c6166ab0dfef21e5e83c289"
> > SRC_URI = "git://git.yoctoproject.org/${BPN}"
> > UPSTREAM_CHECK_GITTAGREGEX = "(?P<pver>(\d+(\.\d+)+))"
> >
>
> Cheers,
>
> Richard
>
Thanks,
Devarsh
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] matchbox-terminal: Update commitID
@ 2018-06-11 6:22 Devarsh Thakkar
0 siblings, 0 replies; 8+ messages in thread
From: Devarsh Thakkar @ 2018-06-11 6:22 UTC (permalink / raw)
To: openembedded-core, devarsht
Pull in change which adds support for command line
options (-e and --command) which can be used for
launching programs or running commands in matchbox-terminal
via command line.
Signed-off-by: Devarsh Thakkar <devarsht@xilinx.com>
---
meta/recipes-sato/matchbox-terminal/matchbox-terminal_0.1.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-sato/matchbox-terminal/matchbox-terminal_0.1.bb b/meta/recipes-sato/matchbox-terminal/matchbox-terminal_0.1.bb
index 4488191..b7fbee7 100644
--- a/meta/recipes-sato/matchbox-terminal/matchbox-terminal_0.1.bb
+++ b/meta/recipes-sato/matchbox-terminal/matchbox-terminal_0.1.bb
@@ -10,7 +10,7 @@ DEPENDS = "gtk+3 vte"
SECTION = "x11/utils"
#SRCREV tagged 0.1
-SRCREV = "3ad357db2302760b8a8817b5f4478dd87479442f"
+SRCREV = "ccbc3c70946b04313c6166ab0dfef21e5e83c289"
SRC_URI = "git://git.yoctoproject.org/${BPN}"
UPSTREAM_CHECK_GITTAGREGEX = "(?P<pver>(\d+(\.\d+)+))"
--
2.1.1
This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-06-19 15:44 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-09 11:59 [PATCH] matchbox-terminal: Update commitID Devarsh Thakkar
2018-06-10 8:29 ` Richard Purdie
2018-06-11 6:22 Devarsh Thakkar
2018-06-11 12:39 Devarsh Thakkar
2018-06-11 13:39 ` Richard Purdie
2018-06-14 7:40 Devarsh Thakkar
2018-06-18 5:12 ` Devarsh Thakkar
2018-06-19 15:44 ` Richard Purdie
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.