From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752198AbbLVHRz (ORCPT ); Tue, 22 Dec 2015 02:17:55 -0500 Received: from mx2.suse.de ([195.135.220.15]:42346 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750729AbbLVHRx (ORCPT ); Tue, 22 Dec 2015 02:17:53 -0500 Subject: Re: [PATCH v3 24/77] ncr5380: Implement NCR5380_dma_xfer_len and remove LIMIT_TRANSFERSIZE macro To: Finn Thain , "James E.J. Bottomley" , Michael Schmitz , linux-m68k@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, "Martin K. Petersen" , Russell King , linux-arm-kernel@lists.infradead.org References: <20151222011737.980475848@telegraphics.com.au> <20151222011744.545942658@telegraphics.com.au> From: Hannes Reinecke Message-ID: <5678F91F.3030306@suse.de> Date: Tue, 22 Dec 2015 08:17:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20151222011744.545942658@telegraphics.com.au> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/22/2015 02:18 AM, Finn Thain wrote: > Follow the example of the atari_NCR5380.c core driver and adopt the > NCR5380_dma_xfer_len() hook. Implement NCR5380_dma_xfer_len() for dtc.c > and g_NCR5380.c to take care of the limitations of these cards. Keep the > default for drivers using PSEUDO_DMA. > > Eliminate the unused macro LIMIT_TRANSFERSIZE. > > Signed-off-by: Finn Thain > > --- > drivers/scsi/NCR5380.c | 32 +++++--------------------------- > drivers/scsi/arm/cumana_1.c | 3 +++ > drivers/scsi/arm/oak.c | 2 ++ > drivers/scsi/atari_NCR5380.c | 8 +++++--- > drivers/scsi/dtc.c | 14 ++++++++++++++ > drivers/scsi/dtc.h | 3 +++ > drivers/scsi/g_NCR5380.c | 15 +++++++++++++++ > drivers/scsi/g_NCR5380.h | 3 +++ > drivers/scsi/mac_scsi.c | 1 + > drivers/scsi/pas16.h | 2 ++ > drivers/scsi/t128.h | 2 ++ > 11 files changed, 55 insertions(+), 30 deletions(-) > Hmm. I really, _really_, wish we could move away from the 'magic' definitions and use a proper function template. But maybe next time. So: Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hannes Reinecke Subject: Re: [PATCH v3 24/77] ncr5380: Implement NCR5380_dma_xfer_len and remove LIMIT_TRANSFERSIZE macro Date: Tue, 22 Dec 2015 08:17:51 +0100 Message-ID: <5678F91F.3030306@suse.de> References: <20151222011737.980475848@telegraphics.com.au> <20151222011744.545942658@telegraphics.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20151222011744.545942658@telegraphics.com.au> Sender: linux-scsi-owner@vger.kernel.org To: Finn Thain , "James E.J. Bottomley" , Michael Schmitz , linux-m68k@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, "Martin K. Petersen" , Russell King , linux-arm-kernel@lists.infradead.org List-Id: linux-m68k@vger.kernel.org On 12/22/2015 02:18 AM, Finn Thain wrote: > Follow the example of the atari_NCR5380.c core driver and adopt the > NCR5380_dma_xfer_len() hook. Implement NCR5380_dma_xfer_len() for dtc= =2Ec > and g_NCR5380.c to take care of the limitations of these cards. Keep = the > default for drivers using PSEUDO_DMA. > > Eliminate the unused macro LIMIT_TRANSFERSIZE. > > Signed-off-by: Finn Thain > > --- > drivers/scsi/NCR5380.c | 32 +++++--------------------------= - > drivers/scsi/arm/cumana_1.c | 3 +++ > drivers/scsi/arm/oak.c | 2 ++ > drivers/scsi/atari_NCR5380.c | 8 +++++--- > drivers/scsi/dtc.c | 14 ++++++++++++++ > drivers/scsi/dtc.h | 3 +++ > drivers/scsi/g_NCR5380.c | 15 +++++++++++++++ > drivers/scsi/g_NCR5380.h | 3 +++ > drivers/scsi/mac_scsi.c | 1 + > drivers/scsi/pas16.h | 2 ++ > drivers/scsi/t128.h | 2 ++ > 11 files changed, 55 insertions(+), 30 deletions(-) > Hmm. I really, _really_, wish we could move away from the 'magic'=20 definitions and use a proper function template. But maybe next time. So: Reviewed-by: Hannes Reinecke Cheers, Hannes --=20 Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg GF: J. Hawn, J. Guild, F. Imend=F6rffer, HRB 16746 (AG N=FCrnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: hare@suse.de (Hannes Reinecke) Date: Tue, 22 Dec 2015 08:17:51 +0100 Subject: [PATCH v3 24/77] ncr5380: Implement NCR5380_dma_xfer_len and remove LIMIT_TRANSFERSIZE macro In-Reply-To: <20151222011744.545942658@telegraphics.com.au> References: <20151222011737.980475848@telegraphics.com.au> <20151222011744.545942658@telegraphics.com.au> Message-ID: <5678F91F.3030306@suse.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 12/22/2015 02:18 AM, Finn Thain wrote: > Follow the example of the atari_NCR5380.c core driver and adopt the > NCR5380_dma_xfer_len() hook. Implement NCR5380_dma_xfer_len() for dtc.c > and g_NCR5380.c to take care of the limitations of these cards. Keep the > default for drivers using PSEUDO_DMA. > > Eliminate the unused macro LIMIT_TRANSFERSIZE. > > Signed-off-by: Finn Thain > > --- > drivers/scsi/NCR5380.c | 32 +++++--------------------------- > drivers/scsi/arm/cumana_1.c | 3 +++ > drivers/scsi/arm/oak.c | 2 ++ > drivers/scsi/atari_NCR5380.c | 8 +++++--- > drivers/scsi/dtc.c | 14 ++++++++++++++ > drivers/scsi/dtc.h | 3 +++ > drivers/scsi/g_NCR5380.c | 15 +++++++++++++++ > drivers/scsi/g_NCR5380.h | 3 +++ > drivers/scsi/mac_scsi.c | 1 + > drivers/scsi/pas16.h | 2 ++ > drivers/scsi/t128.h | 2 ++ > 11 files changed, 55 insertions(+), 30 deletions(-) > Hmm. I really, _really_, wish we could move away from the 'magic' definitions and use a proper function template. But maybe next time. So: Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare at suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg GF: J. Hawn, J. Guild, F. Imend?rffer, HRB 16746 (AG N?rnberg)