From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753229AbbLVHlJ (ORCPT ); Tue, 22 Dec 2015 02:41:09 -0500 Received: from mx2.suse.de ([195.135.220.15]:43303 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752644AbbLVHlF (ORCPT ); Tue, 22 Dec 2015 02:41:05 -0500 Subject: Re: [PATCH v3 43/77] ncr5380: Standardize reselection handling To: Finn Thain , "James E.J. Bottomley" , Michael Schmitz , linux-m68k@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, "Martin K. Petersen" References: <20151222011737.980475848@telegraphics.com.au> <20151222011749.695503926@telegraphics.com.au> From: Hannes Reinecke Message-ID: <5678FE8F.8020700@suse.de> Date: Tue, 22 Dec 2015 08:41:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20151222011749.695503926@telegraphics.com.au> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/22/2015 02:18 AM, Finn Thain wrote: > Bring the two NCR5380_reselect() implementations into agreement. > > Replace infinite loops in atari_NCR5380.c with timeouts, as per NCR5380.c. > > Remove 'abort' flag in NCR5380.c as per atari_NCR5380.c -- if reselection > fails, there may be no MESSAGE IN phase so don't attempt data transfer. > > During selection, don't interfere with the chip registers after a > reselection interrupt intervenes. > > Clean up some trivial issues with code style, comments and printk. > > Signed-off-by: Finn Thain > > --- > drivers/scsi/NCR5380.c | 115 +++++++++++++++++++++++-------------------- > drivers/scsi/atari_NCR5380.c | 50 ++++++++++-------- > 2 files changed, 93 insertions(+), 72 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)