From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:52369) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gyH63-0003qw-UQ for qemu-devel@nongnu.org; Mon, 25 Feb 2019 09:19:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gyH61-00069b-5p for qemu-devel@nongnu.org; Mon, 25 Feb 2019 09:19:07 -0500 From: Vladimir Sementsov-Ogievskiy Date: Mon, 25 Feb 2019 14:18:43 +0000 Message-ID: <5678ed17-fda7-4083-b4c6-488b3d6f916d@virtuozzo.com> References: <20190223002209.23084-1-jsnow@redhat.com> <20190223002209.23084-2-jsnow@redhat.com> In-Reply-To: <20190223002209.23084-2-jsnow@redhat.com> Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-ID: <02849838A2652B4E81C13F699BE7DA5D@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v2 1/4] block/dirty-bitmaps: add inconsistent bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , "qemu-devel@nongnu.org" , "qemu-block@nongnu.org" Cc: Stefan Hajnoczi , Eric Blake , Max Reitz , "Dr. David Alan Gilbert" , Kevin Wolf , Juan Quintela , Fam Zheng , Markus Armbruster MjMuMDIuMjAxOSAzOjIyLCBKb2huIFNub3cgd3JvdGU6DQo+IEFkZCBhbiBpbmNvbnNpc3RlbnQg Yml0IHRvIGRpcnR5LWJpdG1hcHMgdGhhdCBhbGxvd3MgdXMgdG8gcmVwb3J0IGEgYml0bWFwIGFz DQo+IHBlcnNpc3RlbnQgYnV0IHBvdGVudGlhbGx5IGluY29uc2lzdGVudCwgaS5lLiBpZiB3ZSBm aW5kIGJpdG1hcHMgb24gYSBxY293Mg0KPiB0aGF0IGhhdmUgYmVlbiBtYXJrZWQgYXMgImluIHVz ZSIuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBKb2huIFNub3cgPGpzbm93QHJlZGhhdC5jb20+DQo+ IC0tLQ0KPiAgIGJsb2NrL2RpcnR5LWJpdG1hcC5jICAgICAgICAgfCAxOSArKysrKysrKysrKysr KysrKysrDQo+ICAgaW5jbHVkZS9ibG9jay9kaXJ0eS1iaXRtYXAuaCB8ICAyICsrDQo+ICAgcWFw aS9ibG9jay1jb3JlLmpzb24gICAgICAgICB8ICA4ICsrKysrKy0tDQo+ICAgMyBmaWxlcyBjaGFu Z2VkLCAyNyBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQ0KPiANCj4gZGlmZiAtLWdpdCBh L2Jsb2NrL2RpcnR5LWJpdG1hcC5jIGIvYmxvY2svZGlydHktYml0bWFwLmMNCj4gaW5kZXggODZj M2I4N2FiOS4uOTA0MmMwNDc4OCAxMDA2NDQNCj4gLS0tIGEvYmxvY2svZGlydHktYml0bWFwLmMN Cj4gKysrIGIvYmxvY2svZGlydHktYml0bWFwLmMNCj4gQEAgLTQ2LDYgKzQ2LDkgQEAgc3RydWN0 IEJkcnZEaXJ0eUJpdG1hcCB7DQo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBhbmQgdGhpcyBiaXRtYXAgbXVzdCByZW1haW4gdW5jaGFuZ2VkIHdoaWxlDQo+ICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICB0aGlzIGZsYWcgaXMgc2V0LiAqLw0KPiAgICAg ICBib29sIHBlcnNpc3RlbnQ7ICAgICAgICAgICAgLyogYml0bWFwIG11c3QgYmUgc2F2ZWQgdG8g b3duZXIgZGlzayBpbWFnZSAqLw0KPiArICAgIGJvb2wgaW5jb25zaXN0ZW50OyAgICAgICAgICAv KiBiaXRtYXAgaXMgcGVyc2lzdGVudCwgYnV0IG5vdCBvd25lZCBieSBRRU1VLg0KPiArICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgKiBJdCBjYW5ub3QgYmUgdXNlZCBhdCBhbGwgaW4g YW55IHdheSwgZXhjZXB0DQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAqIGEg UU1QIHVzZXIgY2FuIHJlbW92ZSBpdC4gKi8NCj4gICAgICAgYm9vbCBtaWdyYXRpb247ICAgICAg ICAgICAgIC8qIEJpdG1hcCBpcyBzZWxlY3RlZCBmb3IgbWlncmF0aW9uLCBpdCBzaG91bGQNCj4g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG5vdCBiZSBzdG9yZWQgb24gdGhl IG5leHQgaW5hY3RpdmF0aW9uDQo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAocGVyc2lzdGVudCBmbGFnIGRvZXNuJ3QgbWF0dGVyIHVudGlsIG5leHQNCj4gQEAgLTQ2Miw2 ICs0NjUsOCBAQCBCbG9ja0RpcnR5SW5mb0xpc3QgKmJkcnZfcXVlcnlfZGlydHlfYml0bWFwcyhC bG9ja0RyaXZlclN0YXRlICpicykNCj4gICAgICAgICAgIGluZm8tPnJlY29yZGluZyA9IGJkcnZf ZGlydHlfYml0bWFwX3JlY29yZGluZyhibSk7DQo+ICAgICAgICAgICBpbmZvLT5idXN5ID0gYmRy dl9kaXJ0eV9iaXRtYXBfYnVzeShibSk7DQo+ICAgICAgICAgICBpbmZvLT5wZXJzaXN0ZW50ID0g Ym0tPnBlcnNpc3RlbnQ7DQo+ICsgICAgICAgIGluZm8tPmhhc19pbmNvbnNpc3RlbnQgPSBibS0+ aW5jb25zaXN0ZW50Ow0KPiArICAgICAgICBpbmZvLT5pbmNvbnNpc3RlbnQgPSBibS0+aW5jb25z aXN0ZW50Ow0KPiAgICAgICAgICAgZW50cnktPnZhbHVlID0gaW5mbzsNCj4gICAgICAgICAgICpw bGlzdCA9IGVudHJ5Ow0KPiAgICAgICAgICAgcGxpc3QgPSAmZW50cnktPm5leHQ7DQo+IEBAIC03 MDksNiArNzE0LDE1IEBAIHZvaWQgYmRydl9kaXJ0eV9iaXRtYXBfc2V0X3BlcnNpc3RhbmNlKEJk cnZEaXJ0eUJpdG1hcCAqYml0bWFwLCBib29sIHBlcnNpc3RlbnQpDQo+ICAgICAgIHFlbXVfbXV0 ZXhfdW5sb2NrKGJpdG1hcC0+bXV0ZXgpOw0KPiAgIH0NCj4gICANCj4gKy8qIENhbGxlZCB3aXRo IEJRTCB0YWtlbi4gKi8NCj4gK3ZvaWQgYmRydl9kaXJ0eV9iaXRtYXBfc2V0X2luY29uc2lzdGVu dChCZHJ2RGlydHlCaXRtYXAgKmJpdG1hcCkNCj4gK3sNCj4gKyAgICBxZW11X211dGV4X2xvY2so Yml0bWFwLT5tdXRleCk7DQo+ICsgICAgYml0bWFwLT5pbmNvbnNpc3RlbnQgPSB0cnVlOw0KPiAr ICAgIGJpdG1hcC0+ZGlzYWJsZWQgPSB0cnVlOw0KPiArICAgIHFlbXVfbXV0ZXhfdW5sb2NrKGJp dG1hcC0+bXV0ZXgpOw0KPiArfQ0KDQpEaWRuJ3QgeW91IGNvbnNpZGVyIHNlcGFyYXRlIGJkcnZf Y3JlYXRlX2luY29uc2lzdGVudF9iaXRtYXAsIHdoaWNoIHdpbGwgbm90IGFsbG9jYXRlIEhCaXRt YXA/DQoNCkl0IG1heSBiZSBkb25lIHNlcGFyYXRlbHkgb2Zjb3Vyc2UuLg0KDQo+ICsNCj4gICAv KiBDYWxsZWQgd2l0aCBCUUwgdGFrZW4uICovDQo+ICAgdm9pZCBiZHJ2X2RpcnR5X2JpdG1hcF9z ZXRfbWlncmF0aW9uKEJkcnZEaXJ0eUJpdG1hcCAqYml0bWFwLCBib29sIG1pZ3JhdGlvbikNCj4g ICB7DQo+IEBAIC03MjIsNiArNzM2LDExIEBAIGJvb2wgYmRydl9kaXJ0eV9iaXRtYXBfZ2V0X3Bl cnNpc3RhbmNlKEJkcnZEaXJ0eUJpdG1hcCAqYml0bWFwKQ0KPiAgICAgICByZXR1cm4gYml0bWFw LT5wZXJzaXN0ZW50ICYmICFiaXRtYXAtPm1pZ3JhdGlvbjsNCj4gICB9DQo+ICAgDQo+ICtib29s IGJkcnZfZGlydHlfYml0bWFwX2luY29uc2lzdGVudChCZHJ2RGlydHlCaXRtYXAgKmJpdG1hcCkN Cj4gK3sNCj4gKyAgICByZXR1cm4gYml0bWFwLT5pbmNvbnNpc3RlbnQ7DQo+ICt9DQo+ICsNCj4g ICBib29sIGJkcnZfaGFzX2NoYW5nZWRfcGVyc2lzdGVudF9iaXRtYXBzKEJsb2NrRHJpdmVyU3Rh dGUgKmJzKQ0KPiAgIHsNCj4gICAgICAgQmRydkRpcnR5Qml0bWFwICpibTsNCj4gZGlmZiAtLWdp dCBhL2luY2x1ZGUvYmxvY2svZGlydHktYml0bWFwLmggYi9pbmNsdWRlL2Jsb2NrL2RpcnR5LWJp dG1hcC5oDQo+IGluZGV4IGJhODQ3N2I3M2YuLmIyNzA3NzNmN2UgMTAwNjQ0DQo+IC0tLSBhL2lu Y2x1ZGUvYmxvY2svZGlydHktYml0bWFwLmgNCj4gKysrIGIvaW5jbHVkZS9ibG9jay9kaXJ0eS1i aXRtYXAuaA0KPiBAQCAtNjgsNiArNjgsNyBAQCB2b2lkIGJkcnZfZGlydHlfYml0bWFwX2Rlc2Vy aWFsaXplX2ZpbmlzaChCZHJ2RGlydHlCaXRtYXAgKmJpdG1hcCk7DQo+ICAgdm9pZCBiZHJ2X2Rp cnR5X2JpdG1hcF9zZXRfcmVhZG9ubHkoQmRydkRpcnR5Qml0bWFwICpiaXRtYXAsIGJvb2wgdmFs dWUpOw0KPiAgIHZvaWQgYmRydl9kaXJ0eV9iaXRtYXBfc2V0X3BlcnNpc3RhbmNlKEJkcnZEaXJ0 eUJpdG1hcCAqYml0bWFwLA0KPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIGJvb2wgcGVyc2lzdGVudCk7DQo+ICt2b2lkIGJkcnZfZGlydHlfYml0bWFwX3NldF9pbmNv bnNpc3RlbnQoQmRydkRpcnR5Qml0bWFwICpiaXRtYXApOw0KPiAgIHZvaWQgYmRydl9kaXJ0eV9i aXRtYXBfc2V0X2J1c3koQmRydkRpcnR5Qml0bWFwICpiaXRtYXAsIGJvb2wgYnVzeSk7DQo+ICAg dm9pZCBiZHJ2X21lcmdlX2RpcnR5X2JpdG1hcChCZHJ2RGlydHlCaXRtYXAgKmRlc3QsIGNvbnN0 IEJkcnZEaXJ0eUJpdG1hcCAqc3JjLA0KPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg SEJpdG1hcCAqKmJhY2t1cCwgRXJyb3IgKiplcnJwKTsNCj4gQEAgLTkxLDYgKzkyLDcgQEAgYm9v bCBiZHJ2X2RpcnR5X2JpdG1hcF9yZWFkb25seShjb25zdCBCZHJ2RGlydHlCaXRtYXAgKmJpdG1h cCk7DQo+ICAgYm9vbCBiZHJ2X2hhc19yZWFkb25seV9iaXRtYXBzKEJsb2NrRHJpdmVyU3RhdGUg KmJzKTsNCj4gICBib29sIGJkcnZfZGlydHlfYml0bWFwX2dldF9hdXRvbG9hZChjb25zdCBCZHJ2 RGlydHlCaXRtYXAgKmJpdG1hcCk7DQo+ICAgYm9vbCBiZHJ2X2RpcnR5X2JpdG1hcF9nZXRfcGVy c2lzdGFuY2UoQmRydkRpcnR5Qml0bWFwICpiaXRtYXApOw0KPiArYm9vbCBiZHJ2X2RpcnR5X2Jp dG1hcF9pbmNvbnNpc3RlbnQoQmRydkRpcnR5Qml0bWFwICpiaXRtYXApOw0KPiAgIGJvb2wgYmRy dl9kaXJ0eV9iaXRtYXBfYnVzeShCZHJ2RGlydHlCaXRtYXAgKmJpdG1hcCk7DQo+ICAgYm9vbCBi ZHJ2X2hhc19jaGFuZ2VkX3BlcnNpc3RlbnRfYml0bWFwcyhCbG9ja0RyaXZlclN0YXRlICpicyk7 DQo+ICAgQmRydkRpcnR5Qml0bWFwICpiZHJ2X2RpcnR5X2JpdG1hcF9uZXh0KEJsb2NrRHJpdmVy U3RhdGUgKmJzLA0KPiBkaWZmIC0tZ2l0IGEvcWFwaS9ibG9jay1jb3JlLmpzb24gYi9xYXBpL2Js b2NrLWNvcmUuanNvbg0KPiBpbmRleCA2ZTU0MzU5NGIzLi5hNzIwOWZjZTIyIDEwMDY0NA0KPiAt LS0gYS9xYXBpL2Jsb2NrLWNvcmUuanNvbg0KPiArKysgYi9xYXBpL2Jsb2NrLWNvcmUuanNvbg0K PiBAQCAtNDcwLDEyICs0NzAsMTYgQEANCj4gICAjIEBwZXJzaXN0ZW50OiB0cnVlIGlmIHRoZSBi aXRtYXAgd2lsbCBldmVudHVhbGx5IGJlIGZsdXNoZWQgdG8gcGVyc2lzdGVudA0KPiAgICMgICAg ICAgICAgICAgIHN0b3JhZ2UgKHNpbmNlIDQuMCkNCj4gICAjDQo+ICsjIEBpbmNvbnNpc3RlbnQ6 IHRydWUgaWYgdGhpcyBpcyBhIHBlcnNpc3RlbnQgYml0bWFwIHRoYXQgUUVNVSBkb2VzIG5vdCBv d24uDQo+ICsjICAgICAgICAgICAgICAgIEltcGxpZXMgQHJlY29yZGluZyBhbmQgQGJ1c3kgdG8g YmUgZmFsc2UuIFRvIHJlY2xhaW0NCj4gKyMgICAgICAgICAgICAgICAgb3duZXJzaGlwLCB1c2Ug QGJsb2NrLWRpcnR5LWJpdG1hcC1yZW1vdmUuIChzaW5jZSA0LjApDQoNCklmIHdlIG9wZW5lZCBh biBpbWFnZSBmb3Igcncgd2l0aCBpbi11c2UgYml0bWFwcywgdGhlIG1haW4gdGhpbmcgYWJvdXQg dGhlbSBub3QNCnRoYXQgUUVNVSBkb2Vzbid0IG93biB0aGVtLCBidXQgdGhhdCB0aGV5IGFyZSB0 cnVseSBpbmNvbnNpc3RlbnQuIE5vYm9keSBvd25zIHRoZW0uDQoNCkFsc28sICJRRU1VIGRvZXMg bm90IG93biIgc291bmQgbGlrZSBzb21lYm9keSBvdGhlciBtYXkgb3duLiBUaGVuIHJlbW92aW5n IGl0IGRvbid0DQpzZWVtIGEgY29ycmVjdCB0aGluZyB0byBkby4NCg0KQW5kIHJlbW92aW5nIGRv bid0IHJlY2xhaW0gb3duZXJzaGlwLCBidXQganVzdCByZW1vdmUgKGxvb2tzIGxpa2UgaXQgd2Fz IG1vcmUgYWJvdXQNCnByZXZpb3VzIHZlcnNpb24gd2l0aCAtY2xlYXIpLg0KDQpTbyBmb3IgbWUg c29tZXRoaW5nIGxpa2U6ICJCaXRtYXAgd2FzIG5vdCBjb3JyZWN0bHkgc2F2ZWQgYWZ0ZXIgbGFz dCB1c2FnZSwgc28gaXQNCm1heSBiZSBpbmNvbnNpc3RlbnQuIEl0J3MgdXNlbGVzcyBhbmQgb25s eSB0YWtlIHBsYWNlIGluIGEgbGlzdC4gVGhlIG9ubHkgcG9zc2libGUNCm9wZXJhdGlvbiBvbiBp dCBpcyByZW1vdmUuIiBzZWVtcyBiZXR0ZXIuDQoNCj4gKyMNCj4gICAjIFNpbmNlOiAxLjMNCj4g ICAjIw0KPiAgIHsgJ3N0cnVjdCc6ICdCbG9ja0RpcnR5SW5mbycsDQo+ICAgICAnZGF0YSc6IHsn Km5hbWUnOiAnc3RyJywgJ2NvdW50JzogJ2ludCcsICdncmFudWxhcml0eSc6ICd1aW50MzInLA0K PiAtICAgICAgICAgICAncmVjb3JkaW5nJzogJ2Jvb2wnLCAnYnVzeSc6ICdib29sJywNCj4gLSAg ICAgICAgICAgJ3N0YXR1cyc6ICdEaXJ0eUJpdG1hcFN0YXR1cycsICdwZXJzaXN0ZW50JzogJ2Jv b2wnIH0gfQ0KPiArICAgICAgICAgICAncmVjb3JkaW5nJzogJ2Jvb2wnLCAnYnVzeSc6ICdib29s JywgJ3N0YXR1cyc6ICdEaXJ0eUJpdG1hcFN0YXR1cycsDQo+ICsgICAgICAgICAgICdwZXJzaXN0 ZW50JzogJ2Jvb2wnLCAnKmluY29uc2lzdGVudCc6ICdib29sJyB9IH0NCj4gICANCj4gICAjIw0K PiAgICMgQFFjb3cyQml0bWFwSW5mb0ZsYWdzOg0KPiANCg0KDQotLSANCkJlc3QgcmVnYXJkcywN ClZsYWRpbWlyDQo=