From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754317AbbLVJWN (ORCPT <rfc822;w@1wt.eu>);
	Tue, 22 Dec 2015 04:22:13 -0500
Received: from hqemgate16.nvidia.com ([216.228.121.65]:19490 "EHLO
	hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754295AbbLVJWE (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 22 Dec 2015 04:22:04 -0500
X-PGP-Universal: processed;
	by hqnvupgp08.nvidia.com on Tue, 22 Dec 2015 01:18:21 -0800
Subject: Re: [PATCH 2/2] irqchip/gic: Only populate set_affinity for the root
 controller
To: kbuild test robot <lkp@intel.com>
References: <201512220801.Q9Hb6AOu%fengguang.wu@intel.com>
CC: <kbuild-all@01.org>, Thomas Gleixner <tglx@linutronix.de>,
        Jason Cooper <jason@lakedaemon.net>,
        Marc Zyngier <marc.zyngier@arm.com>, <linux-kernel@vger.kernel.org>
From: Jon Hunter <jonathanh@nvidia.com>
Message-ID: <56791637.6060708@nvidia.com>
Date: Tue, 22 Dec 2015 09:21:59 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <201512220801.Q9Hb6AOu%fengguang.wu@intel.com>
X-Originating-IP: [10.21.132.159]
X-ClientProxiedBy: UKMAIL102.nvidia.com (10.26.138.15) To UKMAIL101.nvidia.com
 (10.26.138.13)
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 22/12/15 01:00, kbuild test robot wrote:
> Hi Jon,
> 
> [auto build test ERROR on tip/irq/core]
> [also build test ERROR on next-20151221]
> [cannot apply to v4.4-rc6]
> 
> url:    https://github.com/0day-ci/linux/commits/Jon-Hunter/irqchip-gic-Remove-static-irq_chip-definition-for-eoimode1/20151221-221639
> config: arm-realview_defconfig (attached as .config)
> reproduce:
>         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # save the attached .config to linux build tree
>         make.cross ARCH=arm 
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/irqchip/irq-gic.c: In function '__gic_init_bases':
>>> drivers/irqchip/irq-gic.c:1019:33: error: 'gic_set_affinity' undeclared (first use in this function)
>        gic->chip.irq_set_affinity = gic_set_affinity;
>                                     ^
>    drivers/irqchip/irq-gic.c:1019:33: note: each undeclared identifier is reported only once for each function it appears in
> 
> vim +/gic_set_affinity +1019 drivers/irqchip/irq-gic.c
> 
>   1013		gic->chip = gic_chip;
>   1014		gic->chip.name = kasprintf(GFP_KERNEL, "GIC-%d", gic_nr);
>   1015	
>   1016		/* Initialize irq_chip */
>   1017		if (gic_nr == 0) {
>   1018			if (IS_ENABLED(CONFIG_SMP))
>> 1019				gic->chip.irq_set_affinity = gic_set_affinity;
>   1020	
>   1021			if (static_key_true(&supports_deactivate)) {
>   1022				gic->chip.irq_mask = gic_eoimode1_mask_irq;
> 

Thanks. Yes if CONFIG_SMP is not defined then I see this error. I had
naively assumed that IS_ENABLED() would handle this for me. I will fix this.

Cheers
Jon