From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 02/10] drm/i915: Use insert_page for pwrite_fast Date: Tue, 22 Dec 2015 10:44:57 +0000 Message-ID: <567929A9.6020707@linux.intel.com> References: <1450765253-32104-1-git-send-email-ankitprasad.r.sharma@intel.com> <1450765253-32104-3-git-send-email-ankitprasad.r.sharma@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id A6A0E6E59D for ; Tue, 22 Dec 2015 02:44:59 -0800 (PST) In-Reply-To: <1450765253-32104-3-git-send-email-ankitprasad.r.sharma@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: ankitprasad.r.sharma@intel.com, intel-gfx@lists.freedesktop.org Cc: akash.goel@intel.com, shashidhar.hiremath@intel.com List-Id: intel-gfx@lists.freedesktop.org CkhpLAoKT24gMjIvMTIvMTUgMDY6MjAsIGFua2l0cHJhc2FkLnIuc2hhcm1hQGludGVsLmNvbSB3 cm90ZToKPiBGcm9tOiBBbmtpdHByYXNhZCBTaGFybWEgPGFua2l0cHJhc2FkLnIuc2hhcm1hQGlu dGVsLmNvbT4KPgo+IEluIHB3cml0ZV9mYXN0LCBtYXAgYW4gb2JqZWN0IHBhZ2UgYnkgcGFnZSBp ZiBvYmpfZ2d0dF9waW4gZmFpbHMuIEZpcnN0LAo+IHdlIHRyeSBhIG5vbmJsb2NraW5nIHBpbiBm b3IgdGhlIHdob2xlIG9iamVjdCAoc2luY2UgdGhhdCBpcyBmYXN0ZXN0IGlmCj4gcmV1c2VkKSwg dGhlbiBmYWlsaW5nIHRoYXQgd2UgdHJ5IHRvIGdyYWIgb25lIHBhZ2UgaW4gdGhlIG1hcHBhYmxl Cj4gYXBlcnR1cmUuIEl0IGFsc28gYWxsb3dzIHVzIHRvIGhhbmRsZSBvYmplY3RzIGxhcmdlciB0 aGFuIHRoZSBtYXBwYWJsZQo+IGFwZXJ0dXJlIChlLmcuIGlmIHdlIG5lZWQgdG8gcHdyaXRlIHdp dGggdkdQVSByZXN0cmljdGluZyB0aGUgYXBlcnR1cmUKPiB0byBhIG1lYXNlbHkgOE1pQiBvciBz b21ldGhpbmcgbGlrZSB0aGF0KS4KPgo+IHYyOiBQaW4gcGFnZXMgYmVmb3JlIHN0YXJ0aW5nIHB3 cml0ZSwgQ29tYmluZWQgZHVwbGljYXRlIGxvb3BzIChDaHJpcykKPgo+IHYzOiBDb21iaW5lZCBs b29wcyBiYXNlZCBvbiBsb2NhbCBwYXRjaCBieSBDaHJpcyAoQ2hyaXMpCj4KPiB2NDogQWRkZWQg aTkxNSB3cmFwcGVyIGZ1bmN0aW9uIGZvciBkcm1fbW1faW5zZXJ0X25vZGVfaW5fcmFuZ2UgKENo cmlzKQo+Cj4gdjU6IFJlbmFtZWQgd3JhcHBlciBmdW5jdGlvbiBmb3IgZHJtX21tX2luc2VydF9u b2RlX2luX3JhbmdlIChDaHJpcykKPgo+IHY1OiBBZGRlZCB3cmFwcGVyIGZvciBkcm1fbW1fcmVt b3ZlX25vZGUoKSAoQ2hyaXMpCj4KPiB2NjogQWRkZWQgZ2V0X3BhZ2VzIGNhbGwgYmVmb3JlIHBp bm5pbmcgdGhlIHBhZ2VzIChUdnJ0a28pCj4gQWRkZWQgcmVtb3ZlX21hcHBhYmxlX25vZGUoKSB3 cmFwcGVyIGZvciBkcm1fbW1fcmVtb3ZlX25vZGUoKSAoQ2hyaXMpCj4KPiBTaWduZWQtb2ZmLWJ5 OiBBbmtpdHByYXNhZCBTaGFybWEgPGFua2l0cHJhc2FkLnIuc2hhcm1hQGludGVsLmNvbT4KPiBT aWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiAt LS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgfCA5NCArKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLQo+ICAgMSBmaWxlIGNoYW5nZWQsIDcyIGluc2Vy dGlvbnMoKyksIDIyIGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZ2VtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gaW5k ZXggYmY3ZjIwMy4uZjExZWM4OSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X2dlbS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+IEBAIC02 MSw2ICs2MSwyMyBAQCBzdGF0aWMgYm9vbCBjcHVfd3JpdGVfbmVlZHNfY2xmbHVzaChzdHJ1Y3Qg ZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqKQo+ICAgCXJldHVybiBvYmotPnBpbl9kaXNwbGF5Owo+ ICAgfQo+Cj4gK3N0YXRpYyBpbnQKPiAraW5zZXJ0X21hcHBhYmxlX25vZGUoc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmk5MTUsCj4gKyAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCBkcm1fbW1f bm9kZSAqbm9kZSkKPiArewo+ICsJcmV0dXJuIGRybV9tbV9pbnNlcnRfbm9kZV9pbl9yYW5nZV9n ZW5lcmljKCZpOTE1LT5ndHQuYmFzZS5tbSwgbm9kZSwKPiArCQkJCQkJICAgUEFHRV9TSVpFLCAw LCAwLAoKSXQgZG9lcyBub3QgbG9vayBpZGVhbCB0aGF0IHRoZSBmdW5jdGlvbiBuYW1lIGlzIHNh eWluZyBpdCB3aWxsIGluc2VydCBhIApub2RlIGFuZCB0aGVuIGl0IG9ubHkgaW5zZXJ0cyBvbmUg cGFnZS4KCkluIHRoYXQgcmVzcGVjdCBwcmV2aW91cyB2ZXJzaW9uIGxvb2tlZCBiZXR0ZXIgdG8g bWUgYnV0IHNpbmNlIGl0IGlzIApzdGF0aWMgYW5kIHNpbmdsZSB1c2UgLSB3aGF0ZXZlciAtIHRo aXMgaGFzIGJlZW4gZHJhZ2dpbmcgZm9yIHRvbyBsb25nLgoKPiArCQkJCQkJICAgMCwgaTkxNS0+ Z3R0Lm1hcHBhYmxlX2VuZCwKPiArCQkJCQkJICAgRFJNX01NX1NFQVJDSF9ERUZBVUxULAo+ICsJ CQkJCQkgICBEUk1fTU1fQ1JFQVRFX0RFRkFVTFQpOwo+ICt9Cj4gKwo+ICtzdGF0aWMgdm9pZAo+ ICtyZW1vdmVfbWFwcGFibGVfbm9kZShzdHJ1Y3QgZHJtX21tX25vZGUgKm5vZGUpCj4gK3sKPiAr CWRybV9tbV9yZW1vdmVfbm9kZShub2RlKTsKPiArfQo+ICsKPiAgIC8qIHNvbWUgYm9va2tlZXBp bmcgKi8KPiAgIHN0YXRpYyB2b2lkIGk5MTVfZ2VtX2luZm9fYWRkX29iaihzdHJ1Y3QgZHJtX2k5 MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gICAJCQkJICBzaXplX3Qgc2l6ZSkKPiBAQCAtNzYwLDIw ICs3NzcsMzQgQEAgZmFzdF91c2VyX3dyaXRlKHN0cnVjdCBpb19tYXBwaW5nICptYXBwaW5nLAo+ ICAgICogdXNlciBpbnRvIHRoZSBHVFQsIHVuY2FjaGVkLgo+ICAgICovCj4gICBzdGF0aWMgaW50 Cj4gLWk5MTVfZ2VtX2d0dF9wd3JpdGVfZmFzdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ICtp OTE1X2dlbV9ndHRfcHdyaXRlX2Zhc3Qoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUsCj4g ICAJCQkgc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaiwKPiAgIAkJCSBzdHJ1Y3QgZHJt X2k5MTVfZ2VtX3B3cml0ZSAqYXJncywKPiAgIAkJCSBzdHJ1Y3QgZHJtX2ZpbGUgKmZpbGUpCj4g ICB7Cj4gLQlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBkZXYtPmRldl9wcml2 YXRlOwo+IC0Jc3NpemVfdCByZW1haW47Cj4gLQlsb2ZmX3Qgb2Zmc2V0LCBwYWdlX2Jhc2U7Cj4g KwlzdHJ1Y3QgZHJtX21tX25vZGUgbm9kZTsKPiArCXVpbnQ2NF90IHJlbWFpbiwgb2Zmc2V0Owo+ ICAgCWNoYXIgX191c2VyICp1c2VyX2RhdGE7Cj4gLQlpbnQgcGFnZV9vZmZzZXQsIHBhZ2VfbGVu Z3RoLCByZXQ7Cj4gKwlpbnQgcmV0Owo+Cj4gICAJcmV0ID0gaTkxNV9nZW1fb2JqX2dndHRfcGlu KG9iaiwgMCwgUElOX01BUFBBQkxFIHwgUElOX05PTkJMT0NLKTsKPiAtCWlmIChyZXQpCj4gLQkJ Z290byBvdXQ7Cj4gKwlpZiAocmV0KSB7Cj4gKwkJbWVtc2V0KCZub2RlLCAwLCBzaXplb2Yobm9k ZSkpOwo+ICsJCXJldCA9IGluc2VydF9tYXBwYWJsZV9ub2RlKGk5MTUsICZub2RlKTsKPiArCQlp ZiAocmV0KQo+ICsJCQlnb3RvIG91dDsKPiArCj4gKwkJcmV0ID0gaTkxNV9nZW1fb2JqZWN0X2dl dF9wYWdlcyhvYmopOwo+ICsJCWlmIChyZXQpIHsKPiArCQkJcmVtb3ZlX21hcHBhYmxlX25vZGUo Jm5vZGUpOwo+ICsJCQlnb3RvIG91dDsKPiArCQl9Cj4gKwo+ICsJCWk5MTVfZ2VtX29iamVjdF9w aW5fcGFnZXMob2JqKTsKPiArCX0gZWxzZSB7Cj4gKwkJbm9kZS5zdGFydCA9IGk5MTVfZ2VtX29i al9nZ3R0X29mZnNldChvYmopOwo+ICsJCW5vZGUuYWxsb2NhdGVkID0gZmFsc2U7Cj4gKwl9Cj4K PiAgIAlyZXQgPSBpOTE1X2dlbV9vYmplY3Rfc2V0X3RvX2d0dF9kb21haW4ob2JqLCB0cnVlKTsK PiAgIAlpZiAocmV0KQo+IEBAIC03ODMsMzEgKzgxNCwzOSBAQCBpOTE1X2dlbV9ndHRfcHdyaXRl X2Zhc3Qoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAgIAlpZiAocmV0KQo+ICAgCQlnb3RvIG91 dF91bnBpbjsKPgo+IC0JdXNlcl9kYXRhID0gdG9fdXNlcl9wdHIoYXJncy0+ZGF0YV9wdHIpOwo+ IC0JcmVtYWluID0gYXJncy0+c2l6ZTsKPiAtCj4gLQlvZmZzZXQgPSBpOTE1X2dlbV9vYmpfZ2d0 dF9vZmZzZXQob2JqKSArIGFyZ3MtPm9mZnNldDsKPiAtCj4gICAJaW50ZWxfZmJfb2JqX2ludmFs aWRhdGUob2JqLCBPUklHSU5fR1RUKTsKPiArCW9iai0+ZGlydHkgPSB0cnVlOwo+Cj4gLQl3aGls ZSAocmVtYWluID4gMCkgewo+ICsJdXNlcl9kYXRhID0gdG9fdXNlcl9wdHIoYXJncy0+ZGF0YV9w dHIpOwo+ICsJb2Zmc2V0ID0gYXJncy0+b2Zmc2V0Owo+ICsJcmVtYWluID0gYXJncy0+c2l6ZTsK PiArCXdoaWxlIChyZW1haW4pIHsKPiAgIAkJLyogT3BlcmF0aW9uIGluIHRoaXMgcGFnZQo+ICAg CQkgKgo+ICAgCQkgKiBwYWdlX2Jhc2UgPSBwYWdlIG9mZnNldCB3aXRoaW4gYXBlcnR1cmUKPiAg IAkJICogcGFnZV9vZmZzZXQgPSBvZmZzZXQgd2l0aGluIHBhZ2UKPiAgIAkJICogcGFnZV9sZW5n dGggPSBieXRlcyB0byBjb3B5IGZvciB0aGlzIHBhZ2UKPiAgIAkJICovCj4gLQkJcGFnZV9iYXNl ID0gb2Zmc2V0ICYgUEFHRV9NQVNLOwo+IC0JCXBhZ2Vfb2Zmc2V0ID0gb2Zmc2V0X2luX3BhZ2Uo b2Zmc2V0KTsKPiAtCQlwYWdlX2xlbmd0aCA9IHJlbWFpbjsKPiAtCQlpZiAoKHBhZ2Vfb2Zmc2V0 ICsgcmVtYWluKSA+IFBBR0VfU0laRSkKPiAtCQkJcGFnZV9sZW5ndGggPSBQQUdFX1NJWkUgLSBw YWdlX29mZnNldDsKPiAtCj4gKwkJdTMyIHBhZ2VfYmFzZSA9IG5vZGUuc3RhcnQ7CgpDb21waWxl ciBkb2VzIG5vdCBjb21wbGFpbiBhYm91dCBwb3NzaWJsZSB0cnVuY2F0aW9uIGhlcmU/IEkgd291 bGQgCmNoYW5nZSBpdCB0byBhIHR5cGUgb2YgZXF1aXZhbGVudCB3aWR0aCBqdXN0IGluIGNhc2Uu IEV2ZW4gYmVmb3JlIGl0IHdhcyAKbG9mZl90LgoKPiArCQl1bnNpZ25lZCBwYWdlX29mZnNldCA9 IG9mZnNldF9pbl9wYWdlKG9mZnNldCk7Cj4gKwkJdW5zaWduZWQgcGFnZV9sZW5ndGggPSBQQUdF X1NJWkUgLSBwYWdlX29mZnNldDsKPiArCQlwYWdlX2xlbmd0aCA9IHJlbWFpbiA8IHBhZ2VfbGVu Z3RoID8gcmVtYWluIDogcGFnZV9sZW5ndGg7Cj4gKwkJaWYgKG5vZGUuYWxsb2NhdGVkKSB7Cj4g KwkJCXdtYigpOwo+ICsJCQlpOTE1LT5ndHQuYmFzZS5pbnNlcnRfcGFnZSgmaTkxNS0+Z3R0LmJh c2UsCj4gKwkJCQkJCSAgIGk5MTVfZ2VtX29iamVjdF9nZXRfZG1hX2FkZHJlc3Mob2JqLCBvZmZz ZXQgPj4gUEFHRV9TSElGVCksCj4gKwkJCQkJCSAgIG5vZGUuc3RhcnQsCj4gKwkJCQkJCSAgIEk5 MTVfQ0FDSEVfTk9ORSwKPiArCQkJCQkJICAgMCk7Cj4gKwkJCXdtYigpOwo+ICsJCX0gZWxzZSB7 Cj4gKwkJCXBhZ2VfYmFzZSArPSBvZmZzZXQgJiBQQUdFX01BU0s7Cj4gKwkJfQo+ICAgCQkvKiBJ ZiB3ZSBnZXQgYSBmYXVsdCB3aGlsZSBjb3B5aW5nIGRhdGEsIHRoZW4gKHByZXN1bWFibHkpIG91 cgo+ICAgCQkgKiBzb3VyY2UgcGFnZSBpc24ndCBhdmFpbGFibGUuICBSZXR1cm4gdGhlIGVycm9y IGFuZCB3ZSdsbAo+ICAgCQkgKiByZXRyeSBpbiB0aGUgc2xvdyBwYXRoLgo+ICAgCQkgKi8KPiAt CQlpZiAoZmFzdF91c2VyX3dyaXRlKGRldl9wcml2LT5ndHQubWFwcGFibGUsIHBhZ2VfYmFzZSwK PiArCQlpZiAoZmFzdF91c2VyX3dyaXRlKGk5MTUtPmd0dC5tYXBwYWJsZSwgcGFnZV9iYXNlLAo+ ICAgCQkJCSAgICBwYWdlX29mZnNldCwgdXNlcl9kYXRhLCBwYWdlX2xlbmd0aCkpIHsKPiAgIAkJ CXJldCA9IC1FRkFVTFQ7Cj4gICAJCQlnb3RvIG91dF9mbHVzaDsKPiBAQCAtODIxLDcgKzg2MCwx OCBAQCBpOTE1X2dlbV9ndHRfcHdyaXRlX2Zhc3Qoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAg IG91dF9mbHVzaDoKPiAgIAlpbnRlbF9mYl9vYmpfZmx1c2gob2JqLCBmYWxzZSwgT1JJR0lOX0dU VCk7Cj4gICBvdXRfdW5waW46Cj4gLQlpOTE1X2dlbV9vYmplY3RfZ2d0dF91bnBpbihvYmopOwo+ ICsJaWYgKG5vZGUuYWxsb2NhdGVkKSB7Cj4gKwkJd21iKCk7Cj4gKwkJaTkxNS0+Z3R0LmJhc2Uu Y2xlYXJfcmFuZ2UoJmk5MTUtPmd0dC5iYXNlLAo+ICsJCQkJbm9kZS5zdGFydCwgbm9kZS5zaXpl LAo+ICsJCQkJdHJ1ZSk7Cj4gKwkJcmVtb3ZlX21hcHBhYmxlX25vZGUoJm5vZGUpOwo+ICsJCWk5 MTVfZ2VtX29iamVjdF91bnBpbl9wYWdlcyhvYmopOwo+ICsJCWk5MTVfZ2VtX29iamVjdF9wdXRf cGFnZXMob2JqKTsKPiArCX0KPiArCWVsc2Ugewo+ICsJCWk5MTVfZ2VtX29iamVjdF9nZ3R0X3Vu cGluKG9iaik7Cj4gKwl9Cj4gICBvdXQ6Cj4gICAJcmV0dXJuIHJldDsKPiAgIH0KPiBAQCAtMTA4 Niw3ICsxMTM2LDcgQEAgaTkxNV9nZW1fcHdyaXRlX2lvY3RsKHN0cnVjdCBkcm1fZGV2aWNlICpk ZXYsIHZvaWQgKmRhdGEsCj4gICAJaWYgKG9iai0+dGlsaW5nX21vZGUgPT0gSTkxNV9USUxJTkdf Tk9ORSAmJgo+ICAgCSAgICBvYmotPmJhc2Uud3JpdGVfZG9tYWluICE9IEk5MTVfR0VNX0RPTUFJ Tl9DUFUgJiYKPiAgIAkgICAgY3B1X3dyaXRlX25lZWRzX2NsZmx1c2gob2JqKSkgewo+IC0JCXJl dCA9IGk5MTVfZ2VtX2d0dF9wd3JpdGVfZmFzdChkZXYsIG9iaiwgYXJncywgZmlsZSk7Cj4gKwkJ cmV0ID0gaTkxNV9nZW1fZ3R0X3B3cml0ZV9mYXN0KGRldl9wcml2LCBvYmosIGFyZ3MsIGZpbGUp Owo+ICAgCQkvKiBOb3RlIHRoYXQgdGhlIGd0dCBwYXRocyBtaWdodCBmYWlsIHdpdGggbm9uLXBh Z2UtYmFja2VkIHVzZXIKPiAgIAkJICogcG9pbnRlcnMgKGUuZy4gZ3R0IG1hcHBpbmdzIHdoZW4g bW92aW5nIGRhdGEgYmV0d2Vlbgo+ICAgCQkgKiB0ZXh0dXJlcykuIEZhbGxiYWNrIHRvIHRoZSBz aG1lbSBwYXRoIGluIHRoYXQgY2FzZS4gKi8KPgoKUmVnYXJkcywKClR2cnRrbwoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcg bGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK