From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH RFC 01/31] xen/public: Export featureset information in the public API Date: Tue, 22 Dec 2015 09:28:49 -0700 Message-ID: <5679885102000078000C25AD@prv-mh.provo.novell.com> References: <1450301073-28191-1-git-send-email-andrew.cooper3@citrix.com> <1450301073-28191-2-git-send-email-andrew.cooper3@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1450301073-28191-2-git-send-email-andrew.cooper3@citrix.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper Cc: Tim Deegan , Ian Campbell , Xen-devel List-Id: xen-devel@lists.xenproject.org >>> On 16.12.15 at 22:24, wrote: > +/* VIA/Cyrix/Centaur-defined CPU features, CPUID level 0xC0000001, FSMAX+2 */ > +#define X86_FEATURE_XSTORE ((FSMAX+1)*32+ 2) /* on-CPU RNG present (xstore insn) */ > +#define X86_FEATURE_XSTORE_EN ((FSMAX+1)*32+ 3) /* on-CPU RNG enabled */ > +#define X86_FEATURE_XCRYPT ((FSMAX+1)*32+ 6) /* on-CPU crypto (xcrypt insn) */ > +#define X86_FEATURE_XCRYPT_EN ((FSMAX+1)*32+ 7) /* on-CPU crypto enabled */ > +#define X86_FEATURE_ACE2 ((FSMAX+1)*32+ 8) /* Advanced Cryptography Engine v2 */ > +#define X86_FEATURE_ACE2_EN ((FSMAX+1)*32+ 9) /* ACE v2 enabled */ > +#define X86_FEATURE_PHE ((FSMAX+1)*32+10) /* PadLock Hash Engine */ > +#define X86_FEATURE_PHE_EN ((FSMAX+1)*32+11) /* PHE enabled */ > +#define X86_FEATURE_PMM ((FSMAX+1)*32+12) /* PadLock Montgomery Multiplier */ > +#define X86_FEATURE_PMM_EN ((FSMAX+1)*32+13) /* PMM enabled */ None of these get consumed anywhere - if you already touch this code, just drop all of them. > +/* > + * CPUID leaf shorthand: > + * - optional 'e', Extended (0x8xxxxxxx) > + * - leaf, uppercase hex > + * - register, lowercase > + * - optional subleaf, uppercase hex > + */ > +#define XEN_FEATURESET_1d 0 /* 0x00000001.edx */ > +#define XEN_FEATURESET_1c 1 /* 0x00000001.ecx */ > +#define XEN_FEATURESET_e1d 2 /* 0x80000001.edx */ > +#define XEN_FEATURESET_e1c 3 /* 0x80000001.ecx */ > +#define XEN_FEATURESET_Da1 4 /* 0x0000000d:1.eax */ > +#define XEN_FEATURESET_7b0 5 /* 0x00000007:0.ebx */ This ends up being pretty cryptic. > +#define XEN_NR_FEATURESET_ENTRIES (XEN_FEATURESET_7b0 + 1) This shouldn't be exposed, as it will necessarily change sooner or later. Jan