From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755135AbbLVRnV (ORCPT ); Tue, 22 Dec 2015 12:43:21 -0500 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:26937 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753627AbbLVRnR (ORCPT ); Tue, 22 Dec 2015 12:43:17 -0500 Subject: Re: [PATCH] null_blk: fix use-after-free error To: Mike Krinkin References: <1450173400-18287-1-git-send-email-krinkin.m.u@gmail.com> CC: , , From: Jens Axboe Message-ID: <56798BAC.5010208@fb.com> Date: Tue, 22 Dec 2015 10:43:08 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1450173400-18287-1-git-send-email-krinkin.m.u@gmail.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.54.13] X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-12-22_13:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/15/2015 02:56 AM, Mike Krinkin wrote: > blk_end_request_all may free request, so we need to save > request_queue pointer before blk_end_request_all call. > > The problem was introduced in commit cf8ecc5a8455266f8d51 > ("null_blk: guarantee device restart in all irq modes") > and causes general protection fault with slab poisoning > enabled. > > Fixes: cf8ecc5a8455266f8d51 ("null_blk: guarantee device > restart in all irq modes") Added for 4.4, thanks. -- Jens Axboe