From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933155AbbLVX3D (ORCPT ); Tue, 22 Dec 2015 18:29:03 -0500 Received: from mail-by2on0088.outbound.protection.outlook.com ([207.46.100.88]:30387 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932205AbbLVX27 (ORCPT ); Tue, 22 Dec 2015 18:28:59 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=David.Daney@caviumnetworks.com; Message-ID: <5679DCB0.4040700@caviumnetworks.com> Date: Tue, 22 Dec 2015 15:28:48 -0800 From: David Daney User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Will Deacon CC: David Daney , , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , , , Marc Zyngier , Bjorn Helgaas , , Arnd Bergmann , David Daney Subject: Re: [PATCH 2/2] pci, pcie-thunder-pem: Add PCIe host driver for ThunderX processors. References: <1450749222-15966-1-git-send-email-ddaney.cavm@gmail.com> <1450749222-15966-3-git-send-email-ddaney.cavm@gmail.com> <20151222100352.GC32623@arm.com> <5679A1E9.3050902@caviumnetworks.com> In-Reply-To: <5679A1E9.3050902@caviumnetworks.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [64.2.3.194] X-ClientProxiedBy: BLUPR07CA077.namprd07.prod.outlook.com (25.160.24.32) To DM3PR07MB2140.namprd07.prod.outlook.com (25.164.4.146) X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2140;2:oPUcw4RJ+EJAlVbTPG+xuROTJ3TP64gLFm6cHK+5Uo51vS97gYCXv4GelbD4yOR4bRD0f+brmAX0yTHzFw6VwPBZND2H3Mo+IwF+cw26KYiGndzQMYr0ALZYQHQWgN8Y2Lbewg05fmDR0w5zzncTEA==;3:vQh7JkNQ0BGD9AzrgT/IpXEeyfNcF6fW/mr4+gNTk/fGn9TSjqkCiBo9lZqjmw0PzP+Tub+e8IK2L0h5JriTFkNC3Z2WLHS46gVh4SLJRpXdH5teeERhGYhSub9eRfTo;25:asSC6RmWEGaLlADcuajtwTmYyMCoM5dicKcGtfe5hFbtJEEc742DPKe642ZpN3pmwTL6UVkqnqbLCSiCESv3x/7mCBn0GurU7HCi1yJmFBFd7Iym/sWAQwufnfIamZg5w81caDXB23kh+tQDp40eGxllfQ6g2GXfW7NZxrrC+Vd6qqALCaPxqTuBiQPBzVVdsAOuM8iFd5ZXy5PtZMg+lIhX/6Ag9o3T+wLomsR0yib6JdDWwY5VqxX8t769nefAHXLe1r0ReVznDnSIuUKa4A== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM3PR07MB2140; X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2140;20:4Gu0ST2o7EgDfiHF8JDeunZMvIGWLYeZ3Iq6uU6DfZ52FnA71tCUxAy+pfs9v+1G84XfzqqgorCEMTLkCvU5X5yjey9YSSdAaUr0b91RxfuAklQ6xUi6je0asbuXBRMgmq+iPOv8+6w8lgKhH8aXRQHi7SXrwt4uvKu+t0PTGjbBWSCQJNX8xFs22SBYapPW2C68gl25EIvnY+qSaNlAgdinboCvpfBnG4qosQakif1vraenSuJdd3vKLTK8/RxeS2UW+93s1X1lo3MPlI22ujTw2p7fXsa7B5nzBTIV5AvdxV64X8nH6tb6DqsHaYS/LHirpb7tWIbInTHdEdHmBuA+7sKi8K690PLsBVwtkpe9e5vyQ6jXtIaha7wzeBQoP+D2G08e6tVDb6r0Lqno0DC7NOYgQL5yaap4tRuCCh/36gO5K6TFzP6TJWab99b9Cqlewe6EPUehEu21uB9IrxjEF+QUZBEe8tEJ/OMRYwqAncnjjDt8I8jvCPbp6Hh45HGLA5hSbyQLRGuows5wzyEhQ71hIZoZSq9sT9mJ0fmHU+I1WIYfN/5oyeyHFNNtz0qXaQVXZTbbxMYlEnIPYDBAacsVTLRf/+dGb3rq82o= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(5005006)(8121501046)(3002001)(10201501046);SRVR:DM3PR07MB2140;BCL:0;PCL:0;RULEID:;SRVR:DM3PR07MB2140; X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2140;4:1HSZWlDmLRc7KL6U/+rm+vupGd1v/rp5WKreF6pNKiLX10HMiL4mbm3lXwCKTe0JLIqbJco12foIRMzDTtKOWuhaHPVinZd9YcVqC1V6Q2xGQJHXsv5+7Dt7lwFZgVUqVAjwEW4+eks6jlEhtIRtH03X+ZVXqpmhgowDRU7fD92SUjpgAgoTIh3V3XeUxJbLYQk9EI8cFE+8QWoztedLkfnd0U+UMqfULLiqMFTyJ7aSaC10vZJhgfDkIMKKIZ+MXrwzwwk3QhFQ8N110boWlBHzc4Myl8FdXziFBlbrYrfA/rT/00vcpf50ukqF4Xv0OsPg+BQuhcHhu7Uud2V0csuASoukiCq6i5VgCHHaWfWA6RUc1pwEU/S15/lD35IK X-Forefront-PRVS: 0798146F16 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(479174004)(199003)(189002)(24454002)(377454003)(80316001)(33656002)(2950100001)(92566002)(19580405001)(5008740100001)(87976001)(101416001)(19580395003)(69596002)(110136002)(65816999)(23756003)(5001960100002)(189998001)(77096005)(64126003)(81156007)(97736004)(4001350100001)(122386002)(230700001)(105586002)(47776003)(1096002)(230783001)(59896002)(36756003)(106356001)(586003)(42186005)(40100003)(93886004)(53416004)(3846002)(83506001)(6116002)(50986999)(5004730100002)(65806001)(65956001)(54356999)(87266999)(76176999)(66066001)(50466002);DIR:OUT;SFP:1101;SCL:1;SRVR:DM3PR07MB2140;H:dl.caveonetworks.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1;DM3PR07MB2140;23:0wrBMMcFeCqcNQT48CsdVjYjZbnN1/Kv2qx6plp?= =?iso-8859-1?Q?MjEQTYzPt1iAufryen0Hogs/LvORfGHXBhgbWIrq85ue06AH5vLPOCUuux?= =?iso-8859-1?Q?dVGWBA1sqxxSx6d34j9dr5/D8Znt39TGmFPN22yA9sEmgsrQAZVOtnLVd9?= =?iso-8859-1?Q?iXneYSVcQchWwcSjxQ0Ci9hqLTvQTiERWnzP0hasUSdsPTcaRJT0dUHTD6?= =?iso-8859-1?Q?byFTmN40tOUQDz/PnYBOqCUaptbUBd9kuagTzpg7HEVQGh3krzQvVRQPiC?= =?iso-8859-1?Q?I+Vpahgmq0TL5ouIIbC7Gzwwqz3WQ5Djf4C/8JpVDiQZsvGJFuk+DmYq3a?= =?iso-8859-1?Q?kB+Wne6vX7dmB8tiv3o3mzHjK1G5rUQySInv2efc3mBoIzQ7YreypZg0oE?= =?iso-8859-1?Q?XhCQTcu/7eJSYnzg4dqYjxKVvQUz9qMAXNRspROTmiB3lZKcqEogHHGh/Q?= =?iso-8859-1?Q?S4VH5K5HRbeIYsEkoClkpAJz/U6dpOfN0HAjkQaFol7kf3dMPcQlLwVZr8?= =?iso-8859-1?Q?To/bUMjsWtIo99G+4lR8n/3KQ1HvOldzqIDGdt7fZfWJWQ8U7ez5GjGYov?= =?iso-8859-1?Q?34nB4QodnB4rkNyvh/KDhuBy5/oB62rBLDbf9n+uztprD3PaacMvW61taF?= =?iso-8859-1?Q?g7Jjc9diNWxjjEMOyB7qL3/kjQjZQcGSK/lTtw6A7BLx8JBIPMkEKa/d8m?= =?iso-8859-1?Q?/mGWQd+WDhyVPn4Rpi4Gt3xs6IfnIMAvmyS+EmYj/jduBo6FfK8PNyGrbt?= =?iso-8859-1?Q?e4xb2PHaSJYBoymyrLfjbpVgDpJ07yF7pif7dzpCNngfXvF9r2/+YY6xMC?= =?iso-8859-1?Q?8lELpbBqDVZjqhzXqHhN92vPbaKtJPWqy8kjRK2E0UJqRUWZOUDb6Fi47Z?= =?iso-8859-1?Q?5LChCUYRBLLYWe1k1J94rKrPTSnk+16sE7IDBdVSboBhWs6F9CO9Qt3Jes?= =?iso-8859-1?Q?HWrVhCQopV7wExvAlRUzXUZWsCB3SfXuQYCbkKhXg7REWIhmX/BZNvd+73?= =?iso-8859-1?Q?yGzSSsUC/MRBeMetPIKWYXSSMtryk6NWX24s8xybLJDycTGIeOuZKduoQ1?= =?iso-8859-1?Q?yaKlEN9unWvZJmDEuZ3K+pflO8XqcJzI9OxqWs3wA9vCC/bZs+a5QGh0lz?= =?iso-8859-1?Q?Vtcg7fxmeRx59SnMkcR/0wPRk9342fZdcqQ/MBGcxWSxbywsMsEbhZIaxE?= =?iso-8859-1?Q?XAsaiHXJSnDgnTbwq91iRNcRekDXm1Nj1g3V+t6+sdC+H3yaUWcgZk42P2?= =?iso-8859-1?Q?GphyUN6XKDMOi9wNA/t+WMuYDe0Fg8SksZaiwr86ymE29pZbrpjyKrA7GA?= =?iso-8859-1?Q?lL92F210iw0UyhaF2lDZKna+0vQdDcGh/bYBhyO7totvgRQ39ztvzM+Nao?= =?iso-8859-1?Q?pCcjhV8xZwkQibISqiQRzIQu0s8hT?= X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2140;5:F9CcBSXBPCyRb6MiKdnZcqwqwvwcpjGRHDTwvH7A0NLtzXhEkAEw5yq/+CFWV5Lm1N2vS6o2K7Ke99APcfoymEe+yst3nYiy2ClEoGWHflFnqetkKIUBiQ0qYdQ3q73F2cDYZV3GvyHx4DwcBd0oSg==;24:oFw+hSXeXB31/bmsmCAGB8MCGuG1zXV7BzHr2OuOGoDc5shX5TFYDUqj7qMuhKvJnUWqpbWbQbrtDy+dd0TV19+jrR0XHCcAbWEKVCuXdlM= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Dec 2015 23:28:52.5414 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR07MB2140 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/22/2015 11:18 AM, David Daney wrote: > On 12/22/2015 02:03 AM, Will Deacon wrote: >> On Mon, Dec 21, 2015 at 05:53:42PM -0800, David Daney wrote: >>> From: David Daney [...] >>> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig >>> index f131ba9..16ed9c3 100644 >>> --- a/drivers/pci/host/Kconfig >>> +++ b/drivers/pci/host/Kconfig >>> @@ -172,4 +172,10 @@ config PCI_HISI >>> help >>> Say Y here if you want PCIe controller support on HiSilicon >>> HIP05 SoC >>> >>> +config PCIE_HOST_THUNDER_PEM >>> + bool "Cavium Thunder PCIe controller to off-chip devices" >>> + depends on PCI_HOST_GENERIC && ARM64 >> >> || COMPILE_TEST ? >> >> (or does the use of writeq get you? If so, maybe COMPILE_TEST && 64BIT) > > Yes, we must use writeq in the driver, I will change it to > ||(COMPILE_TEST && 64BIT) > Actually, it turns out that this is not easily done. For x86, it appears difficult to include asm-generic/pci-bridge.h which includes the needed definition of PCI_PROBE_ONLY. So I think it is not worth supporting COMPILE_TEST David Daney From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Daney Subject: Re: [PATCH 2/2] pci, pcie-thunder-pem: Add PCIe host driver for ThunderX processors. Date: Tue, 22 Dec 2015 15:28:48 -0800 Message-ID: <5679DCB0.4040700@caviumnetworks.com> References: <1450749222-15966-1-git-send-email-ddaney.cavm@gmail.com> <1450749222-15966-3-git-send-email-ddaney.cavm@gmail.com> <20151222100352.GC32623@arm.com> <5679A1E9.3050902@caviumnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5679A1E9.3050902@caviumnetworks.com> Sender: linux-pci-owner@vger.kernel.org To: Will Deacon Cc: David Daney , linux-kernel@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Marc Zyngier , Bjorn Helgaas , linux-pci@vger.kernel.org, Arnd Bergmann , David Daney List-Id: devicetree@vger.kernel.org On 12/22/2015 11:18 AM, David Daney wrote: > On 12/22/2015 02:03 AM, Will Deacon wrote: >> On Mon, Dec 21, 2015 at 05:53:42PM -0800, David Daney wrote: >>> From: David Daney [...] >>> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig >>> index f131ba9..16ed9c3 100644 >>> --- a/drivers/pci/host/Kconfig >>> +++ b/drivers/pci/host/Kconfig >>> @@ -172,4 +172,10 @@ config PCI_HISI >>> help >>> Say Y here if you want PCIe controller support on HiSilicon >>> HIP05 SoC >>> >>> +config PCIE_HOST_THUNDER_PEM >>> + bool "Cavium Thunder PCIe controller to off-chip devices" >>> + depends on PCI_HOST_GENERIC && ARM64 >> >> || COMPILE_TEST ? >> >> (or does the use of writeq get you? If so, maybe COMPILE_TEST && 64BIT) > > Yes, we must use writeq in the driver, I will change it to > ||(COMPILE_TEST && 64BIT) > Actually, it turns out that this is not easily done. For x86, it appears difficult to include asm-generic/pci-bridge.h which includes the needed definition of PCI_PROBE_ONLY. So I think it is not worth supporting COMPILE_TEST David Daney From mboxrd@z Thu Jan 1 00:00:00 1970 From: ddaney@caviumnetworks.com (David Daney) Date: Tue, 22 Dec 2015 15:28:48 -0800 Subject: [PATCH 2/2] pci, pcie-thunder-pem: Add PCIe host driver for ThunderX processors. In-Reply-To: <5679A1E9.3050902@caviumnetworks.com> References: <1450749222-15966-1-git-send-email-ddaney.cavm@gmail.com> <1450749222-15966-3-git-send-email-ddaney.cavm@gmail.com> <20151222100352.GC32623@arm.com> <5679A1E9.3050902@caviumnetworks.com> Message-ID: <5679DCB0.4040700@caviumnetworks.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 12/22/2015 11:18 AM, David Daney wrote: > On 12/22/2015 02:03 AM, Will Deacon wrote: >> On Mon, Dec 21, 2015 at 05:53:42PM -0800, David Daney wrote: >>> From: David Daney [...] >>> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig >>> index f131ba9..16ed9c3 100644 >>> --- a/drivers/pci/host/Kconfig >>> +++ b/drivers/pci/host/Kconfig >>> @@ -172,4 +172,10 @@ config PCI_HISI >>> help >>> Say Y here if you want PCIe controller support on HiSilicon >>> HIP05 SoC >>> >>> +config PCIE_HOST_THUNDER_PEM >>> + bool "Cavium Thunder PCIe controller to off-chip devices" >>> + depends on PCI_HOST_GENERIC && ARM64 >> >> || COMPILE_TEST ? >> >> (or does the use of writeq get you? If so, maybe COMPILE_TEST && 64BIT) > > Yes, we must use writeq in the driver, I will change it to > ||(COMPILE_TEST && 64BIT) > Actually, it turns out that this is not easily done. For x86, it appears difficult to include asm-generic/pci-bridge.h which includes the needed definition of PCI_PROBE_ONLY. So I think it is not worth supporting COMPILE_TEST David Daney