All of lore.kernel.org
 help / color / mirror / Atom feed
From: chenfeng <puck.chen@hisilicon.com>
To: Mark Brown <broonie@kernel.org>
Cc: <lee.jones@linaro.org>, <linux-kernel@vger.kernel.org>,
	<lgirdwood@gmail.com>, <robh+dt@kernel.org>, <pawel.moll@arm.com>,
	<mark.rutland@arm.com>, <ijc+devicetree@hellion.org.uk>,
	<galak@codeaurora.org>, <xuwei5@hisilicon.com>,
	<puck.chen@aliyun.com>, <yudongbin@hisilicon.com>,
	<saberlily.xia@hisilicon.com>, <suzhuangluan@hisilicon.com>,
	<kong.kongxinwei@hisilicon.com>, <xuyiping@hisilicon.com>,
	<z.liuxinliang@hisilicon.com>, <weidong2@hisilicon.com>,
	<w.f@huawei.com>, <qijiwen@hisilicon.com>,
	<peter.panshilin@hisilicon.com>, <dan.zhao@hisilicon.com>,
	<linuxarm@huawei.com>
Subject: Re: [PATCH v3 5/5] hisilicon/dts: Add hi655x pmic dts node
Date: Thu, 24 Dec 2015 10:43:43 +0800	[thread overview]
Message-ID: <567B5BDF.2000304@hisilicon.com> (raw)
In-Reply-To: <20151223004602.GN16023@sirena.org.uk>



On 2015/12/23 8:46, Mark Brown wrote:
> On Mon, Dec 21, 2015 at 02:20:16PM +0800, chenfeng wrote:
> 
> Please fix your mail client to word wrap within paragraphs at something
> substantially less than 80 columns.  Doing this makes your messages much
> easier to read and reply to.
> 
ok, thanks for your advice.
>> While doing this in driver code, I found that it seems all the vendor
>> chip have the voltage table. So I am wondering can we add this into
>> the regulator framework.
> 
>> We can add in the function of_get_regulation_constraints to get the
>> vset table.
> 
>> I am not sure this is right or not.
> 
> I'm just not convinced it's a good pattern to move this data out to DT,
> like I said in my other mail it's making the ABI bigger and I'm not sure
> I see much upside over putting the data in a table in DT rather than in
> C code.  It's more parsing code and more things we really shouldn't
> change in future.
> 
ok. I will send the new version soon.


  reply	other threads:[~2015-12-24  2:51 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-15 12:54 [PATCH v3 0/5] Add Support for Hi6220 PMIC Hi6553 MFD Core Chen Feng
2015-12-15 12:54 ` [PATCH v3 1/5] doc: bindings: Add document for mfd hi665x PMIC Chen Feng
2015-12-15 12:54 ` [PATCH v3 2/5] doc: bindings: Document for hi655x regulator driver Chen Feng
2015-12-15 12:54 ` [PATCH v3 3/5] mfd: hi655x: Add hi665x pmic driver Chen Feng
2015-12-15 13:29   ` [PATCH] mfd: hi655x: fix platform_no_drv_owner.cocci warnings kbuild test robot
2015-12-15 13:29   ` [PATCH v3 3/5] mfd: hi655x: Add hi665x pmic driver kbuild test robot
2015-12-15 12:54 ` [PATCH v3 4/5] regulator: add regulator driver of hi655x PMIC Chen Feng
2015-12-16 19:16   ` Mark Brown
2015-12-17  3:18     ` chenfeng
2015-12-15 12:54 ` [PATCH v3 5/5] hisilicon/dts: Add hi655x pmic dts node Chen Feng
2015-12-17  3:27   ` chenfeng
2015-12-18 17:58     ` Mark Brown
2015-12-21  3:01       ` chenfeng
2015-12-21  6:20         ` chenfeng
2015-12-23  0:46           ` Mark Brown
2015-12-24  2:43             ` chenfeng [this message]
2015-12-22 16:08         ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=567B5BDF.2000304@hisilicon.com \
    --to=puck.chen@hisilicon.com \
    --cc=broonie@kernel.org \
    --cc=dan.zhao@hisilicon.com \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=kong.kongxinwei@hisilicon.com \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=peter.panshilin@hisilicon.com \
    --cc=puck.chen@aliyun.com \
    --cc=qijiwen@hisilicon.com \
    --cc=robh+dt@kernel.org \
    --cc=saberlily.xia@hisilicon.com \
    --cc=suzhuangluan@hisilicon.com \
    --cc=w.f@huawei.com \
    --cc=weidong2@hisilicon.com \
    --cc=xuwei5@hisilicon.com \
    --cc=xuyiping@hisilicon.com \
    --cc=yudongbin@hisilicon.com \
    --cc=z.liuxinliang@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.