From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DEB1ECE58D for ; Fri, 11 Oct 2019 17:53:56 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 42A6C206A1 for ; Fri, 11 Oct 2019 17:53:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 42A6C206A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54974 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIz6u-00042H-Nf for qemu-devel@archiver.kernel.org; Fri, 11 Oct 2019 13:53:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41984) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIxoz-0002At-2D for qemu-devel@nongnu.org; Fri, 11 Oct 2019 12:31:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iIxox-0004Pt-UM for qemu-devel@nongnu.org; Fri, 11 Oct 2019 12:31:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34974) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iIxou-0004Jh-OD; Fri, 11 Oct 2019 12:31:12 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8FA991DA3; Fri, 11 Oct 2019 16:31:11 +0000 (UTC) Received: from [10.3.116.168] (ovpn-116-168.phx2.redhat.com [10.3.116.168]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3647D1001B36; Fri, 11 Oct 2019 16:31:11 +0000 (UTC) Subject: Re: [PATCH v3 13/16] qcow2: Repair snapshot table with too many entries To: Max Reitz , qemu-block@nongnu.org References: <20191011152814.14791-1-mreitz@redhat.com> <20191011152814.14791-14-mreitz@redhat.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: <567b9148-c1fa-ea1e-250a-5b7851b8edd4@redhat.com> Date: Fri, 11 Oct 2019 11:31:10 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: <20191011152814.14791-14-mreitz@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.71]); Fri, 11 Oct 2019 16:31:11 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 10/11/19 10:28 AM, Max Reitz wrote: > The user cannot choose which snapshots are removed. This is fine > because we have chosen the maximum snapshot table size to be so large > (65536 entries) that it cannot be reasonably reached. If the snapshot > table exceeds this size, the image has probably been corrupted in some > way; in this case, it is most important to just make the image usable > such that the user can copy off at least the active layer. > (Also note that the snapshots will be removed only with "-r all", so a > plain "check" or "check -r leaks" will not delete any data.) > > Signed-off-by: Max Reitz > Reviewed-by: Eric Blake The updated commit messages are good. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org