From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752868AbbL2Lhd (ORCPT ); Tue, 29 Dec 2015 06:37:33 -0500 Received: from mout.web.de ([212.227.17.11]:65441 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751538AbbL2Lhb (ORCPT ); Tue, 29 Dec 2015 06:37:31 -0500 Subject: [PATCH] [media] msi2500: Delete an unnecessary check in msi2500_set_usb_adc() References: <566ABCD9.1060404@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall To: linux-media@vger.kernel.org, Antti Palosaari , Mauro Carvalho Chehab From: SF Markus Elfring Message-ID: <5682706C.5010504@users.sourceforge.net> Date: Tue, 29 Dec 2015 12:37:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <566ABCD9.1060404@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:slG0sMohZIbbQuKSbVKDlYJPk860aBuPL+ILQ6fCdtOKQMydG9G koVNw73Cg994cbiRH2Ahg/o9fLlzjLjOPNrqcl8CodgMfuakWS1LCqf8jkPqVbpKRn+SAp3 2tWTECLwdomvs/d/jLM0dypcUcl9V6MBGi585+nbmNDEj2gWAv+vZcSw+UkgdpS96Rp+OHg xkEY+6YfR5FebRtt/z73A== X-UI-Out-Filterresults: notjunk:1;V01:K0:dMHfXZncMk4=:Ch9fcum+i1PJE49Y9CogDy bHAjXpIfHHaMZ29OHw5QuP3kP4V9jJS9Yv5YqowyRfwWsS8Df9dC7qgAeu+lxJZNvnm8LVGas zZ8vT1ksCB4x3ZHwkEkznDYTLKenGRR4ADUGel05ZiuylM/cxUxYvhiWOQx1qxax9opFf9uuA ja7rJxieosENBb1u3AaKzBWf9+iXUw3czqbhdzqgp/zGMlK/D+edtJUgLrbLq9a7CdcpPfwQB kAEF0eNoWWaO7e5yR+VfLUEAA1j6Z7MrAUv9eWO8q80+thbHAmTnpbp775ZWy7Y62jQFFMX2O 95Sh7SVdTfvmxxrKs3YraujxApF2h1JhSRXlbxjr5mOBr51rMbNSLF3ibDbI/LQ7YtASdLoDi DkB0bfkyjTaR3j4XQ7CjoSCSdjvq+puXaNlkWxo7NE/zHtukLsvczAtt9lagOygLpvcLuFchb nBEXjknKFNfssQ5cnZ7QaoPUTHQMQ7JZX9rQ48FBGy5AjtKKT9EJwg/j4ioV7e92nRBxFQ0hV GpZJsYin+8n7XPKAZNuZXLqRN47nEjYchIlQLNyw6wgIONh0tSiCOk8+louFTK1SKyiRIs+tF qiqCA1Y0Di7K0LHdDIIR7T+D3NLKnW60eTmiRlzLfY0y8KF/ozbhhqFX1c0JlvHAin3GmTwoh zqHNyJujV+qy+ejgcHFyN8w/Kuf1S92VOYMvLlYcTsdK7WuTMxqNFHJrByqNLYlHW416GitFy Bgcz/ptX/OgvVtSq52899kJM9Pxs+cOtsGvMTPON6AZm2m8NlEW02uPYdq3VNMZaYv49owejZ 4QQDE1YJmariDe6p/zEDzHDD6pfJA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Tue, 29 Dec 2015 12:32:41 +0100 This issue was detected by using the Coccinelle software. Return the value from a call of the msi2500_ctrl_msg() function without using an extra check for the variable "ret" at the end. Signed-off-by: Markus Elfring --- drivers/media/usb/msi2500/msi2500.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/usb/msi2500/msi2500.c b/drivers/media/usb/msi2500/msi2500.c index c104315..2d33033 100644 --- a/drivers/media/usb/msi2500/msi2500.c +++ b/drivers/media/usb/msi2500/msi2500.c @@ -839,8 +839,6 @@ static int msi2500_set_usb_adc(struct msi2500_dev *dev) goto err; ret = msi2500_ctrl_msg(dev, CMD_WREG, reg3); - if (ret) - goto err; err: return ret; } -- 2.6.3 From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Tue, 29 Dec 2015 11:37:16 +0000 Subject: [PATCH] [media] msi2500: Delete an unnecessary check in msi2500_set_usb_adc() Message-Id: <5682706C.5010504@users.sourceforge.net> List-Id: References: <566ABCD9.1060404@users.sourceforge.net> In-Reply-To: <566ABCD9.1060404@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-media@vger.kernel.org, Antti Palosaari , Mauro Carvalho Chehab Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: Markus Elfring Date: Tue, 29 Dec 2015 12:32:41 +0100 This issue was detected by using the Coccinelle software. Return the value from a call of the msi2500_ctrl_msg() function without using an extra check for the variable "ret" at the end. Signed-off-by: Markus Elfring --- drivers/media/usb/msi2500/msi2500.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/usb/msi2500/msi2500.c b/drivers/media/usb/msi2500/msi2500.c index c104315..2d33033 100644 --- a/drivers/media/usb/msi2500/msi2500.c +++ b/drivers/media/usb/msi2500/msi2500.c @@ -839,8 +839,6 @@ static int msi2500_set_usb_adc(struct msi2500_dev *dev) goto err; ret = msi2500_ctrl_msg(dev, CMD_WREG, reg3); - if (ret) - goto err; err: return ret; } -- 2.6.3