From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754191AbbL3J3g (ORCPT ); Wed, 30 Dec 2015 04:29:36 -0500 Received: from [119.145.14.66] ([119.145.14.66]:30591 "EHLO szxga03-in.huawei.com" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751795AbbL3J3d (ORCPT ); Wed, 30 Dec 2015 04:29:33 -0500 Subject: Re: [PATCH v1 1/3] ARM64 LPC: indirect ISA PORT IO introduced To: Arnd Bergmann References: <1451396032-23708-1-git-send-email-zourongrong@gmail.com> <12016636.UdNIMv3WjG@wuerfel> <56833234.8010109@huawei.com> <1628979.qkJQGmVH0I@wuerfel> CC: Rongrong Zou , , , , , , , , From: Rongrong Zou Message-ID: <5683A3B4.7040005@huawei.com> Date: Wed, 30 Dec 2015 17:28:20 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1628979.qkJQGmVH0I@wuerfel> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.177.30.66] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090205.5683A3C5.0037,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: fa3e5ee2e5bc9cf9b6dbfa1e3396294c Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2015/12/30 16:59, Arnd Bergmann 写道: > On Wednesday 30 December 2015 09:24:04 Rongrong Zou wrote: >>>>>> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms >>>>>> index 4043c35..98ae206 100644 >>>>>> --- a/arch/arm64/Kconfig.platforms >>>>>> +++ b/arch/arm64/Kconfig.platforms >>>>>> @@ -127,5 +127,8 @@ config ARCH_ZYNQMP >>>>>> bool "Xilinx ZynqMP Family" >>>>>> help >>>>>> This enables support for Xilinx ZynqMP Family >>>>>> - >>>>>> +config ARM64_INDIRECT_PIO >>>>>> + bool "ARM64 Indirect port I/O" >>>>>> + help >>>>>> + This enables support for ARM64 indirect port I/O >>>>>> endmenu >>>>> >>>>> The option should probably go into arch/arm64/Kconfig. Possibly you can make >>>>> it a silent option that just gets selected whenever a driver is enabled >>>>> that might set the callbacks. >>>> >>>> I try to bind it with HISILICON platform. >>> >>> It should be possible to build the actual driver on all platforms, at >>> least with COMPILE_TEST. >> >> Sorry, I'm a little confused, can you describe it in detail? >> >> > > config ARM64_INDIRECT_PIO > bool > help > Any driver that provides indirect ISA I/O port access should select > this symbol > > config HISILICON_HI123456_LPC > bool "Workaround for nonstandard ISA I/O space on Hisilicon Hi123456 SoC" > depends on ARCH_HISI || COMPILE_TEST > select ARM64_INDIRECT_PIO > help > ... Can it be a submenu of "Platform selection--->Hisilicon SoC Family"? > > > Arnd > > . >