From mboxrd@z Thu Jan 1 00:00:00 1970 From: miaoqinglang Subject: Re: [PATCH -next] gpu: host1x: Convert to DEFINE_SHOW_ATTRIBUTE Date: Fri, 17 Jul 2020 09:32:21 +0800 Message-ID: <5684dcb3-c5a4-96c1-dd96-c44f5a94938f@huawei.com> References: <20200716090323.13274-1-miaoqinglang@huawei.com> <20200716133450.GJ535268@ulmo> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20200716133450.GJ535268@ulmo> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Thierry Reding Cc: Greg Kroah-Hartman , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org 在 2020/7/16 21:34, Thierry Reding 写道: > On Thu, Jul 16, 2020 at 05:03:23PM +0800, Qinglang Miao wrote: >> From: Yongqiang Liu >> >> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. >> >> Signed-off-by: Yongqiang Liu >> --- >> drivers/gpu/host1x/debug.c | 28 ++++------------------------ >> 1 file changed, 4 insertions(+), 24 deletions(-) > This doesn't apply. Can you please resend, based on something like > linux-next? > > Thanks, > Thierry Hi, Thierry   Sorry I didn't mention it in commit log, but this patch is based on linux-next where commit <4d4901c6d7> has switched over direct  seq_read method calls to seq_read_iter, this is why there's conflict in  your apply.   Do you think I should send a new patch based on 5.8rc? Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44866C433E0 for ; Fri, 17 Jul 2020 01:32:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 209DD207BC for ; Fri, 17 Jul 2020 01:32:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726784AbgGQBc2 (ORCPT ); Thu, 16 Jul 2020 21:32:28 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:7774 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726138AbgGQBc2 (ORCPT ); Thu, 16 Jul 2020 21:32:28 -0400 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id ED2CFCB7FADA5FB032E4; Fri, 17 Jul 2020 09:32:25 +0800 (CST) Received: from [127.0.0.1] (10.174.179.91) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.487.0; Fri, 17 Jul 2020 09:32:22 +0800 Subject: Re: [PATCH -next] gpu: host1x: Convert to DEFINE_SHOW_ATTRIBUTE To: Thierry Reding CC: Greg Kroah-Hartman , , , References: <20200716090323.13274-1-miaoqinglang@huawei.com> <20200716133450.GJ535268@ulmo> From: miaoqinglang Message-ID: <5684dcb3-c5a4-96c1-dd96-c44f5a94938f@huawei.com> Date: Fri, 17 Jul 2020 09:32:21 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200716133450.GJ535268@ulmo> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.91] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2020/7/16 21:34, Thierry Reding 写道: > On Thu, Jul 16, 2020 at 05:03:23PM +0800, Qinglang Miao wrote: >> From: Yongqiang Liu >> >> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. >> >> Signed-off-by: Yongqiang Liu >> --- >> drivers/gpu/host1x/debug.c | 28 ++++------------------------ >> 1 file changed, 4 insertions(+), 24 deletions(-) > This doesn't apply. Can you please resend, based on something like > linux-next? > > Thanks, > Thierry Hi, Thierry   Sorry I didn't mention it in commit log, but this patch is based on linux-next where commit <4d4901c6d7> has switched over direct  seq_read method calls to seq_read_iter, this is why there's conflict in  your apply.   Do you think I should send a new patch based on 5.8rc? Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E47EFC4363F for ; Fri, 17 Jul 2020 07:22:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C38ED2076A for ; Fri, 17 Jul 2020 07:22:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C38ED2076A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 884D56ED0D; Fri, 17 Jul 2020 07:22:01 +0000 (UTC) Received: from huawei.com (szxga05-in.huawei.com [45.249.212.191]) by gabe.freedesktop.org (Postfix) with ESMTPS id F37256E2BC for ; Fri, 17 Jul 2020 01:32:28 +0000 (UTC) Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id ED2CFCB7FADA5FB032E4; Fri, 17 Jul 2020 09:32:25 +0800 (CST) Received: from [127.0.0.1] (10.174.179.91) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.487.0; Fri, 17 Jul 2020 09:32:22 +0800 Subject: Re: [PATCH -next] gpu: host1x: Convert to DEFINE_SHOW_ATTRIBUTE To: Thierry Reding References: <20200716090323.13274-1-miaoqinglang@huawei.com> <20200716133450.GJ535268@ulmo> From: miaoqinglang Message-ID: <5684dcb3-c5a4-96c1-dd96-c44f5a94938f@huawei.com> Date: Fri, 17 Jul 2020 09:32:21 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200716133450.GJ535268@ulmo> X-Originating-IP: [10.174.179.91] X-CFilter-Loop: Reflected X-Mailman-Approved-At: Fri, 17 Jul 2020 07:22:00 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-tegra@vger.kernel.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" CuWcqCAyMDIwLzcvMTYgMjE6MzQsIFRoaWVycnkgUmVkaW5nIOWGmemBkzoKPiBPbiBUaHUsIEp1 bCAxNiwgMjAyMCBhdCAwNTowMzoyM1BNICswODAwLCBRaW5nbGFuZyBNaWFvIHdyb3RlOgo+PiBG cm9tOiBZb25ncWlhbmcgTGl1IDxsaXV5b25ncWlhbmcxM0BodWF3ZWkuY29tPgo+Pgo+PiBVc2Ug REVGSU5FX1NIT1dfQVRUUklCVVRFIG1hY3JvIHRvIHNpbXBsaWZ5IHRoZSBjb2RlLgo+Pgo+PiBT aWduZWQtb2ZmLWJ5OiBZb25ncWlhbmcgTGl1IDxsaXV5b25ncWlhbmcxM0BodWF3ZWkuY29tPgo+ PiAtLS0KPj4gICBkcml2ZXJzL2dwdS9ob3N0MXgvZGVidWcuYyB8IDI4ICsrKystLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0KPj4gICAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCAyNCBk ZWxldGlvbnMoLSkKPiBUaGlzIGRvZXNuJ3QgYXBwbHkuIENhbiB5b3UgcGxlYXNlIHJlc2VuZCwg YmFzZWQgb24gc29tZXRoaW5nIGxpa2UKPiBsaW51eC1uZXh0Pwo+Cj4gVGhhbmtzLAo+IFRoaWVy cnkKSGksIFRoaWVycnkKCiDCoCBTb3JyeSBJIGRpZG4ndCBtZW50aW9uIGl0IGluIGNvbW1pdCBs b2csIGJ1dCB0aGlzIHBhdGNoIGlzIGJhc2VkIG9uIApsaW51eC1uZXh0IHdoZXJlIGNvbW1pdCA8 NGQ0OTAxYzZkNz4gaGFzIHN3aXRjaGVkIG92ZXIgZGlyZWN0wqAgc2VxX3JlYWQgCm1ldGhvZCBj YWxscyB0byBzZXFfcmVhZF9pdGVyLCB0aGlzIGlzIHdoeSB0aGVyZSdzIGNvbmZsaWN0IGluwqAg eW91ciBhcHBseS4KCiDCoCBEbyB5b3UgdGhpbmsgSSBzaG91bGQgc2VuZCBhIG5ldyBwYXRjaCBi YXNlZCBvbiA1LjhyYz8KClRoYW5rcy4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2RyaS1kZXZlbAo=