All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans Petter Selasky <hps@selasky.org>
To: Ricardo Ribalda <ribalda@chromium.org>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	linux-media@vger.kernel.org
Subject: Re: [PATCH] Make sure we parse really received data.
Date: Mon, 3 Jan 2022 17:03:18 +0100	[thread overview]
Message-ID: <56853d3b-d17f-ae5e-84a1-a6c3065aeac7@selasky.org> (raw)
In-Reply-To: <CANiDSCspxoJGMfaVL0eE0ob4NVuWyiMPmLV1osnLoTBOAMk7dg@mail.gmail.com>

On 1/3/22 16:18, Ricardo Ribalda wrote:
>> Can you point in the code where this check is?
> 
> https://elixir.bootlin.com/linux/latest/source/drivers/media/usb/uvc/uvc_video.c#L281
> and
> https://elixir.bootlin.com/linux/latest/source/drivers/media/usb/uvc/uvc_video.c#L291

Hi Ricardo,

After looking more closely at the code, I believe the issue I found is a 
false positive of valgrind, that doesn't see the kernel move data into 
the given location after the USB control request.

This patch can be dropped, unless you think zeroing this buffer is good 
practice, in case of future UVC descriptor parsing updates.

RET=26, SIZE=26

Thanks for looking into it.

--HPS

      reply	other threads:[~2022-01-03 16:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-22 10:46 [PATCH] Make sure we parse really received data Hans Petter Selasky
2021-12-23 19:09 ` Ricardo Ribalda
2021-12-31  9:59   ` Hans Petter Selasky
2022-01-03 15:18     ` Ricardo Ribalda
2022-01-03 16:03       ` Hans Petter Selasky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56853d3b-d17f-ae5e-84a1-a6c3065aeac7@selasky.org \
    --to=hps@selasky.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=ribalda@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.