From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751938AbcAAMX3 (ORCPT ); Fri, 1 Jan 2016 07:23:29 -0500 Received: from mout.web.de ([212.227.17.12]:56213 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751758AbcAAMXZ (ORCPT ); Fri, 1 Jan 2016 07:23:25 -0500 Subject: [PATCH 2/3] net-gianfar: Delete unnecessary variable initialisations in gfar_ethflow_to_filer_table() To: netdev@vger.kernel.org, Claudiu Manoil References: <566ABCD9.1060404@users.sourceforge.net> <56866E7F.8080609@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <56866FB7.7080008@users.sourceforge.net> Date: Fri, 1 Jan 2016 13:23:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <56866E7F.8080609@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:gqEFP1N7Ws0JmyQxa6SKlalw8Vyw8hIIXVYibaDqmZuakCphw6J wP2h5IlasDC4T3rtWP+rwbPu+sdEAGXw82FTYMMiwjQyWZY4mFLKXiZjTvzVIaCxt6O60n+ SSFI6G6OUo4yd0YEITZFCvjOOJ5tjXu8F2pVmcR7kExtyvja5AmgWebwulvhK+a1I7mZttZ xvYwiGnHUtoMN1pzTXJhQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:m8Sf3SkAIb8=:mta9ILHUm/nk4kbirKS+A4 s6WwWzzWg6ItH8NOGuV3GIPPHIrzAlJy3s/1MS7zo4sGH6zwq+igsxEe3LgOViLfO62XP53ME yZ1I+G7YFFsvlREbUwSjdEkBJPK9tu89VACfP+vA7PkLeqceAzVHdNRCipygeANeCFN0RrRsL +8UWGhmByf5f2dtkljhtEwxNcmiG+ZQK9WPHNjDbkLzCY3ZmZe5zv3F8GP490EXQY9wJHgsrd PRGaekWYG55yosCi+D4O6AP83E1y5oFeuk3kFlJvMcrBgSQs8e173yqkrTpi4aGun0gzjVxx5 jTtsV7rkzhvgdp5lew4uTB6sJLLEvICrkdwG8bgF5kNzho130UiKpujIVLELLSweFPpQtkJYk sEbmABwx3JXE994EEPWGsst+IUOTd/4EdVbDkYJDOoL6pa8H4tw8x1y8MF9Lwc+5yeY16RCKY z/RkGni1yGHjM3HkU/oZljU6IuPxrsHYYry+BcEZPYLWoVpYvwIPnjBLir7d5R0Wkupy3JN/r FzwkyOTEAwwF96QV4Jtx5t1ZowDQ+KYLPz699wJXh/ZOh5yQedP41qymt5oHoiod6Mz4B8NIz Y5xIYSUoWAeI1Z56mNHKnGF8p8JZDSnTBQoqKxpdF5OcSUCwrOd+ub0MI82rCtyljQTSHt9Wg dJvhzKzKXTQW8oxYNFwsns7NNt3cWTAey17nRtBcTzNIqSmpP+zkplsmXPiuUmIxc9pA4+tIy pJ4FTdIYtemElLqf6fJ+MtPNoIbJJ9BG/istqvZ279keV4C8vI3h9OlG+H2/OiyeBw0OuH2ba cx2FwYe Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 1 Jan 2016 12:56:23 +0100 Omit explicit initialisation at the beginning for four local variables which are redefined before their first use. Signed-off-by: Markus Elfring --- drivers/net/ethernet/freescale/gianfar_ethtool.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/freescale/gianfar_ethtool.c b/drivers/net/ethernet/freescale/gianfar_ethtool.c index be4941e..508be89 100644 --- a/drivers/net/ethernet/freescale/gianfar_ethtool.c +++ b/drivers/net/ethernet/freescale/gianfar_ethtool.c @@ -768,12 +768,12 @@ static void ethflow_to_filer_rules (struct gfar_private *priv, u64 ethflow) static int gfar_ethflow_to_filer_table(struct gfar_private *priv, u64 ethflow, u64 class) { - unsigned int last_rule_idx = priv->cur_filer_idx; + unsigned int last_rule_idx; unsigned int cmp_rqfpr; unsigned int *local_rqfpr; unsigned int *local_rqfcr; - int i = 0x0, k = 0x0; - int j = MAX_FILER_IDX, l = 0x0; + int i, k, l; + int j = MAX_FILER_IDX; int ret = 1; local_rqfpr = kmalloc_array(MAX_FILER_IDX + 1, sizeof(unsigned int), -- 2.6.3 From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Fri, 01 Jan 2016 12:23:19 +0000 Subject: [PATCH 2/3] net-gianfar: Delete unnecessary variable initialisations in gfar_ethflow_to_filer_table( Message-Id: <56866FB7.7080008@users.sourceforge.net> List-Id: References: <566ABCD9.1060404@users.sourceforge.net> <56866E7F.8080609@users.sourceforge.net> In-Reply-To: <56866E7F.8080609@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: netdev@vger.kernel.org, Claudiu Manoil Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: Markus Elfring Date: Fri, 1 Jan 2016 12:56:23 +0100 Omit explicit initialisation at the beginning for four local variables which are redefined before their first use. Signed-off-by: Markus Elfring --- drivers/net/ethernet/freescale/gianfar_ethtool.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/freescale/gianfar_ethtool.c b/drivers/net/ethernet/freescale/gianfar_ethtool.c index be4941e..508be89 100644 --- a/drivers/net/ethernet/freescale/gianfar_ethtool.c +++ b/drivers/net/ethernet/freescale/gianfar_ethtool.c @@ -768,12 +768,12 @@ static void ethflow_to_filer_rules (struct gfar_private *priv, u64 ethflow) static int gfar_ethflow_to_filer_table(struct gfar_private *priv, u64 ethflow, u64 class) { - unsigned int last_rule_idx = priv->cur_filer_idx; + unsigned int last_rule_idx; unsigned int cmp_rqfpr; unsigned int *local_rqfpr; unsigned int *local_rqfcr; - int i = 0x0, k = 0x0; - int j = MAX_FILER_IDX, l = 0x0; + int i, k, l; + int j = MAX_FILER_IDX; int ret = 1; local_rqfpr = kmalloc_array(MAX_FILER_IDX + 1, sizeof(unsigned int), -- 2.6.3