From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mout.web.de ([212.227.15.3]:49685 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750855AbcACHAu (ORCPT ); Sun, 3 Jan 2016 02:00:50 -0500 Subject: Re: [PATCH 1/3] NFC-mei_phy: Refactoring for mei_nfc_connect() To: Julian Calaby References: <566ABCD9.1060404@users.sourceforge.net> <56883849.2080304@users.sourceforge.net> <5688390B.3080800@users.sourceforge.net> Cc: linux-wireless , Aloisio Almeida Jr , Lauro Ramos Venancio , Samuel Ortiz , LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <5688C712.3070900@users.sourceforge.net> (sfid-20160103_080111_442389_12639A14) Date: Sun, 3 Jan 2016 08:00:34 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: >> r = 0; >> - >> -err: >> +free_reply: >> kfree(reply); >> +free_cmd: >> kfree(cmd); >> - > > Why are you deleting the two blank lines here? Can they be unnecessary at this source code place according to the Linux coding style convention? Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Sun, 03 Jan 2016 07:00:34 +0000 Subject: Re: [PATCH 1/3] NFC-mei_phy: Refactoring for mei_nfc_connect() Message-Id: <5688C712.3070900@users.sourceforge.net> List-Id: References: <566ABCD9.1060404@users.sourceforge.net> <56883849.2080304@users.sourceforge.net> <5688390B.3080800@users.sourceforge.net> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julian Calaby Cc: linux-wireless , Aloisio Almeida Jr , Lauro Ramos Venancio , Samuel Ortiz , LKML , kernel-janitors@vger.kernel.org, Julia Lawall >> r = 0; >> - >> -err: >> +free_reply: >> kfree(reply); >> +free_cmd: >> kfree(cmd); >> - > > Why are you deleting the two blank lines here? Can they be unnecessary at this source code place according to the Linux coding style convention? Regards, Markus