From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751862AbcACIv4 (ORCPT ); Sun, 3 Jan 2016 03:51:56 -0500 Received: from mout.web.de ([212.227.17.11]:53447 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751752AbcACIvm (ORCPT ); Sun, 3 Jan 2016 03:51:42 -0500 Subject: [PATCH 2/8] rtc-ab-b5ze-s3: Delete an unnecessary variable in abb5zes3_rtc_set_alarm() To: rtc-linux@googlegroups.com, Alessandro Zummo , Alexandre Belloni References: <566ABCD9.1060404@users.sourceforge.net> <5688DF2D.6090204@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <5688E11A.90303@users.sourceforge.net> Date: Sun, 3 Jan 2016 09:51:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <5688DF2D.6090204@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:hLrpSWZtfzfKCeftlGCVMNaWi0pCrkWE0343nZI+Zpd3RqHAmp4 Fed5XdZIw7JORC27OOwT+yennOEuE2MM3Fm6GI/R+2OUksd9i2TnxpXt4AZfd+TbNoMAAdi EZ/L/qkk8vCW+7VS7EEdMJO1xoDBXtZEiRrHEftavwRgu+mcb1MSxk9oNrHtnXzGXGOWAJp 3GnWnsS/xV6QOpo6MHquA== X-UI-Out-Filterresults: notjunk:1;V01:K0:g9YcvxTQ9Bc=:ZSPib8KlYHAmF7nExP44C9 t/vc0LiU8EOLe3EgCVZ1uUZuNXCgJowRAz0p+lNHKY52iUh4oA3wIJ2PJpjEieozGXoblPVUC DnrbJ5Mb6r8vU9DkLn7vNJ3I5Zf7HQxfRXKZdcveWEdQvmm6u/ehecD+HpXdB5eVc9UVgtWxk MRXVOiIVANjaUnBL5Rhq6B/GmwenfH4OS1g3fyuiHFqIjcwntiX5EQKSR1GD1YXeOSxatVWCO Z+xoBE6xUqlCwm8g8Xy77n9oerZwF1o8qgObrZ9NRtkqSQisUTPSTd7ADULof6hKk/8sdh8Cu uWvq+/wGnfcDkxdQBNfZdepHIro0i5ixTWiNdeZmLKt0C5OcJJYArG2PL/To9/lZ+Wk0debGp 96gzkxlQBN0wEE6dByTLEQP3K5GlVzC+kPl8mikiK/IvJErevclxhRYdfrBRR0UbEi5xvuR/l 1S8N94niXAliQphVJ5h7xcLcJeagJa7WmRbj+MdjYCe1NMszqO+v2WIaHTuu3iLuE/kB4ZJxa hGXrb9h/ymoZ+k5dToDu5br1zzInaqOvSXk7XWD79ygUPZyjE/o8G6nJlP0BqyAaidk1L70Zu YqeTCrt38qRWJvuEnL+IQKUBvriLL+evhx0o9pXmy57OI+Zcdynri+JDqNeYBJjrKbR6eiNj+ 8bUlribacN1g+YbyNSpWQMy80aM/lX/i/ERZ3GU/K9tt64TyLNczVDDk5O5srB8Plh1HUMJF0 MRG7AEL0Cs/+GYAj8XqA6oDVn2jMYhJvprO3Vwp9JzZPWGPNWRhn6kZfbZUMdZLo4JissU9mk HHpTiAc Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sun, 3 Jan 2016 07:35:09 +0100 Pass the address of the data structure element "time" directly in a call of the function "rtc_tm_to_time" instead of an extra initialisation for one local variable at the beginning. Signed-off-by: Markus Elfring --- drivers/rtc/rtc-ab-b5ze-s3.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-ab-b5ze-s3.c b/drivers/rtc/rtc-ab-b5ze-s3.c index 1291206..ed9b873 100644 --- a/drivers/rtc/rtc-ab-b5ze-s3.c +++ b/drivers/rtc/rtc-ab-b5ze-s3.c @@ -596,7 +596,6 @@ err: static int abb5zes3_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alarm) { struct abb5zes3_rtc_data *data = dev_get_drvdata(dev); - struct rtc_time *alarm_tm = &alarm->time; unsigned long rtc_secs, alarm_secs; struct rtc_time rtc_tm; int ret; @@ -610,7 +609,7 @@ static int abb5zes3_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alarm) if (ret) goto err; - ret = rtc_tm_to_time(alarm_tm, &alarm_secs); + ret = rtc_tm_to_time(&alarm->time, &alarm_secs); if (ret) goto err; -- 2.6.3 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.web.de (mout.web.de. [212.227.17.11]) by gmr-mx.google.com with ESMTPS id 202si2321730wmf.2.2016.01.03.00.51.40 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 03 Jan 2016 00:51:40 -0800 (PST) Subject: [rtc-linux] [PATCH 2/8] rtc-ab-b5ze-s3: Delete an unnecessary variable in abb5zes3_rtc_set_alarm() To: rtc-linux@googlegroups.com, Alessandro Zummo , Alexandre Belloni References: <566ABCD9.1060404@users.sourceforge.net> <5688DF2D.6090204@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <5688E11A.90303@users.sourceforge.net> Date: Sun, 3 Jan 2016 09:51:38 +0100 MIME-Version: 1.0 In-Reply-To: <5688DF2D.6090204@users.sourceforge.net> Content-Type: text/plain; charset=UTF-8 Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , From: Markus Elfring Date: Sun, 3 Jan 2016 07:35:09 +0100 Pass the address of the data structure element "time" directly in a call of the function "rtc_tm_to_time" instead of an extra initialisation for one local variable at the beginning. Signed-off-by: Markus Elfring --- drivers/rtc/rtc-ab-b5ze-s3.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-ab-b5ze-s3.c b/drivers/rtc/rtc-ab-b5ze-s3.c index 1291206..ed9b873 100644 --- a/drivers/rtc/rtc-ab-b5ze-s3.c +++ b/drivers/rtc/rtc-ab-b5ze-s3.c @@ -596,7 +596,6 @@ err: static int abb5zes3_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alarm) { struct abb5zes3_rtc_data *data = dev_get_drvdata(dev); - struct rtc_time *alarm_tm = &alarm->time; unsigned long rtc_secs, alarm_secs; struct rtc_time rtc_tm; int ret; @@ -610,7 +609,7 @@ static int abb5zes3_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alarm) if (ret) goto err; - ret = rtc_tm_to_time(alarm_tm, &alarm_secs); + ret = rtc_tm_to_time(&alarm->time, &alarm_secs); if (ret) goto err; -- 2.6.3 -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Sun, 03 Jan 2016 08:51:38 +0000 Subject: [PATCH 2/8] rtc-ab-b5ze-s3: Delete an unnecessary variable in abb5zes3_rtc_set_alarm() Message-Id: <5688E11A.90303@users.sourceforge.net> List-Id: References: <566ABCD9.1060404@users.sourceforge.net> <5688DF2D.6090204@users.sourceforge.net> In-Reply-To: <5688DF2D.6090204@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: rtc-linux@googlegroups.com, Alessandro Zummo , Alexandre Belloni Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: Markus Elfring Date: Sun, 3 Jan 2016 07:35:09 +0100 Pass the address of the data structure element "time" directly in a call of the function "rtc_tm_to_time" instead of an extra initialisation for one local variable at the beginning. Signed-off-by: Markus Elfring --- drivers/rtc/rtc-ab-b5ze-s3.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-ab-b5ze-s3.c b/drivers/rtc/rtc-ab-b5ze-s3.c index 1291206..ed9b873 100644 --- a/drivers/rtc/rtc-ab-b5ze-s3.c +++ b/drivers/rtc/rtc-ab-b5ze-s3.c @@ -596,7 +596,6 @@ err: static int abb5zes3_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alarm) { struct abb5zes3_rtc_data *data = dev_get_drvdata(dev); - struct rtc_time *alarm_tm = &alarm->time; unsigned long rtc_secs, alarm_secs; struct rtc_time rtc_tm; int ret; @@ -610,7 +609,7 @@ static int abb5zes3_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alarm) if (ret) goto err; - ret = rtc_tm_to_time(alarm_tm, &alarm_secs); + ret = rtc_tm_to_time(&alarm->time, &alarm_secs); if (ret) goto err; -- 2.6.3