From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752003AbcACIz3 (ORCPT ); Sun, 3 Jan 2016 03:55:29 -0500 Received: from mout.web.de ([212.227.17.12]:65506 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751456AbcACIz0 (ORCPT ); Sun, 3 Jan 2016 03:55:26 -0500 Subject: [PATCH 6/8] rtc-ab-b5ze-s3: Delete an unnecessary variable in _abb5zes3_rtc_read_timer() To: rtc-linux@googlegroups.com, Alessandro Zummo , Alexandre Belloni References: <566ABCD9.1060404@users.sourceforge.net> <5688DF2D.6090204@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <5688E1F2.1080705@users.sourceforge.net> Date: Sun, 3 Jan 2016 09:55:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <5688DF2D.6090204@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:Yk3mlKqoyrmLaIXUP4UuiO3r3zWBxLmoamzbECHt8slKTzrOp3l 3TdcMyM0KarkaHhdtRwH58knlZ9XzkY643KAG4+m+Vvo8m33UB2B1WH7frsgw4cEF8l6FKP M+8AI60n3EFL/NseYN3Q0hLo9XHQZunU66mwYGUqxUvk0Mr5Y7uXieKrMlQI3sYKUTiRSpP z6PU6Woxavs4A9nPJhp9g== X-UI-Out-Filterresults: notjunk:1;V01:K0:A6bJmPtA0KM=:g/eyqqRS3co3yZAWRqhWO8 tvQvwJWCsel6UbWipAe8jmArb/zBlEkbsBqJNSnW3NzvxKGFPVYaVhWnwyZFwnZqckR8+hgYa KL+u3by8sopJsjHRW+FX+x5AsNfygCGVw50HfZNa0CytrqETfFRo1NqRgNN/0HnO73tkuKPg7 KVSAdNzVmQon4lJi1eVseuKYVR15ZG7qO2pRImUxfYzOpFaK8gnq10IW7DdUWmu7DUilDUZuz wVF8h53X3mQjxJwu+zAEU+S9aer+dBOnIId+ji4CPLNyRGq1+pHa1kg9GlC9sgIw+PiWcvo1T H7iJ40xxPlr74WAZdOrhQmCHyvN6b0U8egFaiyufoNdFQYXt4zJi2NbZixkcpY+jO2LINpPOz 7smX+xf1tCapj/t4qNRM8wyl/z1ahGVfSEXZzdBWlH+PAzIFTKpoezvolTvbbrhRln7t928Ej OK9WU9mH/PK6uFWHDipr//HZk/PPZjjYx6AtwTHLlAsjKiU0lJBMrjnVzUiCXT5CEZkHyF1Mn 11syD9gRYOjmJli8tDhhG2gz8nctvE/fX9EG6ztZShrvxo64oT8xr7XB0CPGbEdA6w7Bru2+N vMnq0vaEuVEQhy8LCIJ8llA9fCMNuXVBsiTOfNNv576W0CHysS7v0FZhG5Oga7RtMUhZK2N+G B/k14U1VCpbq0Br6RoTLohAA6Y0Vuux/Yaf1qgZsL0AvR5/PieFcpOIBRBW66uGMKe0ZdFbvn Jnwy8BAxcRBby8o7DRxaVmCrEE9VmCPdxxdSz2qG24dp2TUYy6N7zCiH4NVhLBbZgxey9qI0q zJXfTCO Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sun, 3 Jan 2016 08:46:50 +0100 Pass the address of the data structure element "time" directly in a call of the function "rtc_time_to_tm" instead of an extra initialisation for one local variable at the beginning. Signed-off-by: Markus Elfring --- drivers/rtc/rtc-ab-b5ze-s3.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-ab-b5ze-s3.c b/drivers/rtc/rtc-ab-b5ze-s3.c index 02e3443..e3a015a 100644 --- a/drivers/rtc/rtc-ab-b5ze-s3.c +++ b/drivers/rtc/rtc-ab-b5ze-s3.c @@ -326,7 +326,7 @@ static int _abb5zes3_rtc_read_timer(struct device *dev, struct rtc_wkalrm *alarm) { struct abb5zes3_rtc_data *data = dev_get_drvdata(dev); - struct rtc_time rtc_tm, *alarm_tm = &alarm->time; + struct rtc_time rtc_tm; u8 regs[ABB5ZES3_TIMA_SEC_LEN + 1]; unsigned long rtc_secs; unsigned int reg; @@ -362,7 +362,7 @@ static int _abb5zes3_rtc_read_timer(struct device *dev, goto err; /* ... and convert back. */ - rtc_time_to_tm(rtc_secs + timer_secs, alarm_tm); + rtc_time_to_tm(rtc_secs + timer_secs, &alarm->time); ret = regmap_read(data->regmap, ABB5ZES3_REG_CTRL2, ®); if (ret) { -- 2.6.3 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.web.de (mout.web.de. [212.227.17.12]) by gmr-mx.google.com with ESMTPS id b4si904487wme.3.2016.01.03.00.55.16 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 03 Jan 2016 00:55:16 -0800 (PST) Subject: [rtc-linux] [PATCH 6/8] rtc-ab-b5ze-s3: Delete an unnecessary variable in _abb5zes3_rtc_read_timer() To: rtc-linux@googlegroups.com, Alessandro Zummo , Alexandre Belloni References: <566ABCD9.1060404@users.sourceforge.net> <5688DF2D.6090204@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <5688E1F2.1080705@users.sourceforge.net> Date: Sun, 3 Jan 2016 09:55:14 +0100 MIME-Version: 1.0 In-Reply-To: <5688DF2D.6090204@users.sourceforge.net> Content-Type: text/plain; charset=UTF-8 Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , From: Markus Elfring Date: Sun, 3 Jan 2016 08:46:50 +0100 Pass the address of the data structure element "time" directly in a call of the function "rtc_time_to_tm" instead of an extra initialisation for one local variable at the beginning. Signed-off-by: Markus Elfring --- drivers/rtc/rtc-ab-b5ze-s3.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-ab-b5ze-s3.c b/drivers/rtc/rtc-ab-b5ze-s3.c index 02e3443..e3a015a 100644 --- a/drivers/rtc/rtc-ab-b5ze-s3.c +++ b/drivers/rtc/rtc-ab-b5ze-s3.c @@ -326,7 +326,7 @@ static int _abb5zes3_rtc_read_timer(struct device *dev, struct rtc_wkalrm *alarm) { struct abb5zes3_rtc_data *data = dev_get_drvdata(dev); - struct rtc_time rtc_tm, *alarm_tm = &alarm->time; + struct rtc_time rtc_tm; u8 regs[ABB5ZES3_TIMA_SEC_LEN + 1]; unsigned long rtc_secs; unsigned int reg; @@ -362,7 +362,7 @@ static int _abb5zes3_rtc_read_timer(struct device *dev, goto err; /* ... and convert back. */ - rtc_time_to_tm(rtc_secs + timer_secs, alarm_tm); + rtc_time_to_tm(rtc_secs + timer_secs, &alarm->time); ret = regmap_read(data->regmap, ABB5ZES3_REG_CTRL2, ®); if (ret) { -- 2.6.3 -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Sun, 03 Jan 2016 08:55:14 +0000 Subject: [PATCH 6/8] rtc-ab-b5ze-s3: Delete an unnecessary variable in _abb5zes3_rtc_read_timer() Message-Id: <5688E1F2.1080705@users.sourceforge.net> List-Id: References: <566ABCD9.1060404@users.sourceforge.net> <5688DF2D.6090204@users.sourceforge.net> In-Reply-To: <5688DF2D.6090204@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: rtc-linux@googlegroups.com, Alessandro Zummo , Alexandre Belloni Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: Markus Elfring Date: Sun, 3 Jan 2016 08:46:50 +0100 Pass the address of the data structure element "time" directly in a call of the function "rtc_time_to_tm" instead of an extra initialisation for one local variable at the beginning. Signed-off-by: Markus Elfring --- drivers/rtc/rtc-ab-b5ze-s3.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-ab-b5ze-s3.c b/drivers/rtc/rtc-ab-b5ze-s3.c index 02e3443..e3a015a 100644 --- a/drivers/rtc/rtc-ab-b5ze-s3.c +++ b/drivers/rtc/rtc-ab-b5ze-s3.c @@ -326,7 +326,7 @@ static int _abb5zes3_rtc_read_timer(struct device *dev, struct rtc_wkalrm *alarm) { struct abb5zes3_rtc_data *data = dev_get_drvdata(dev); - struct rtc_time rtc_tm, *alarm_tm = &alarm->time; + struct rtc_time rtc_tm; u8 regs[ABB5ZES3_TIMA_SEC_LEN + 1]; unsigned long rtc_secs; unsigned int reg; @@ -362,7 +362,7 @@ static int _abb5zes3_rtc_read_timer(struct device *dev, goto err; /* ... and convert back. */ - rtc_time_to_tm(rtc_secs + timer_secs, alarm_tm); + rtc_time_to_tm(rtc_secs + timer_secs, &alarm->time); ret = regmap_read(data->regmap, ABB5ZES3_REG_CTRL2, ®); if (ret) { -- 2.6.3