From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751909AbcACQdI (ORCPT ); Sun, 3 Jan 2016 11:33:08 -0500 Received: from mout.web.de ([212.227.17.11]:61802 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751740AbcACQdG (ORCPT ); Sun, 3 Jan 2016 11:33:06 -0500 Subject: [PATCH] staging-slicoss: Replace variable initialisations by assignments in slic_if_init() References: <566ABCD9.1060404@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall To: devel@driverdev.osuosl.org, Christopher Harrer , Greg Kroah-Hartman , Lior Dotan From: SF Markus Elfring Message-ID: <56894D2D.1010801@users.sourceforge.net> Date: Sun, 3 Jan 2016 17:32:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <566ABCD9.1060404@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:PPUZV6RkPoZLLyjDtl5jzEW/9zKKtlFAUHYQR/kqkeLlXRJIH+E FBJMfwMwpqslxhEyf1OFEZbhHoGKpuHtKpVB7bihnCOSwAle0BjH45UQe1r1J+6/ZqMZwoM xfKqIU+kF+MNL/DCAR0KjRsRQWJoB+iQ7t2yoT9ZuYx7+gLrugVn414+FZ4nIJlXuyoSYgK +/VBYRgb8IL0up3wdCmsg== X-UI-Out-Filterresults: notjunk:1;V01:K0:ssWCod247OM=:4qcBYo/0HsTTLoBcRIrJ2a CPwW3+AVpwBp6wHG+zC7oYAU04erkenQOaDfOVGZwpfgvwwNTU7xTZbouqc8xiNFK/q99ujVT /3x65FeIvD8qJ8lfd8X54TQTjBh9IC3/86qR/jGfBKmKBo8JBpDAu4UYcCDVEXAAO4Lwksz/g FOPtmI5luU0NRVeV71bQwrEz9pXBk6FGCdcUOHLNHKSUitMmhYoXYowPJnqPihlvi7hgqMe7d 2VtIqd9mFcdgYzAztYmPg5m6kdhYD6Hxy+gVgKtAsP2Wxd53zs3UJ8NppRHC0aYrNhPFSVm48 PxoiH1bd2OALXDuExqTOcktT3ZGAmRb25a/XnqaEAv0j0R0pwMc7Lou55FpbovMCms8CyKyN7 6nR/Em0YBeCjSW6vkrFoH1UKhIHl7Tq5A8mSsUqD0RR/itegYIFDxNNb2/y/D/EwQKVxMJQtt FvcyF2FH2qeOhyBMGjvH5Aa3myh0DM3gGoFNQStSlyqfxymnz5wurT86hY21OsJDEUqM/jUtz 162mtj2nAEGALKAdXtv0jceUKx5wOExjq2E2r07Ed7m4jOxQwh6K4YUG5g2pW6hE2b0cQSMDh SO793r0sEdf7OfCaofre++wxgv/s/I8gFpsKNo/eQUItlkenXWSbJX74vnz0ZK4D3lBNyNCf6 JDiqbKxGBTG00ulARXDWdrNhZH5MvS7Cpm1yeqmZXnAGU1PIMD//SNFsidH5UFzU7O3M2ybn7 eR5vOiNHy2tXaL5Idhbv3Q2rYEPOKUhTQLXe2o5OyggGDeWdZKcCj2zFN8Cgrp9mPdThGSRPY AfL0Uff Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sun, 3 Jan 2016 17:25:59 +0100 Replace explicit initialisation for two local variables at the beginning by assignments. Signed-off-by: Markus Elfring --- drivers/staging/slicoss/slicoss.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c index b23a2d1..8fdcac8 100644 --- a/drivers/staging/slicoss/slicoss.c +++ b/drivers/staging/slicoss/slicoss.c @@ -2301,9 +2301,9 @@ static int slic_adapter_allocresources(struct adapter *adapter, */ static int slic_if_init(struct adapter *adapter, unsigned long *flags) { - struct sliccard *card = adapter->card; + struct sliccard *card; struct net_device *dev = adapter->netdev; - __iomem struct slic_regs *slic_regs = adapter->slic_regs; + __iomem struct slic_regs *slic_regs; struct slic_shmem *pshmem; int rc; @@ -2348,6 +2348,7 @@ static int slic_if_init(struct adapter *adapter, unsigned long *flags) adapter->queues_initialized = 1; } + slic_regs = adapter->slic_regs; slic_reg32_write(&slic_regs->slic_icr, ICR_INT_OFF, FLUSH); mdelay(1); @@ -2374,6 +2375,7 @@ static int slic_if_init(struct adapter *adapter, unsigned long *flags) } adapter->state = ADAPT_UP; + card = adapter->card; if (!card->loadtimerset) { setup_timer(&card->loadtimer, &slic_timer_load_check, (ulong)card); -- 2.6.3 From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Sun, 03 Jan 2016 16:32:45 +0000 Subject: [PATCH] staging-slicoss: Replace variable initialisations by assignments in slic_if_init() Message-Id: <56894D2D.1010801@users.sourceforge.net> List-Id: References: <566ABCD9.1060404@users.sourceforge.net> In-Reply-To: <566ABCD9.1060404@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: devel@driverdev.osuosl.org, Christopher Harrer , Greg Kroah-Hartman , Lior Dotan Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: Markus Elfring Date: Sun, 3 Jan 2016 17:25:59 +0100 Replace explicit initialisation for two local variables at the beginning by assignments. Signed-off-by: Markus Elfring --- drivers/staging/slicoss/slicoss.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c index b23a2d1..8fdcac8 100644 --- a/drivers/staging/slicoss/slicoss.c +++ b/drivers/staging/slicoss/slicoss.c @@ -2301,9 +2301,9 @@ static int slic_adapter_allocresources(struct adapter *adapter, */ static int slic_if_init(struct adapter *adapter, unsigned long *flags) { - struct sliccard *card = adapter->card; + struct sliccard *card; struct net_device *dev = adapter->netdev; - __iomem struct slic_regs *slic_regs = adapter->slic_regs; + __iomem struct slic_regs *slic_regs; struct slic_shmem *pshmem; int rc; @@ -2348,6 +2348,7 @@ static int slic_if_init(struct adapter *adapter, unsigned long *flags) adapter->queues_initialized = 1; } + slic_regs = adapter->slic_regs; slic_reg32_write(&slic_regs->slic_icr, ICR_INT_OFF, FLUSH); mdelay(1); @@ -2374,6 +2375,7 @@ static int slic_if_init(struct adapter *adapter, unsigned long *flags) } adapter->state = ADAPT_UP; + card = adapter->card; if (!card->loadtimerset) { setup_timer(&card->loadtimer, &slic_timer_load_check, (ulong)card); -- 2.6.3