From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751846AbcACQys (ORCPT ); Sun, 3 Jan 2016 11:54:48 -0500 Received: from mout.web.de ([212.227.17.12]:60534 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750952AbcACQyp (ORCPT ); Sun, 3 Jan 2016 11:54:45 -0500 Subject: Re: [PATCH 7/8] rtc-ab-b5ze-s3: Delete an unnecessary variable in _abb5zes3_rtc_interrupt() To: Julia Lawall References: <566ABCD9.1060404@users.sourceforge.net> <5688DF2D.6090204@users.sourceforge.net> <5688E229.4010400@users.sourceforge.net> Cc: rtc-linux@googlegroups.com, Alessandro Zummo , Alexandre Belloni , LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring X-Enigmail-Draft-Status: N1110 Message-ID: <56895246.3080302@users.sourceforge.net> Date: Sun, 3 Jan 2016 17:54:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:od/wZgRPzpuuBPCsjQmbi1tNrU12vhJ3iegogecu3lFVG5S39yY 5oWADpjVNKrruACq594k3gsf67EvYKmC0d9eYTXRoND4bqBQEa+rwGPBER7Yorwo2sIuuzz qMsSdHMPWEOJnDjzAF3TV0qOI0fdK3cf7rGL1Dt5HzbxYhqyVErYHeTW2MY/2O0BGju2tm/ QXzmHMLnQSxsTvG5TnCaQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:ex3wJHY0N4c=:iT1Fx6XLboQhZgtzeYksRN m9d4TfEw9qkwpF4OUGEYw3UAKxcc9AHDCdtbC4oLgr1VIsJpiA7SPGDFoochvlW+21/bI9Dth ai54/L3qgzx1q9aWPoiEHB3h+HY5BXB8yg62e/EU9aIcJub6s432W9YhsJq2baV2pAjo1Lw+T 4PP4tauA7HdrsERtmYYjMVCgpznzPDPmQuyWswHQrdvxfJyvfVSxMZjaCwN16INFMNvkpNi5A cBLnVUCtflHfP9kAryfH0tv4oBQVSXbNN3TuYAAyJ7LyGmSZ4QOtv0hc8tmybYB5h4Pie6Wlr jQpOCD3rEtyoy73DgIYHe9Xb7EtzVOjG4rLJRb0pH4cM5gCDszKsM3KBSfmvwBsVjUqHnp9Cb OlRPFA7/jTw4WwDGttfSBQrnTFnU93fh5hRXRlilcWre2pywP2aqbRuJH2uyzwXVPJm0vI0Gh 92Ui5WP9FzKcHmTis2xxXWaJ7RH0STjAuh0sWsP2Y0+fO/FBuy3jF/15w4t/wb54ulCuQeI48 64sdTJanw4ABLBV7tceX7+h6owwBMX/afOoLc1NMqhU1SYfuX+dxAXyvYKGcM0xSEhbNPz0ck 7AL8eQKoih4Id9NFKXRnLUpZcQYBpE784//nnNTuO3HA/BReBev3JCSBf6F64PZ9Mv5COqCjT B/+YT8cXTRTjaf2+IriP+DQ2ArQaQnWRrJI9KhVfgilU7Uf1AVwj1mkNXgZz9ou6z7gxm1Zv+ r8vWmwQet9wWrsBTDaPS769+RkrcC1EhQPjolv+U7FRKVWYRp3p4JnVv5hvB3JmrdCqZRLMvI eVlTqr/ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> Pass the address of the data structure element "time" directly in calls >> of the function "rtc_update_irq" instead of an extra initialisation >> for one local variable at the beginning. > > Why is it better? I suggest to refer to the data item "rtc_data->rtc" directly because the variable "rtc" was read only in two if branches. Does it make sense then to reduce the variable allocation? Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.web.de (mout.web.de. [212.227.17.12]) by gmr-mx.google.com with ESMTPS id 202si2364774wmf.2.2016.01.03.08.54.35 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 03 Jan 2016 08:54:35 -0800 (PST) Subject: [rtc-linux] Re: [PATCH 7/8] rtc-ab-b5ze-s3: Delete an unnecessary variable in _abb5zes3_rtc_interrupt() To: Julia Lawall References: <566ABCD9.1060404@users.sourceforge.net> <5688DF2D.6090204@users.sourceforge.net> <5688E229.4010400@users.sourceforge.net> Cc: rtc-linux@googlegroups.com, Alessandro Zummo , Alexandre Belloni , LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Message-ID: <56895246.3080302@users.sourceforge.net> Date: Sun, 3 Jan 2016 17:54:30 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=UTF-8 Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , >> Pass the address of the data structure element "time" directly in calls >> of the function "rtc_update_irq" instead of an extra initialisation >> for one local variable at the beginning. > > Why is it better? I suggest to refer to the data item "rtc_data->rtc" directly because the variable "rtc" was read only in two if branches. Does it make sense then to reduce the variable allocation? Regards, Markus -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Sun, 03 Jan 2016 16:54:30 +0000 Subject: Re: [PATCH 7/8] rtc-ab-b5ze-s3: Delete an unnecessary variable in _abb5zes3_rtc_interrupt() Message-Id: <56895246.3080302@users.sourceforge.net> List-Id: References: <566ABCD9.1060404@users.sourceforge.net> <5688DF2D.6090204@users.sourceforge.net> <5688E229.4010400@users.sourceforge.net> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia Lawall Cc: rtc-linux@googlegroups.com, Alessandro Zummo , Alexandre Belloni , LKML , kernel-janitors@vger.kernel.org >> Pass the address of the data structure element "time" directly in calls >> of the function "rtc_update_irq" instead of an extra initialisation >> for one local variable at the beginning. > > Why is it better? I suggest to refer to the data item "rtc_data->rtc" directly because the variable "rtc" was read only in two if branches. Does it make sense then to reduce the variable allocation? Regards, Markus