From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752097AbcACRsb (ORCPT ); Sun, 3 Jan 2016 12:48:31 -0500 Received: from mout.web.de ([212.227.15.3]:60521 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751117AbcACRs2 (ORCPT ); Sun, 3 Jan 2016 12:48:28 -0500 Subject: Re: [PATCH] staging-slicoss: Replace variable initialisations by assignments in slic_if_init() To: Julia Lawall References: <566ABCD9.1060404@users.sourceforge.net> <56894D2D.1010801@users.sourceforge.net> Cc: devel@driverdev.osuosl.org, Christopher Harrer , Greg Kroah-Hartman , Lior Dotan , LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring X-Enigmail-Draft-Status: N1110 Message-ID: <56895EE1.7080808@users.sourceforge.net> Date: Sun, 3 Jan 2016 18:48:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:zsfacbNX4g8cJURQ5auf+lwKAd+XjyswG3tiSExT/kldUC4Uwt2 TblqKDrQEdEdLE1NhZjen5potrRgf5ZNQix7dZFGyLtGquaeDwwzNTzz5S0WKaytXOfnfli BqDc43CYaT9XF71GylMs9VsMpic6yaSZAj+t0VDb7z6o56nfPOrEZGQwlJ4oXZrD9iJlWlb TzGC4jig4e3phP0Gg7muw== X-UI-Out-Filterresults: notjunk:1;V01:K0:lDMXCrcZHvM=:KmdWUION052+7aAYq6kGgH SmoY+ybnucnJcCJfmoUX5pwdLD+QDWNCyrlpnCYh8prAvuSUhY4PimpVnNRS2QroomaRfeBvL d5bGhVtD5oEyn9vIgcd4fVnnfLj1o9i052ffmDxIZDlrTfNuIgl5WCnpyeXRKbIiO6f/zlgLV Ft/o9ozY8u28UfW3XDhC/Yr+IoKLcTtxOXQZh33ZfAXmWN6oeYFLC2dE9G6cfmeTHlPy0Wy/y hxCUsG9AyLOl9VWkov8+cwAtvIik/n78FhnuBgwnnFhPtzdDCGspRljDMzmM3AkwcHzd6N4DJ 1ZxdDsbKGFdOUV13kHHH8wHTR432ylzX9rYv+Of51WCaq9gHNvxSCfs7qYc+ym57TwX5gMP7O Rbx4liS5UNf7OjBAK2v1s7EklT5qAOph7JIX2zLW+DOEdOXcLDKMKL7qadMIhsnsFJwQVITot GuzetTTN+Lq1nIj/87sarBDou5q+MKlHm1P+O4+FBJXGs5AIIRw3hBtXGN5RTSZTZ7Rr2uw3t FaC3sOPH1zbC5thb9l16NcjSVfJlldfHvhkOt2PjzWw/B0gDDHXh+PJnLwHqF7PpYxEhNFtFe tau5kw9NwgLP8PceRwvG7oynYLtbKSZP9+FlRrOrlbb73xK/BFL6dgzvnxa0SC23Y3jRNAvVX BwxswwS5F2Wp8l+x2eAADDCZ0w1IB6n+I2o0wqSHIYiAB4Ak15ZwLHfxtCCx28UOD7EXvd10h Yx9sf4OHGlV2XJzSVj4Fj64LNyqw7RPyFBfvFdE0/7Pj5gQ8tl0KpEwk/2r5T7ahmgid+OuDp RFzjKdY Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> Replace explicit initialisation for two local variables at the beginning >> by assignments. > > Why? I prefer that assignments for variables like "card" and "slic_regs" will only be performed immediately before the corresponding content will be read again (after a few condition checks were executed). Another description could be this view: I suggest to move the variable initialisation a bit. Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Sun, 03 Jan 2016 17:48:17 +0000 Subject: Re: [PATCH] staging-slicoss: Replace variable initialisations by assignments in slic_if_init() Message-Id: <56895EE1.7080808@users.sourceforge.net> List-Id: References: <566ABCD9.1060404@users.sourceforge.net> <56894D2D.1010801@users.sourceforge.net> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia Lawall Cc: devel@driverdev.osuosl.org, Christopher Harrer , Greg Kroah-Hartman , Lior Dotan , LKML , kernel-janitors@vger.kernel.org >> Replace explicit initialisation for two local variables at the beginning >> by assignments. > > Why? I prefer that assignments for variables like "card" and "slic_regs" will only be performed immediately before the corresponding content will be read again (after a few condition checks were executed). Another description could be this view: I suggest to move the variable initialisation a bit. Regards, Markus