From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752174AbcACSRE (ORCPT ); Sun, 3 Jan 2016 13:17:04 -0500 Received: from mout.web.de ([212.227.15.4]:57129 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751385AbcACSRC (ORCPT ); Sun, 3 Jan 2016 13:17:02 -0500 Subject: Re: [PATCH] staging-slicoss: Replace variable initialisations by assignments in slic_if_init() To: Greg Kroah-Hartman References: <566ABCD9.1060404@users.sourceforge.net> <56894D2D.1010801@users.sourceforge.net> <56895EE1.7080808@users.sourceforge.net> <20160103175816.GA21611@kroah.com> Cc: Julia Lawall , devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org, LKML , Lior Dotan , Christopher Harrer From: SF Markus Elfring Message-ID: <56896591.2030208@users.sourceforge.net> Date: Sun, 3 Jan 2016 19:16:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20160103175816.GA21611@kroah.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:+RMDadOm2CWdoNsQYNuxAIbeWP+OzjSlszEhHd73j30hTx9Q3wU 5eVcKqVEffZ9G29a+j6Uw0LFhECgola2e9O2oQjqNRoaQDAUJx/vf7EaAMZg9x+1M3ghvwO /QJGFfZXzIx5qvWgP4DB19UsDiYZgVaVHNomDJ2oKyHBaIz62Bl9FYrrJTsKOnsurnrkjK5 SpJr0c5/9zulJ6zS183yQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:0YDuq4IyWVc=:fwMjPWGAXTVjdQjWBIflCc 59jzgkaWCBWBXmZSBcL2qci1dCmlIaDv84R5BFvurKEzD7HuePKLGdNJgzzl5XgH1wQkTET0K rhg1d+B/RO1VcQBsKbe07875h+ho7i8wTzxLgKyd6k3eOhU0XB/rcz0MDy6580Fy4QPBaiFym I4m/6Q7f93T4XpoOPuK8NVGqPCQdCAa9pa5iCXP5a3ZXuJ0VxX3LOr6KDaA2bW3wlSMU98aTA KK+eGRf62iyZKqhBQeH46YASyk2EOqZ2ukotZz24UGVfBfVXxVOv0+ChOCKdid6uYP8S2HAD+ qV+J4lfFwLRObJMNAAH62RAPiRduUxwbj+r7bwt6622848t/Q/34oDemrpYb8iwX+VVxu+ivs ZBodILBnUP6BHRTPOBk8bWCkf/j66FPqgOc9JsXONT75kNVwsWyREDf4YOk3eC47mPl4cJgNR 0b2TdolVP1PTdIjnGrgQKkHPo+FjRUIKPu23nOc6Alj9enSkW46CbYf9poKadPUEWqe4r4hyO ZWk/YTO5089/85wWAEDHxw2hmF+ZkjuMpBhs4vuCm2KAwbeQWIWj2ZyrsdFeXu8a2ahQpmKCY 5tkh5BaZb3d7ZcoKUvvgnmf4wVHkxwklVBi2ZGqWD6BP7XlUvnNRTyX1EW1wYqt8tpHdpP4EO GRWxI7bGkZ4MMh/LxYpmvm4K0vjy6B0obJwc/+iOYtQ37/f8GzmL4sRAlNNLKKVAw4EJe02y+ UWD4j7doa8YUu4ZDgluGODgDr8xp5BMNSNRh9QclT3HS8lIUjUV9POoW1fFMuTwO9r0OYxy4t MmtpjeZ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> I prefer that assignments for variables like "card" and "slic_regs" >> will only be performed immediately before the corresponding content will be >> read again (after a few condition checks were executed). >> >> Another description could be this view: >> I suggest to move the variable initialisation a bit. > > And like David Miller and others just said, please don't bother us with > pointless patches such as this, if you keep it up, I'll have to add you > to my killfile as patches like this are a waste of everyone's valuable time. I am a bit surprised that you do not like such source code fine-tuning. Will related software improvements get another chance later (eventually together with other changes)? Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Sun, 03 Jan 2016 18:16:49 +0000 Subject: Re: [PATCH] staging-slicoss: Replace variable initialisations by assignments in slic_if_init() Message-Id: <56896591.2030208@users.sourceforge.net> List-Id: References: <566ABCD9.1060404@users.sourceforge.net> <56894D2D.1010801@users.sourceforge.net> <56895EE1.7080808@users.sourceforge.net> <20160103175816.GA21611@kroah.com> In-Reply-To: <20160103175816.GA21611@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Greg Kroah-Hartman Cc: Julia Lawall , devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org, LKML , Lior Dotan , Christopher Harrer >> I prefer that assignments for variables like "card" and "slic_regs" >> will only be performed immediately before the corresponding content will be >> read again (after a few condition checks were executed). >> >> Another description could be this view: >> I suggest to move the variable initialisation a bit. > > And like David Miller and others just said, please don't bother us with > pointless patches such as this, if you keep it up, I'll have to add you > to my killfile as patches like this are a waste of everyone's valuable time. I am a bit surprised that you do not like such source code fine-tuning. Will related software improvements get another chance later (eventually together with other changes)? Regards, Markus