From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753484AbcADNKr (ORCPT ); Mon, 4 Jan 2016 08:10:47 -0500 Received: from mout.web.de ([212.227.15.4]:63591 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751456AbcADNKo (ORCPT ); Mon, 4 Jan 2016 08:10:44 -0500 Subject: Re: [PATCH 2/2] 390/qeth: Refactoring for qeth_core_set_online() To: Heiko Carstens References: <566ABCD9.1060404@users.sourceforge.net> <5688F13A.70601@users.sourceforge.net> <5688F1D0.3090502@users.sourceforge.net> <20160104113046.GE4179@osiris> Cc: linux-s390@vger.kernel.org, Martin Schwidefsky , Ursula Braun , LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring X-Enigmail-Draft-Status: N1110 Message-ID: <568A6F4A.1000206@users.sourceforge.net> Date: Mon, 4 Jan 2016 14:10:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20160104113046.GE4179@osiris> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:axaRrtVq/9fdFpi24sijaqAUqBdV89t1xrbpoh66Nqs3QRcyVVm jOudvZzVBquTTMFl8Ld9vy7hrZSFxC1tUcTPH/UTuURGAXg2BB2+n6+oKdiB8qkNQmCJJPH mC2PH8E+xy7GND/fk/sb2XayLxf5AK7YmNsyytzHPcZAM0Hyn5rnFgqQm08Esqa6riwQYhy t5GR+SNHXEW2Lv0ZINj5g== X-UI-Out-Filterresults: notjunk:1;V01:K0:V9QDKDkISw4=:QBAYkvvyoM0oCWigvnyEVN 5cIPrqbltDuM80c13emHrbjqpyLxJFGJWBNgd6mAnaPmpjXA7cGDIopqhQxOfe22Ux63jNyfM 8t6GzXReAQsMpNCdq/pvIUkaChKEd5p3GLlxC7uZvCZ2gZfpevxsYQJAcX7+Cy/gHDLSZ0we2 F8XK1SzXxSyZxjYJ+0jqIB3CO1HH/+PrciIO7yl+m282RQYHQboNTN6uUzjLDDldh8lytB2mA /uKROZsE2nalO20DsHMEvKmsPpsJ+AGMLQ3dDqQGesKMAMolXj5QPpq1VXiskkoO7JTPrIIqr 5+E4p0vMuoh3+nQ3fGeJarm3ZheNF5Qdogj+9T1kF+Ekoy7LInC1J+ETo81rTOGj0InSamb/r jV2n/RHGpFAF7d/mf9cz0LWFDx/2fn9rqiutNxHP6cMa3N5Kmoh5msiBfI1HNAH7X97IcRW2P k9IMUp5/nBDgszGONBfmX3w+7aiZPcWJJqhcjOf6w5P0+rXrA5asGSarjrQcN9ItnssuGXkvd shIJFe7NKU4Cv1jM7oVhOgwnuzY2k97rDVHFhtmWd+uQ2bgxP/IOhupEufqDTgfXbhbzDcNg1 QMM6aTdCqveGyOY1HwxWt0V5idi9/bfrvi6GF0djE5OE+wyJHkcVtK7/3rTfSWqReoNREv8GD z0kJNyh/lrfaXpKy8jkM2BBYmslfFzE1w1W6yfLCNdE8dvBBxECJR80vpUrZe3KscHHL+l1MD ZLTUExpBHUOBCscONwQ+MLnUbm0bscYogV5R7eaQ3nc/VvCl42KELqdLHzMOQElNyol3JfYSo 8SLSSai Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> +++ b/drivers/s390/net/qeth_core_main.c >> @@ -5638,9 +5638,10 @@ static int qeth_core_set_online(struct ccwgroup_device *gdev) >> { >> struct qeth_card *card = dev_get_drvdata(&gdev->dev); >> int rc; >> - int def_discipline; >> >> if (!card->discipline) { >> + int def_discipline; >> + >> if (card->info.type == QETH_CARD_TYPE_IQD) >> def_discipline = QETH_DISCIPLINE_LAYER3; > > Same here: I don't think we want to start with patches like this. Thanks for your feedback. > This going to be a never ending story without much benefit. Is the source code a bit clearer and safer if it will be expressed directly that the use of a specific variable is not intended for a complete function implementation but for the smaller scope of an if branch? Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Mon, 04 Jan 2016 13:10:34 +0000 Subject: Re: [PATCH 2/2] 390/qeth: Refactoring for qeth_core_set_online() Message-Id: <568A6F4A.1000206@users.sourceforge.net> List-Id: References: <566ABCD9.1060404@users.sourceforge.net> <5688F13A.70601@users.sourceforge.net> <5688F1D0.3090502@users.sourceforge.net> <20160104113046.GE4179@osiris> In-Reply-To: <20160104113046.GE4179@osiris> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Heiko Carstens Cc: linux-s390@vger.kernel.org, Martin Schwidefsky , Ursula Braun , LKML , kernel-janitors@vger.kernel.org, Julia Lawall >> +++ b/drivers/s390/net/qeth_core_main.c >> @@ -5638,9 +5638,10 @@ static int qeth_core_set_online(struct ccwgroup_device *gdev) >> { >> struct qeth_card *card = dev_get_drvdata(&gdev->dev); >> int rc; >> - int def_discipline; >> >> if (!card->discipline) { >> + int def_discipline; >> + >> if (card->info.type = QETH_CARD_TYPE_IQD) >> def_discipline = QETH_DISCIPLINE_LAYER3; > > Same here: I don't think we want to start with patches like this. Thanks for your feedback. > This going to be a never ending story without much benefit. Is the source code a bit clearer and safer if it will be expressed directly that the use of a specific variable is not intended for a complete function implementation but for the smaller scope of an if branch? Regards, Markus