From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751865AbcADOKx (ORCPT ); Mon, 4 Jan 2016 09:10:53 -0500 Received: from mout.web.de ([212.227.15.14]:61234 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751297AbcADOKu (ORCPT ); Mon, 4 Jan 2016 09:10:50 -0500 Subject: Re: 390/qeth: Refactoring for qeth_core_set_online() To: Heiko Carstens References: <566ABCD9.1060404@users.sourceforge.net> <5688F13A.70601@users.sourceforge.net> <5688F1D0.3090502@users.sourceforge.net> <20160104113046.GE4179@osiris> <568A6F4A.1000206@users.sourceforge.net> <20160104140447.GG4179@osiris> Cc: linux-s390@vger.kernel.org, Martin Schwidefsky , Ursula Braun , LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <568A7D61.90703@users.sourceforge.net> Date: Mon, 4 Jan 2016 15:10:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20160104140447.GG4179@osiris> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:vltJddd/dWQV2ULG3BPrU/4YzsmcYfiu5hwI2tu0xGDRM8yqzBl WyV5CKxPVpv2oJce6EkZQbuyq/LIb7sfhSJsOGYLOE1RXu0XBw2EILIvmDZXRPkvzv4nL7v jZAlfI9TCZdHbAusJJtSz/WH+IHLCSogUGg4AAQD3qmEyRgEPBkEDrvkCfXiOhStRrAgmef GYUPVOWZqv7x2LiVJZJaw== X-UI-Out-Filterresults: notjunk:1;V01:K0:mqgids/u0l8=:jcTkumaQX+7Ur++Gv5aNVb u6kdLjbLZeYUA6cqPrkmJZbarqxs2nVc3JSUE6ak3ZLviMZUSk6bmxB65CgCI8Isfkcm/dg/J WwCFlLhA8f8wKlX4WqU4Ojne39IPiZdcJxGlpsWhPwxQhiW2Fkg+fizDczqaaYO4PCzacgpmO f0VOC+WO4AqcCqPwuFQ1DN6/4YEVnpagV1EQhsE3/stuB+xyWBkXx/VmKWplpaOlCUyFGaFIE BPSur+WtBb4mFhDiX7kGwZvqn/4wgMQYDuVQZveDyMaoofRfaZ/8Nz1PB2zx9uzd6Jj5bbOQi 3SycEAkQHYPFeut/20rSuLNZRxm2qvOXepzZrmY0uzGqvZo/qxjYwwYFX2iW5xk1TmEWGHepp m3M2BBiOiWZ9fnA6w9zqxJEXYjaabZNUFXyHIKCalAwoDT1Ih/8b2f6qRCje5n8hyQ3SaBnGq yC60JLr5RNMeuuF9ehI+oYAaFP4ZDTSz1EjCYrU2aVpGKzIxQMrnwGa75gfqznEYce+nUaxci nvO6Z4WyraMz7qa66Sq20e0JXz9vUA5QUgu6CV/LwVKecU8OBr1dZPd8X6AIu3dlnVjJAC4lr gLCnv+K0UV6w3YemWFv3BFOIw3RlIKNPjsDI3RbMI094j00Sb5ssLkbudAIWK6YNch5gjLRJc uif3P6QrS+aJLhLYSAoUKyiEf/ws2/ZUg/1w2Z/G926P+zG94AOkbpsBpl8h1PAklYvCAXdfS DTcbhnpUQ+X1rYGeLfpzxofo8eMWwUMApbNEeUO3XPzBr4ySOReskBfr15rKxIf+62GyyBUwi l8GGA+S Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > In this case the function body is very small > so I don't see any benefit at all. Do you care for fine-tuning of variable placement occasionally? Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Mon, 04 Jan 2016 14:10:41 +0000 Subject: Re: 390/qeth: Refactoring for qeth_core_set_online() Message-Id: <568A7D61.90703@users.sourceforge.net> List-Id: References: <566ABCD9.1060404@users.sourceforge.net> <5688F13A.70601@users.sourceforge.net> <5688F1D0.3090502@users.sourceforge.net> <20160104113046.GE4179@osiris> <568A6F4A.1000206@users.sourceforge.net> <20160104140447.GG4179@osiris> In-Reply-To: <20160104140447.GG4179@osiris> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Heiko Carstens Cc: linux-s390@vger.kernel.org, Martin Schwidefsky , Ursula Braun , LKML , kernel-janitors@vger.kernel.org, Julia Lawall > In this case the function body is very small > so I don't see any benefit at all. Do you care for fine-tuning of variable placement occasionally? Regards, Markus