From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stanimir Varbanov Subject: Re: [PATCH v5 1/5] PCI: designware: ensure ATU is enabled before IO/conf space accesses Date: Mon, 4 Jan 2016 16:31:27 +0200 Message-ID: <568A823F.5090209@mm-sol.com> References: <1450442339-18765-1-git-send-email-stanimir.varbanov@linaro.org> <1450442339-18765-2-git-send-email-stanimir.varbanov@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Bjorn Helgaas Cc: Pratyush Anand , Stanimir Varbanov , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-pci@vger.kernel.org" , Srinivas Kandagatla , Russell King , Rob Herring , Rob Herring , Mark Rutland , Pawel Moll , Ian Campbell , Arnd Bergmann , Jingoo Han , Bjorn Andersson List-Id: linux-arm-msm@vger.kernel.org On 12/18/2015 04:41 PM, Pratyush Anand wrote: > On Fri, Dec 18, 2015 at 6:08 PM, Stanimir Varbanov > wrote: >> There is no guarantees that enabling ATU will hit the hardware >> immediately, and subsequent accesses to configuration / IO spaces >> are reliable. So fixing this by read back PCIE_ATU_CR2 register >> just after writing. >> >> Without such a fix the PCI device enumeration during kernel boot >> is not reliable, and reading configuration space for particular >> PCI device on the bus returns zero aka no device. >> >> Signed-off-by: Stanimir Varbanov > > Acked-by: Pratyush Anand Bjorn, Do you want to resend the whole patchset with collected acks and tested tags? -- regards, Stan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751856AbcADObi (ORCPT ); Mon, 4 Jan 2016 09:31:38 -0500 Received: from ns.mm-sol.com ([37.157.136.199]:43336 "EHLO extserv.mm-sol.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751590AbcADObc (ORCPT ); Mon, 4 Jan 2016 09:31:32 -0500 Subject: Re: [PATCH v5 1/5] PCI: designware: ensure ATU is enabled before IO/conf space accesses References: <1450442339-18765-1-git-send-email-stanimir.varbanov@linaro.org> <1450442339-18765-2-git-send-email-stanimir.varbanov@linaro.org> Cc: Pratyush Anand , Stanimir Varbanov , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-pci@vger.kernel.org" , Srinivas Kandagatla , Russell King , Rob Herring , Rob Herring , Mark Rutland , Pawel Moll , Ian Campbell , Arnd Bergmann , Jingoo Han , Bjorn Andersson To: Bjorn Helgaas From: Stanimir Varbanov Message-ID: <568A823F.5090209@mm-sol.com> Date: Mon, 4 Jan 2016 16:31:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/18/2015 04:41 PM, Pratyush Anand wrote: > On Fri, Dec 18, 2015 at 6:08 PM, Stanimir Varbanov > wrote: >> There is no guarantees that enabling ATU will hit the hardware >> immediately, and subsequent accesses to configuration / IO spaces >> are reliable. So fixing this by read back PCIE_ATU_CR2 register >> just after writing. >> >> Without such a fix the PCI device enumeration during kernel boot >> is not reliable, and reading configuration space for particular >> PCI device on the bus returns zero aka no device. >> >> Signed-off-by: Stanimir Varbanov > > Acked-by: Pratyush Anand Bjorn, Do you want to resend the whole patchset with collected acks and tested tags? -- regards, Stan From mboxrd@z Thu Jan 1 00:00:00 1970 From: svarbanov@mm-sol.com (Stanimir Varbanov) Date: Mon, 4 Jan 2016 16:31:27 +0200 Subject: [PATCH v5 1/5] PCI: designware: ensure ATU is enabled before IO/conf space accesses In-Reply-To: References: <1450442339-18765-1-git-send-email-stanimir.varbanov@linaro.org> <1450442339-18765-2-git-send-email-stanimir.varbanov@linaro.org> Message-ID: <568A823F.5090209@mm-sol.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 12/18/2015 04:41 PM, Pratyush Anand wrote: > On Fri, Dec 18, 2015 at 6:08 PM, Stanimir Varbanov > wrote: >> There is no guarantees that enabling ATU will hit the hardware >> immediately, and subsequent accesses to configuration / IO spaces >> are reliable. So fixing this by read back PCIE_ATU_CR2 register >> just after writing. >> >> Without such a fix the PCI device enumeration during kernel boot >> is not reliable, and reading configuration space for particular >> PCI device on the bus returns zero aka no device. >> >> Signed-off-by: Stanimir Varbanov > > Acked-by: Pratyush Anand Bjorn, Do you want to resend the whole patchset with collected acks and tested tags? -- regards, Stan