From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752324AbcAEMVE (ORCPT ); Tue, 5 Jan 2016 07:21:04 -0500 Received: from mail-wm0-f48.google.com ([74.125.82.48]:37486 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752236AbcAEMVB (ORCPT ); Tue, 5 Jan 2016 07:21:01 -0500 Subject: Re: [PATCH v4 net-next 2/3] net: macb: Add NPx macb config using USRIO_DISABLED cap To: Nicolas Ferre , davem@davemloft.net, harini.katakam@xilinx.com, boris.brezillon@free-electrons.com, alexandre.belloni@free-electrons.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, joshc@ni.com, devicetree@vger.kernel.org, Rob Herring References: <1451898103-21868-1-git-send-email-narmstrong@baylibre.com> <1451900573-22657-1-git-send-email-narmstrong@baylibre.com> <1451900573-22657-3-git-send-email-narmstrong@baylibre.com> <568A4BC0.2090005@atmel.com> From: Neil Armstrong Organization: Baylibre Message-ID: <568BB522.4060905@baylibre.com> Date: Tue, 5 Jan 2016 13:20:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <568A4BC0.2090005@atmel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/04/2016 11:38 AM, Nicolas Ferre wrote: > Le 04/01/2016 10:42, Neil Armstrong a écrit : >> static const struct macb_config zynqmp_config = { >> .caps = MACB_CAPS_GIGABIT_MODE_AVAILABLE | MACB_CAPS_JUMBO, >> @@ -2801,6 +2806,7 @@ static const struct of_device_id macb_dt_ids[] = { >> { .compatible = "cdns,at32ap7000-macb" }, >> { .compatible = "cdns,at91sam9260-macb", .data = &at91sam9260_config }, >> { .compatible = "cdns,macb" }, >> + { .compatible = "cdns,npx-macb", .data = &npx_config }, > > I can accept that, but I think that you'd better make your device tree > compatibility string *not* generic. Name it by the first NPx SoC or > perfectly compatible SoC family that has this configuration and you'll > be able to make the NP(x+1) compatible with it. Well, the first Soc having this configuration is Np4, would cdns,np4-macb be ok ? > > It has proven to be much more future proof and even if in the early days > of DT on ARM we accepted some binding with generic strings like this one > below, It has proven to be a mistake. > >> { .compatible = "cdns,gem", .data = &pc302gem_config }, >> { .compatible = "atmel,sama5d2-gem", .data = &sama5d2_config }, >> > > Neil