From: Laurent Vivier <lvivier@redhat.com>
To: Andrew Jones <drjones@redhat.com>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH] trace-events: fix broken format strings
Date: Tue, 5 Jan 2016 15:54:48 +0100 [thread overview]
Message-ID: <568BD938.4040502@redhat.com> (raw)
In-Reply-To: <1452000043-23567-1-git-send-email-drjones@redhat.com>
On 05/01/2016 14:20, Andrew Jones wrote:
> Fixes compiling with --enable-trace-backends
>
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
> trace-events | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/trace-events b/trace-events
> index 6f036384a84f8..e42898d5659d5 100644
> --- a/trace-events
> +++ b/trace-events
> @@ -1799,15 +1799,15 @@ qcrypto_tls_session_new(void *session, void *creds, const char *hostname, const
> vhost_user_event(const char *chr, int event) "chr: %s got event: %d"
>
> # linux-user/signal.c
> -user_setup_frame(void *env, uint64_t frame_addr) "env=%p frame_addr="PRIx64""
> -user_setup_rt_frame(void *env, uint64_t frame_addr) "env=%p frame_addr="PRIx64""
> -user_do_rt_sigreturn(void *env, uint64_t frame_addr) "env=%p frame_addr="PRIx64""
> -user_do_sigreturn(void *env, uint64_t frame_addr) "env=%p frame_addr="PRIx64""
> +user_setup_frame(void *env, uint64_t frame_addr) "env=%p frame_addr=0x%"PRIx64""
> +user_setup_rt_frame(void *env, uint64_t frame_addr) "env=%p frame_addr=0x%"PRIx64""
> +user_do_rt_sigreturn(void *env, uint64_t frame_addr) "env=%p frame_addr=0x%"PRIx64""
> +user_do_sigreturn(void *env, uint64_t frame_addr) "env=%p frame_addr=0x%"PRIx64""
I think there are too many quotes. This looks more correct:
"env=%p frame_addr=0x%"PRIx64
> user_force_sig(void *env, int target_sig, int host_sig) "env=%p signal %d (host %d)"
> user_handle_signal(void *env, int target_sig) "env=%p signal %d"
> user_host_signal(void *env, int host_sig, int target_sig) "env=%p signal %d (target %d("
> user_queue_signal(void *env, int target_sig) "env=%p signal %d"
> -user_s390x_restore_sigregs(void *env, uint64_t sc_psw_addr, uint64_t env_psw_addr) "env=%p frame psw.addr "PRIx64 " current psw.addr "PRIx64""
> +user_s390x_restore_sigregs(void *env, uint64_t sc_psw_addr, uint64_t env_psw_addr) "env=%p frame psw.addr 0x%"PRIx64 " current psw.addr 0x%"PRIx64""
>
> # io/task.c
> qio_task_new(void *task, void *source, void *func, void *opaque) "Task new task=%p source=%p func=%p opaque=%p"
>
next prev parent reply other threads:[~2016-01-05 14:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 13:20 [Qemu-devel] [PATCH] trace-events: fix broken format strings Andrew Jones
2016-01-05 14:54 ` Laurent Vivier [this message]
2016-01-05 15:24 ` Andrew Jones
2016-01-05 15:35 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568BD938.4040502@redhat.com \
--to=lvivier@redhat.com \
--cc=drjones@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.